Re: Review Request: Use window() as KNotificationItem::associatedWidget() to avoid native widgets

2009-09-24 Thread Christoph Feck
> On 2009-09-24 10:40:54, Marco Martin wrote: > > have you teste what happens when the associated widget is actually 0? What should I test here? The documentation does not state the expected behaviour when passing a 0 or non-widget parent. The patch only ensures that KWindowSystem is not calle

KDE/kdelibs/plasma/widgets

2009-09-24 Thread Marco Martin
SVN commit 1027814 by mart: ensureRectVisible() a rect in internal widget coordinates will cause an animated scroll until the rect becomes visible it should not collide with kinetic scroll since the anim is stopped as soon as amouse or wheel event is triggered CCMAIL:plasma-devel@kde.org M +42

Re: Review Request: added support for collors and size on fifteenpuzzle.

2009-09-24 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1706/#review2461 --- Ship it! there are some formatting issues, but otherwise this is read

Re: Declarative UI Integration, reprise

2009-09-24 Thread Chani
On September 24, 2009 05:07:31 Marco Martin wrote: > On Thursday 24 September 2009, Alan Alpert wrote: > > On Thu, 24 Sep 2009 20:38:16 ext Marco Martin wrote: > > > On Thursday 24 September 2009, Alan Alpert wrote: > > > ... > > > > > > i'm compiling the branch right now, then i'll be able to give

Re: Review request: Container plasma applet

2009-09-24 Thread Aaron J. Seigo
On September 24, 2009, Riccardo Iaconelli wrote: > On Wednesday 23 September 2009 10:11:19 Marco Martin wrote: > > this means those plasmoids have to be fixed. in particular the > > battery applet should have a constrainedsquare aspect ratio andstill > > draw the svg as square when the applet is r

Re: Review Request: Allows selection of icons using the SHIFT key.

2009-09-24 Thread Shantanu Tushar Jha
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1709/ --- (Updated 2009-09-24 16:37:05.117590) Review request for Plasma. Changes --

Re: Review request: Container plasma applet

2009-09-24 Thread Marco Martin
On Thursday 24 September 2009, Riccardo Iaconelli wrote: > On Wednesday 23 September 2009 10:11:19 Marco Martin wrote: > > this means those plasmoids have to be fixed. in particular the > > battery applet should have a constrainedsquare aspect ratio andstill > > draw the svg as square when the app

Re: Review request: Container plasma applet

2009-09-24 Thread Riccardo Iaconelli
On Wednesday 23 September 2009 10:11:19 Marco Martin wrote: > this means those plasmoids have to be fixed. in particular the > battery applet should have a constrainedsquare aspect ratio andstill > draw the svg as square when the applet is rectangular Hm... to be sincere, I think that the batter

Re: Review Request: Allows selection of icons using the SHIFT key.

2009-09-24 Thread Shantanu Tushar Jha
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1709/ --- (Updated 2009-09-24 16:03:18.965662) Review request for Plasma. Summary --

Review Request: Allows selection of icons using the SHIFT key.

2009-09-24 Thread Shantanu Tushar Jha
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1709/ --- Review request for Plasma. Summary --- If the view is arranged (i.e. m_layo

Re: Review Request: added support for collors and size on fifteenpuzzle.

2009-09-24 Thread Tomaz Canabrava
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1706/ --- (Updated 2009-09-24 15:05:37.627922) Review request for Plasma. Changes --

Re: Review Request: added support for collors and size on fifteenpuzzle.

2009-09-24 Thread Tomaz Canabrava
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1706/ --- (Updated 2009-09-24 15:01:36.918350) Review request for Plasma. Changes --

Re: Declarative UI Integration, reprise

2009-09-24 Thread Marco Martin
On Thursday 24 September 2009, Alan Alpert wrote: > On Thu, 24 Sep 2009 20:38:16 ext Marco Martin wrote: > > On Thursday 24 September 2009, Alan Alpert wrote: > > ... > > > > i'm compiling the branch right now, then i'll be able to give more in > > depth look. > > > > just quickly looking at it 2 t

Re: Declarative UI Integration, reprise

2009-09-24 Thread Alan Alpert
On Thu, 24 Sep 2009 20:38:16 ext Marco Martin wrote: > On Thursday 24 September 2009, Alan Alpert wrote: > ... > > i'm compiling the branch right now, then i'll be able to give more in depth > look. > > just quickly looking at it 2 things comes to my mind: > -in the qml the word Plasmoid is used fo

Re: Review Request: Use window() as KNotificationItem::associatedWidget() to avoid native widgets

2009-09-24 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1707/#review2457 --- have you teste what happens when the associated widget is actually 0?

Re: Declarative UI Integration, reprise

2009-09-24 Thread Marco Martin
On Thursday 24 September 2009, Alan Alpert wrote: > Hello Plasma Devs, > > Firstly, I've just written a blog post about the Declarative UI plasma > integration ( http://labs.trolltech.com/blogs/2009/09/24/qt-declarative-ui- > and-plasma/ ). It explains the vision of Declarative UI, as it relates to

Re: Problem to use PopupApplet

2009-09-24 Thread Charles Wautier
2009/9/22 Aaron J. Seigo > hi Charles; > > let's keep this on plasma-de...@kde.org. > > On September 21, 2009, Charles Wautier wrote: > > 2009/9/21 Aaron J. Seigo > > > > > On September 21, 2009, Charles Wautier wrote: > > > > What makes this plasmoid unusual is that the Popup showing/hiding is

Re: Review Request: Ported KTimeTracker to KNotification

2009-09-24 Thread Thorsten Staerk
> On 2009-09-21 13:41:29, Thorsten Staerk wrote: > > Good to see you working on my baby ktimetracker. Let's have a discussion on > > irc. > > Davide Bettio wrote: > ok. my timezone is CET. I'm on IRC in the afternoon and in the night. You > can find me in #plasma. > > Thorsten Staerk wrot

Re: Review Request: Ported KTimeTracker to KNotification

2009-09-24 Thread Thorsten Staerk
> On 2009-09-21 13:41:29, Thorsten Staerk wrote: > > Good to see you working on my baby ktimetracker. Let's have a discussion on > > irc. > > Davide Bettio wrote: > ok. my timezone is CET. I'm on IRC in the afternoon and in the night. You > can find me in #plasma. Did not work - most impo

Re: Review Request: Plasma + Nepomuk - libplasma patch - attempt 1

2009-09-24 Thread Ivan Cukic
> On 2009-09-23 21:51:17, Chani wrote: > > /trunk/KDE/kdelibs/plasma/containment.h, line 358 > > > > > > s/activity/activityId to be extra clear. I don't like how "activity" > > sometimes means the name and sometimes the

Re: Review Request: Plasma + Nepomuk - libplasma patch - attempt 1

2009-09-24 Thread Ivan Cukic
> On 2009-09-23 21:28:50, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/context.h, line 67 > > > > > > ensureActivityExists? > > > > or maybe ensureActivity and createActivity could be merged? maybe > > someth

Re: Ayatana notifications for Plasma

2009-09-24 Thread Aurélien Gâteau
Aaron J. Seigo wrote: > On September 23, 2009, Aurélien Gâteau wrote: >> Aaron J. Seigo a écrit : >>> On September 23, 2009, Marco Martin wrote: every other consideration aside, i feel that it would have been -far- easier to mantain if the systray patch just consisted in notifications >>