Re: Review Request: Add a tooltip to battery monitor applet

2009-10-30 Thread Kåre Särs
> On 2009-10-29 20:55:56, Aaron Seigo wrote: > > trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp, > > line 63 > > > > > > interestingly, you don't need to include this one as ToolTipManager > > dra

Re: Review Request: plasmapkg & wallpaper

2009-10-30 Thread Petri Damstén
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2006/ --- (Updated 2009-10-30 08:07:28.008673) Review request for Plasma. Changes --

Review Request: return minimum size for Plasma::Frame

2009-10-30 Thread Petri Damstén
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2018/ --- Review request for Plasma. Summary --- return minimum size for Plasma::Fram

Re: Review Request: return minimum size for Plasma::Frame

2009-10-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2018/#review2867 --- Ship it! good catch /trunk/KDE/kdelibs/plasma/widgets/frame.cpp

Re: Review Request: return minimum size for Plasma::Frame

2009-10-30 Thread Petri Damstén
> On 2009-10-30 09:58:36, Marco Martin wrote: > > /trunk/KDE/kdelibs/plasma/widgets/frame.cpp, line 272 > > > > > > perhaps it should be the preferred too Added it to preferred too. - Petri --

setData & QVariant

2009-10-30 Thread Petri Damstén
Hi, I'm trying to fix BUG 212342. It seems like if variable is put to QVariant and then as a parameter to setData it does not work. If same variable is put as a parameter to setData directly it works? see attached patch. I think this happened after updating to Qt 4.6. Petri Index: soliddevicee

Re: Review Request: Plasma Netbook animated Version 1

2009-10-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2008/#review2870 --- Ship it! to me looks good. i think the grid animation there is here s

Re: How to get Akonadi notes onto Plasma?

2009-10-30 Thread Stephen Kelly
Stephen Kelly wrote: >> i think in this case, maybe start with the intended user experience. i'm >> not sure what you are actually envisioning for the user experience. e.g.: >> >> should notes appear automatically on your desktop / panel when they >> appear in Akonadi, so if i add a note in Kontac

Review Request: Comic applet proted to PopupApplet

2009-10-30 Thread Giulio Camuffo
I'm posting this here instead of on the ReviewBoard because it's currently somehow broken. I noticed some days ago that the Comic applet isn't a PopupApplet, so when in the panel it is unusable. So this patch fixes this. It works, but there is a thing puzzling me: when it is "popupped" and it i

Re: setData & QVariant

2009-10-30 Thread Aaron J. Seigo
On October 30, 2009, Petri Damstén wrote: > I'm trying to fix BUG 212342. It seems like if variable is put to QVariant > and then as a parameter to setData it does not work. If same variable is odd ... what does a simple app like this give you: #include #include using namespace std; int main

Re: Review Request: Comic applet proted to PopupApplet

2009-10-30 Thread Aaron J. Seigo
On October 30, 2009, Giulio Camuffo wrote: > So this patch fixes this. i think you forgot the patch (it's so easy to know when people aren't using kmail sometimes ;) > downloading the comic, it calls setBusy(true). So a BusyWidget is shown, > but it is shown over the icon on the panel instead o

pastebin plasmoid.

2009-10-30 Thread goodhabit
Hello. Is it possible to tune plasmoid to return direct link to images? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: How to get Akonadi notes onto Plasma?

2009-10-30 Thread Aaron J. Seigo
On October 30, 2009, Stephen Kelly wrote: > would prefer to only show the actual notes in the stack on click so they > could be dragged elsewhere. Obviously the background svg of it should not > be as it is, or the size it currently is. Additionally I need to give some > visual indication of colo

Re: How to get Akonadi notes onto Plasma?

2009-10-30 Thread Thomas Olsen
On 30/10-2009 19:10 "Aaron J. Seigo" wrote: > On October 30, 2009, Stephen Kelly wrote: > > would prefer to only show the actual notes in the stack on click so they > > could be dragged elsewhere. Obviously the background svg of it should not > > be as it is, or the size it currently is. Addition

Re: pastebin plasmoid.

2009-10-30 Thread Artur Souza (MoRpHeUz)
On Friday 30 October 2009, 08:59 goodha...@gmail.com wrote: > Hello. Is it possible to tune plasmoid to return direct link to images? What do you mean by that ? The url to just the image ? Probably not as it would not be fair enough with the service provider as it "survives" with the ads it has

Re: Review Request: Comic applet proted to PopupApplet

2009-10-30 Thread Giulio Camuffo
In data venerdì 30 ottobre 2009 18:03:07, Aaron J. Seigo ha scritto: : > On October 30, 2009, Giulio Camuffo wrote: > > So this patch fixes this. > > i think you forgot the patch > > (it's so easy to know when people aren't using kmail sometimes ;) > :-O :-F you're right!! i'm a fool! and i'm ev

Re: Review Request: Add a tooltip to battery monitor applet

2009-10-30 Thread Chani
> > On 2009-10-29 20:55:56, Aaron Seigo wrote: > > > trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp, > > > line 1123 > > > > >> > > > > > > we don't show time remaining; it's a bogus number. perc

Re: Review Request: Add a tooltip to battery monitor applet

2009-10-30 Thread Aaron J. Seigo
On October 30, 2009, Chani wrote: > percentages are the bogus number :P it's like giving a latitude and > longitude instead of a street address. except my street address doesn't change just because i drive there in a car instead of walk. a more accurate analogy would be offering a travel time (

Re: Review Request: Comic applet proted to PopupApplet

2009-10-30 Thread Aaron J. Seigo
On October 30, 2009, Giulio Camuffo wrote: > In data venerdì 30 ottobre 2009 18:03:07, Aaron J. Seigo ha scritto: > : > On October 30, 2009, Giulio Camuffo wrote: > : > > > > So this patch fixes this. > > > > i think you forgot the patch it looks good except for setting a minimum size of 20x20. th

Re: Review Request: Add a tooltip to battery monitor applet

2009-10-30 Thread Chani
On October 30, 2009 18:24:03 Aaron J. Seigo wrote: > On October 30, 2009, Chani wrote: > > percentages are the bogus number :P it's like giving a latitude and > > longitude instead of a street address. > > except my street address doesn't change just because i drive there in a car > instead of wa