Re: Review Request: Use Plasma::ScrollWidget in the widget explorer

2010-10-05 Thread Aurélien Gâteau
> On 2010-10-01 17:21:28, Aaron Seigo wrote: > > update to current trunk if needed, and let's get this in as well. > > Anselmo L. S. Melo wrote: > @agateau: I've updated this patch to current trunk [1] - I updated it > when I wrote another patch [2], to check if both patches were ok togethe

Re: Re: Plasma::PopupApplet improvements

2010-10-05 Thread Ivan Cukic
> what's the name of that method? > /me is wondering whether it'll be easy for newbies to tell which is which :) I think it will - bool isPopupShowing () const :) > > > > 2. void setPopupText(const QString & text) and QString popupText() > > > > const This one I'm unsure about whether it is reall

Re: Re: Plasma::PopupApplet improvements

2010-10-05 Thread Ivan Cukic
> > Some ppl want to replicate the gnome panel (yes, i know they are wrong, but > > ... :) ) > > well, if it doesn't have to be done with an existing menu applet, it is > possible, just don't set any icon for the popup applet, then put a custom > icon+label in the main layout and voilà Meh, I'll

Re: Re: Plasma::PopupApplet improvements

2010-10-05 Thread Ivan Cukic
> > 2. void setPopupText(const QString & text) and QString popupText() const > > This one I'm unsure about whether it is really needed - it would show an > > icon beside the text when the applet is in the iconified state. > > i don't think i see an use case for this (also because i don't think wo

Re: Re: Plasma::PopupApplet improvements

2010-10-05 Thread Ivan Cukic
On Tuesday, 5. October 2010. 15.37.31 Chani wrote: > On October 5, 2010 15:28:14 Ivan Cukic wrote: > > Hi all, > > > > There are a few things I wanted to ask your for opinions before > > implementing them: > > > > 1. bool isIconified() const > > Introducing this method that would return whether t

Re: Review Request: Add city and country resolution to GPS geolocation data using geonames.

2010-10-05 Thread John Layt
On Monday 04 October 2010 20:31:36 John Layt wrote: > On Saturday 25 September 2010 19:44:09 you wrote: > > On Saturday, September 25, 2010, you wrote: > > > However, we really need to sort > > > out geolocation services for KDE as a whole, re-inventing everything > > > that Geoclue and Marble have

Plasma::PopupApplet improvements

2010-10-05 Thread Ivan Cukic
Hi all, There are a few things I wanted to ask your for opinions before implementing them: 1. bool isIconified() const Introducing this method that would return whether the applet is shown full, or just as an icon. 2. void setPopupText(const QString & text) and QString popupText() const This o

Re: Review Request: Startup Feedback KWin Effect

2010-10-05 Thread Martin Gräßlin
> On 2010-10-05 11:26:28, Lubos Lunak wrote: > > The KRunner detour is unnecessary, KWin doesn't need to be told by KRunner > > things it can find out on its own. It'd be cleaner to just have the KWin > > effect use KSelectionOwner to claim a manager selection and KRunner would > > not do anyt

Re: Review Request: Startup Feedback KWin Effect

2010-10-05 Thread Lubos Lunak
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5529/#review7973 --- The KRunner detour is unnecessary, KWin doesn't need to be told by

Review Request: Startup Feedback KWin Effect

2010-10-05 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5529/ --- Review request for kwin, Plasma and Lubos Lunak. Summary --- Implemente