Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

2010-10-25 Thread Ingomar Wesp
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/ --- (Updated 2010-10-25 23:54:14.696262) Review request for Plasma. Changes --

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

2010-10-25 Thread Ingomar Wesp
> On 2010-10-25 20:43:20, Marco Martin wrote: > > /trunk/KDE/kdelibs/plasma/svg.cpp, line 259 > > > > > > this creates a renderer too often. > > since the purpose of the cache is avoid to create renderers this is

Re: Review Request: More improvements to the Fifteen puzzle

2010-10-25 Thread Anthony Bryant
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5617/#review8352 --- Would someone mind reviewing this please? I'd like to get it in be

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

2010-10-25 Thread Manuel Mommertz
> On 2010-10-25 20:43:20, Marco Martin wrote: > > /trunk/KDE/kdelibs/plasma/svg.cpp, line 259 > > > > > > this creates a renderer too often. > > since the purpose of the cache is avoid to create renderers this is

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

2010-10-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/#review8349 --- /trunk/KDE/kdelibs/plasma/svg.cpp

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

2010-10-25 Thread Manuel Mommertz
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/#review8346 --- Ship it! Ok, the performance should be acceptable and the patch l

Re: Review Request: Microblog: small patch so that microblog remembers the password even when kwallet is disabled

2010-10-25 Thread Chani Armitage
> On 2010-10-21 15:39:47, Marco Martin wrote: > > for me is okay, even if an obscured password directly in the config file > > isn't great... > > some time ago it did already this thing, why was it removed? good question. Mohit, you should look in the svn log and see if there was a reason it w

Re: digiclock looks

2010-10-25 Thread Shantanu Tushar Jha
On Sat, Oct 23, 2010 at 5:12 AM, Sebastian Kügler wrote: > On Friday, October 22, 2010 23:34:16 todd rme wrote: > > On Fri, Oct 22, 2010 at 5:26 PM, Sebastian Kügler wrote: > > > On Friday, October 22, 2010 22:35:16 Sebastian Kügler wrote: > > >> > Is there any way to make it so themes can speci

Re: notification text

2010-10-25 Thread Markus Slopianka
Am Montag 25 Oktober 2010, 15:53:39 schrieb Marco Martin: > here you go, in trunk text is selectable and links clickable In case I never told you: You are my personal hero. :-) Does it also work with Kopete which AFAIK sends HTML-formatted notifications for URLs? _

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

2010-10-25 Thread Ingomar Wesp
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/ --- (Updated 2010-10-25 15:29:32.167235) Review request for Plasma. Summary --

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

2010-10-25 Thread Ingomar Wesp
> On 2010-10-25 08:03:51, Manuel Mommertz wrote: > > If you want to use the DOM to find the size hints, you can take a look at > > KGameSvgDocument. It implements a way to find elements by id. This could > > should be usable for you. > > > > And can you please measure how long it takes to load

questions about PMC

2010-10-25 Thread LucaTringali
Hello, I took a look at http://techbase.kde.org/Schedules/KDE4/4.6_Feature_Plan and I seen that there isn't Plasma Media Center. So PMC will not be released with KDE 4.6? >From the code present in svn playgroud, I discovered that the applet "mediabrowser" doesn't work, because some lines have bee

Re: notification text

2010-10-25 Thread Markus Slopianka
Am Montag 25 Oktober 2010, 13:11:21 schrieb Chani: > ...after googling the part I could read, I got my account unlocked (phew!) > but my point still stands :) I'd rather see clickable URLs than copyable ones... > also, if anyone can recommend a reliable imap server, I would be willing to > pay

notification text

2010-10-25 Thread Chani
so... uhm... I've run into a rather compelling use case for being able to read and copy the full text of notifications: http://chani.ca/sshots/mailfail.png it seem gmail won't let me use kmail until I visit that url (at least, I *hope* visiting that url would fix it, because just logging in doesn't

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

2010-10-25 Thread Manuel Mommertz
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/#review8338 --- If you want to use the DOM to find the size hints, you can take a