Re: Desktop Slideshow Settings

2010-12-05 Thread Aaron J. Seigo
On Sunday, December 5, 2010, Steven Sroka wrote: > add at the very beginning of BackgroundDialog::saveConfig(),if( > !hasChanged() ) { return;}orif( hasChanged() ) { //the existing code that > is run when a setting is changed.} yes, that would work. it would still mean the wallpaper would reload i

RE: Desktop Slideshow Settings

2010-12-05 Thread Steven Sroka
Excuse the messing message before from me, I should top post like this since Windows Live doesn't put arrows before each line of previous emails when replying to them. Even though its not recommended to top post ;) From: steven.sr...@live.ca To: plasma-devel@kde.org Subject: RE: Desktop Slidesh

RE: Desktop Slideshow Settings

2010-12-05 Thread Steven Sroka
On Sunday, December 5, 2010, Steven Sroka wrote: > I'm assuming the settingsChanged() signal is emitted twice, once by 'Apply' > and once by 'OK'. Is there anyway to stop the signal from emitting from > the 'OK' button if the settings aren't changed (because the 'Apply' button > has already emitte

Re: Desktop Slideshow Settings

2010-12-05 Thread Aaron J. Seigo
On Sunday, December 5, 2010, Steven Sroka wrote: > I'm assuming the settingsChanged() signal is emitted twice, once by 'Apply' > and once by 'OK'. Is there anyway to stop the signal from emitting from > the 'OK' button if the settings aren't changed (because the 'Apply' button > has already emitted

Re: The new share dataengine

2010-12-05 Thread Aaron J. Seigo
On Sunday, December 5, 2010, Thomas Olsen wrote: > Is it possible to offer GHNS from a javascript engine or an engine at all? yes; though DataEngines themselves offer no UI. it is usually exposed from a plasmoid's UI (configuration, usually) > I need to have a look at the new share engine; where

Re: Desktop Slideshow Settings

2010-12-05 Thread Aaron J. Seigo
On Sunday, December 5, 2010, Steven Sroka wrote: > I'm assuming the settingsChanged() signal is emitted twice, once by 'Apply' > and once by 'OK'. Is there anyway to stop the signal from emitting from > the 'OK' button if the settings aren't changed (because the 'Apply' button > has already emitted

RE: Desktop Slideshow Settings

2010-12-05 Thread Steven Sroka
Sorry for the late reply, I just switched to KDE 4.6 Beta 1 and it took some time to get stable and fast enough to set up the development dependancies. I'm try to prevent the slideshow wallpaper from changing everytime a user clicks 'OK' after clicking 'Apply'. I'm assuming the settingsChanged(

Re: Review Request: Plasma crash if lockout conf file is malformed.

2010-12-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6060/#review9146 --- Ship it! makes sense to me (it's not doing anymore what te config

Review Request: Plasma crash if lockout conf file is malformed.

2010-12-05 Thread Nicolas Lécureuil
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6060/ --- Review request for Plasma. Summary --- if on the plasma conf file we ha

Re: Review Request: Lockout widget: Explain to the user that he must select a button to show

2010-12-05 Thread Nicolas Lécureuil
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6041/ --- (Updated 2010-12-05 21:41:56.363884) Review request for Plasma. Changes --

Re: The new share dataengine

2010-12-05 Thread Aaron J. Seigo
On Sunday, December 5, 2010, Thomas Olsen wrote: > As I was fiddling around with an URL shortener plasmoid similar to the > pastebin plasmoid I was thinking if it would be an idea to also provide > URL Shortener services in the same engine or id would be better to have a > separate one? imho: it p

Re: Review Request: Separate caching for unthemed SVGs requesting colorization

2010-12-05 Thread Aaron Seigo
> On 2010-12-05 14:50:33, Manuel Mommertz wrote: > > It is now even worse then before. Unthemed graphics still use the colors > > from plasma theme but don't get informed if the theme changes. this means, > > the colors that are used when first rendering the graphics stay even if I > > switch

Re: Review Request: Separate caching for unthemed SVGs requesting colorization

2010-12-05 Thread Manuel Mommertz
> On 2010-12-05 14:50:33, Manuel Mommertz wrote: > > It is now even worse then before. Unthemed graphics still use the colors > > from plasma theme but don't get informed if the theme changes. this means, > > the colors that are used when first rendering the graphics stay even if I > > switch

Re: Review Request: Separate caching for unthemed SVGs requesting colorization

2010-12-05 Thread Aaron Seigo
> On 2010-12-05 14:50:33, Manuel Mommertz wrote: > > It is now even worse then before. Unthemed graphics still use the colors > > from plasma theme but don't get informed if the theme changes. this means, > > the colors that are used when first rendering the graphics stay even if I > > switch

Re: Review Request: Separate caching for unthemed SVGs requesting colorization

2010-12-05 Thread Manuel Mommertz
> On 2010-12-05 14:50:33, Manuel Mommertz wrote: > > It is now even worse then before. Unthemed graphics still use the colors > > from plasma theme but don't get informed if the theme changes. this means, > > the colors that are used when first rendering the graphics stay even if I > > switch

Re: Review Request: Separate caching for unthemed SVGs requesting colorization

2010-12-05 Thread Marco Martin
> On 2010-12-05 14:50:33, Manuel Mommertz wrote: > > It is now even worse then before. Unthemed graphics still use the colors > > from plasma theme but don't get informed if the theme changes. this means, > > the colors that are used when first rendering the graphics stay even if I > > switch

Re: Review Request: Separate caching for unthemed SVGs requesting colorization

2010-12-05 Thread Manuel Mommertz
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6008/#review9136 --- It is now even worse then before. Unthemed graphics still use the