Re: Review Request: Fix notification adjustPosition on resizeEven

2011-07-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101981/#review4782 --- This review has been submitted with commit 848f7d43fd9a9b029d2a

Re: Review Request: Fix notification adjustPosition on resizeEven

2011-07-17 Thread Alex Fiestas
> On July 17, 2011, 7:49 p.m., Aaron J. Seigo wrote: > > plasma/generic/applets/notifications/ui/stackdialog.cpp, lines 298-299 > > > > > > these could be merged into one if () statement. I prefer small conditional

Re: Review Request: Fix notification adjustPosition on resizeEven

2011-07-17 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101981/#review4776 --- Ship it! looks good. one small note on a possible improvement f

Re: Review Request: Build kwin and kwin_gles binary

2011-07-17 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101979/#review4774 --- Not sure I would make KWIN_KDEINIT_BACKEND() a macro. It looks l

Re: Review Request: Fix notification adjustPosition on resizeEven

2011-07-17 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101981/ --- (Updated July 17, 2011, 6:49 p.m.) Review request for Plasma. Changes --

Review Request: Fix notification adjustPosition on resizeEven

2011-07-17 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101981/ --- Review request for Plasma. Summary --- On resizeEvent adjustPosition

Re: Review Request: Move screensaver and locking functionality to kwin from krunner

2011-07-17 Thread Martin Gräßlin
> On July 15, 2011, 3:28 p.m., Martin Gräßlin wrote: > > The code from the SoK project is now in an own branch: > > https://projects.kde.org/projects/kde/kdebase/kde-workspace/repository/revisions/2780fd91810bad353ac33422ce4b3eab291c4b47 > > > > Comparing the two I prefer the SoK commit as it d

Review Request: Build kwin and kwin_gles binary

2011-07-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101979/ --- Review request for kwin, Plasma and Alexander Neundorf. Summary --- M

Re: Review Request: Move screensaver and locking functionality to kwin from krunner

2011-07-17 Thread Alex Merry
> On July 15, 2011, 3:28 p.m., Martin Gräßlin wrote: > > The code from the SoK project is now in an own branch: > > https://projects.kde.org/projects/kde/kdebase/kde-workspace/repository/revisions/2780fd91810bad353ac33422ce4b3eab291c4b47 > > > > Comparing the two I prefer the SoK commit as it d

Re: problems in package land

2011-07-17 Thread Marco Martin
On Saturday 16 July 2011, Aaron J. Seigo wrote: > hi ... > > first off: unit tests are indeed The Awesome. the findings below are all a > result of trying to make the unit tests in libplasma pass. i probably would > not have noticed these issues, along with several others that i have > already fix

problems in package land

2011-07-17 Thread Aaron J. Seigo
hi ... first off: unit tests are indeed The Awesome. the findings below are all a result of trying to make the unit tests in libplasma pass. i probably would not have noticed these issues, along with several others that i have already fixed, if it were not for those unit tests. and these are te