Re: Review Request: quicklaunch: Add a confirmation dialog before the delete

2011-09-30 Thread Aaron J. Seigo
> On Sept. 29, 2011, 11:55 a.m., Sebastian Kügler wrote: > > First, this is the wrong way to fix it. Why should this confirmation only > > go for a specific widget? This introduces inconsistence in the UI that > > leads to more data loss (the next time a user deletes a widget, she'll > > expec

Re: ScreenSaver and KDE Plasma 4.8?

2011-09-30 Thread Aaron J. Seigo
On Friday, September 30, 2011 07:48:28 todd rme wrote: > What about implementing a screensaver plasma wallpaper backend? This this would require significant changes to Plasma::Wallpaper and a lot of changes to how the painting is handled there. i don't think this is a realistic option before fr

Re: ScreenSaver and KDE Plasma 4.8?

2011-09-30 Thread todd rme
On Fri, Sep 30, 2011 at 11:11 AM, Aaron J. Seigo wrote: > On Friday, September 30, 2011 07:48:28 todd rme wrote: >> What about implementing a screensaver plasma wallpaper backend?  This > > this would require significant changes to Plasma::Wallpaper and a lot of > changes to how the painting is ha

Re: ScreenSaver and KDE Plasma 4.8?

2011-09-30 Thread Martin Gräßlin
On Fri, 30 Sep 2011 11:27:23 +0200, todd rme wrote: On Fri, Sep 30, 2011 at 11:11 AM, Aaron J. Seigo wrote: On Friday, September 30, 2011 07:48:28 todd rme wrote: What about implementing a screensaver plasma wallpaper backend?  This this would require significant changes to Plasma::Wallpape

Re: Plasma Applet empty config entrymap in init() but filled entrymap after init()

2011-09-30 Thread Oliver Friedrich
Ok, I figured out that this problem is connected with the plasmoidviewer since there are no problems on desktop. For me it's solved but some should maybe have a look because its really annoying Am 28.09.2011 14:28, schrieb Oliver Friedrich: Hello I'm writing an applet. Therefore I call in ini

Re: ScreenSaver and KDE Plasma 4.8?

2011-09-30 Thread Aaron J. Seigo
On Thursday, September 29, 2011 22:14:59 Martin Gräßlin wrote: > * add Plasma widget support to new screen > locker implementation but drop screensaver support (same problems as first > option) +1 for this. if the lock screen is QML, when we get a QML version with OpenGL shaders people can go cra

Re: Plasma Applet empty config entrymap in init() but filled entrymap after init()

2011-09-30 Thread Aaron J. Seigo
On Friday, September 30, 2011 11:43:11 Oliver Friedrich wrote: > Ok, I figured out that this problem is connected with the plasmoidviewer > since there are no problems on desktop. > For me it's solved but some should maybe have a look because its really > annoying ah, plasmoidviewer. well, yes, th

Re: Review Request: Plasmate:add a destructor and some changes to the destructor of mainwindow.ccp

2011-09-30 Thread Aaron J. Seigo
> On Sept. 26, 2011, 12:23 p.m., Aaron J. Seigo wrote: > > mainwindow.cpp, lines 134-143 > > > > > > unecessary change. > > Giorgos Tsiapaliwkas wrote: > Aaron in your previous reply you said that the "=0" code

Re: Review Request: Plasmate:add a destructor and some changes to the destructor of mainwindow.ccp

2011-09-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101916/#review6951 --- Ship it! Ship It! - Aaron J. Seigo On Sept. 23, 2011, 4:20 p

Re: Review Request: Plasmate:images can now be added to projects

2011-09-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102290/#review6952 --- editors/imageviewer/imageviewer.h

Re: Review Request: kde-runtime:fix the coding style of plasmacomponents

2011-09-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102684/#review6953 --- Ship it! Ship It! - Aaron J. Seigo On Sept. 27, 2011, 9:42 a

Re: Review Request: Plasmate now supports the "save" action

2011-09-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102692/#review6954 --- Ship it! Ship It! - Aaron J. Seigo On Sept. 27, 2011, 9:53 a

Re: Review Request: Plasmate:the .git dir is created in the right directory

2011-09-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102693/#review6955 --- Ship it! mainwindow.cpp

Re: Review Request: KMenuEdit: Fix disabling 'Only show in KDE'

2011-09-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102713/#review6956 --- This review has been submitted with commit 76589567624eadbb2c07

Re: Review Request: KMenuEdit: Fix disabling 'Only show in KDE'

2011-09-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102713/#review6957 --- This review has been submitted with commit 2ab926ecdc301cce8ebf

Re: Review Request: KMenuEdit: Fix disabling 'Only show in KDE'

2011-09-30 Thread Ralf Jung
> On Sept. 30, 2011, 12:32 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 76589567624eadbb2c07ca2578dafa24cb34681a by Aaron Seigo to branch master. Thank you very much! - Ralf --- This is an automatically g

Re: Review Request: Plasmate:now StartPage::createNewProject() creates the plasmateprojectrc and not the StartPage::loadLocalProject()

2011-09-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102732/#review6960 --- startpage.cpp

Re: focus stealing prevention and the log out dialog

2011-09-30 Thread Dario Freddi
Is this issue related to https://bugs.kde.org/show_bug.cgi?id=265405 ? 2011/9/26 Martin Gräßlin : > On Mon, 26 Sep 2011 13:43:42 +0200, "Aaron J. Seigo" wrote: >> >> hi... >> >> there are some windows that should NEVER have focus stealing applied. one >> is >> the shutdown dialog. >> >> right now

Re: Review Request: quicklaunch: Add a confirmation dialog before the delete

2011-09-30 Thread Aaron J. Seigo
> On Sept. 29, 2011, 11:55 a.m., Sebastian Kügler wrote: > > First, this is the wrong way to fix it. Why should this confirmation only > > go for a specific widget? This introduces inconsistence in the UI that > > leads to more data loss (the next time a user deletes a widget, she'll > > expec

Re: The case for a kdelibs 4.8

2011-09-30 Thread David Faure
On Thursday 29 September 2011 20:01:00 Kevin Kofler wrote: > But one of my points is that we need features too, not just bugfixes. > Continuing 4.7.x releases solves the problem of bugfixes just fine, but > entirely fails to address the issue of features. But who is (or would be) working on featur

Re: focus stealing prevention and the log out dialog

2011-09-30 Thread Aaron J. Seigo
On Friday, September 30, 2011 15:37:10 Dario Freddi wrote: > Is this issue related to https://bugs.kde.org/show_bug.cgi?id=265405 ? yes. though i'm not sure my recent commits fix this issue, it is indeed the problem i am hoping to improve on. the issue is that KWorkspace::requestShutdown(...), w

Re: The case for a kdelibs 4.8

2011-09-30 Thread Markus Slopianka
On Donnerstag 29 September 2011 18:11:12 Kevin Kofler wrote: > Wait and see the chaos that will come up when users open their Help/About > in Konqueror and it tells them that they're using "Konqueror 4.8.0 under > KDE 4.7.6". (And yes, it still says only "KDE" in 4.6.5, I haven't checked > 4.7 or

Re: focus stealing prevention and the log out dialog

2011-09-30 Thread Thomas Gahr
On Friday 30 September 2011 15:55:22 Aaron J. Seigo wrote: > On Friday, September 30, 2011 15:37:10 Dario Freddi wrote: > > Is this issue related to https://bugs.kde.org/show_bug.cgi?id=265405 ? > > yes. though i'm not sure my recent commits fix this issue, it is indeed the > problem i am hoping t

Re: focus stealing prevention and the log out dialog

2011-09-30 Thread Aaron J. Seigo
On Friday, September 30, 2011 16:37:44 Thomas Gahr wrote: > > in kde-workspace master this is no longer the case and hopefully things > > will improve. those who can replicate the problem need to test to > > confirm. > I can replicate the problem on 4.7. Just pulled current master of kde- > workspa

Re: focus stealing prevention and the log out dialog

2011-09-30 Thread Dario Freddi
Awesome, thank you very much, I was really about to crash my head on a wall for that bug :) 2011/9/30 Aaron J. Seigo : > On Friday, September 30, 2011 16:37:44 Thomas Gahr wrote: >> > in kde-workspace master this is no longer the case and hopefully things >> > will improve. those who can replicate

Re: Re: ScreenSaver and KDE Plasma 4.8?

2011-09-30 Thread Martin Gräßlin
On Friday 30 September 2011 12:38:34 Aaron J. Seigo wrote: > On Thursday, September 29, 2011 22:14:59 Martin Gräßlin wrote: > > * add Plasma widget support to new screen > > locker implementation but drop screensaver support (same problems as first > > option) > > +1 for this. > > if the lock scree

Re: ScreenSaver and KDE Plasma 4.8?

2011-09-30 Thread Markus Slopianka
Is anybody aware of empiric studies for what (if at all) people use screensavers these days? Personally I'd expect clock, news headlines, and photo slideshows to be the top answers. QML replacements should be available for the top uses once the xscreensaver code is dropped. (IMHO at least.) O

Re: Re: ScreenSaver and KDE Plasma 4.8?

2011-09-30 Thread Martin Gräßlin
On Saturday 01 October 2011 04:46:29 Markus Slopianka wrote: > Is anybody aware of empiric studies for what (if at all) people use > screensavers these > days? > Personally I'd expect clock, news headlines, and photo slideshows to be the > top answers. > QML replacements should be available for t