Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-10-30 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102997/ --- (Updated Oct. 31, 2011, 6:57 a.m.) Review request for Plasma and Sergio Lu

PlasmaComponents.Button missing feature: use system icons!

2011-10-30 Thread Mark
Hi, I'm curently using PlasmaComponents.Button but it seems to miss a quite important feature. I can't use system icons! Icon paths can be set though... I wouldn't mind implementing this if it it's oke with you all. Just one question: How can i currently get just any icon in QML from the installe

Review Request: picture frame widget - move to next picture on delete

2011-10-30 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103001/ --- Review request for Plasma. Description --- Now when you delete in sli

Re: Review Request: picture frame widget - open potd picture

2011-10-30 Thread Aaron J. Seigo
On Sunday, October 30, 2011 16:43:29 Mark wrote: > It's all on master master is not being worked on. KDE/4.7 is. and i can't merge the changes into master because it is locked down with some ACLs to prevent people committing to it. my hands are tied. my suggestion: stop using master branch of kd

Re: Review Request: picture frame widget - open potd picture

2011-10-30 Thread Mark
On Sun, Oct 30, 2011 at 2:48 PM, Aaron J. Seigo wrote: > On Sunday, October 30, 2011 14:24:39 Mark wrote: > > Seems like a few tiny bugs ;) > > no, you just need to update your kdelibs. > > -- > Aaron J. Seigo > humru othro a kohnu se > GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7

Re: QML device notifier

2011-10-30 Thread Marco Martin
On Tuesday 25 October 2011, Aaron J. Seigo wrote: > On Tuesday, October 25, 2011 16:14:39 Marco Martin wrote: > > - scrollbar: for this it will depend from qtcomponents, they are in kde- > > runtime master for now, will still really rather move them in their own > > repository (and for me, they are

Re: Review Request: picture frame widget - open potd picture

2011-10-30 Thread Aaron J. Seigo
On Sunday, October 30, 2011 14:24:39 Mark wrote: > Seems like a few tiny bugs ;) no, you just need to update your kdelibs. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks sig

Re: To much QML options in KDE!

2011-10-30 Thread Mark
On Sun, Oct 30, 2011 at 1:43 PM, Marco Martin wrote: > On Saturday 29 October 2011, Mark wrote: > > Hi plasma people, > > > > I was expecting some components to be available for KDE and indeed there > > are. Sadly there is to much with roughly similar names which makes it > > really inconvenient

Re: Review Request: picture frame widget - open potd picture

2011-10-30 Thread Mark
On Fri, Oct 28, 2011 at 5:05 PM, Commit Hook wrote: >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102817/ > > This review has been submitted with commit > c0360bc3ba5e6b049a6605309dcfc4e78d1b0675 by Aaron Seigo to branch master. > > > - Commi

Re: To much QML options in KDE!

2011-10-30 Thread Marco Martin
On Saturday 29 October 2011, Mark wrote: > Hi plasma people, > > I was expecting some components to be available for KDE and indeed there > are. Sadly there is to much with roughly similar names which makes it > really inconvenient to find out which one i should or should not use.. > > You have (

Re: Review Request: Plasmate:images can now be added to projects

2011-10-30 Thread Aaron J. Seigo
> On Oct. 25, 2011, 11:02 a.m., Aaron J. Seigo wrote: > > editors/editpage.cpp, lines 109-110 > > > > > > such a check is necessary indeed .. however, i believe KIO::CopyJob > > provides this internally already. ha

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-10-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102997/#review7757 --- Ship it! Ship It! - Aaron J. Seigo On Oct. 30, 2011, 3:31 a.

Re: Review Request: Plasmate can create a CMakeLists.txt at $my_plasmoid dir

2011-10-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102989/#review7755 --- why is a CMakeLists.txt needed? plasmapkg is enough, no? - Aaro

Re: Review Request: Plasmate:publisher dialog now also saves the project

2011-10-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102990/#review7754 --- Ship it! Ship It! - Aaron J. Seigo On Oct. 29, 2011, 4:47 p.

Re: Review Request: Plasmate:add a new label at the startpage

2011-10-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102991/#review7753 --- i just tried this with today's sources from git, and it just exp

Re: Review Request: Plasmate:images can now be added to projects

2011-10-30 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102290/ --- (Updated Oct. 30, 2011, 7:48 a.m.) Review request for Plasma and Aaron J.

Re: Review Request: Plasmate:images can now be added to projects

2011-10-30 Thread Giorgos Tsiapaliwkas
> On Oct. 25, 2011, 11:02 a.m., Aaron J. Seigo wrote: > > editors/editpage.cpp, lines 109-110 > > > > > > such a check is necessary indeed .. however, i believe KIO::CopyJob > > provides this internally already. ha