Re: Review Request: Make python scriptengine installable if python3 is your main python

2011-11-09 Thread Luca Beltrame
In data mercoledì 09 novembre 2011 23:55:12, Albert Astals Cid ha scritto: > 2.7.2 I just checked with a 2.6 install and it works. In any case, this just hides the issue. My cmake knowledge is almost non existent, but if I can find the time I'll look at the CMakeLists.txt and see whether I can ma

Review Request: Drop InvisibleCollectionFetch Fetch Strategy in Favor of KDescendantsProxyModel

2011-11-09 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103088/ --- Review request for Plasma and Christian Mollekopf. Description --- As

Review Request: Adjust TimeSpecs in the Calendar Dataengine to Reflect Local Time

2011-11-09 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103104/ --- Review request for Plasma, Sergio Luis Martins and John Layt. Description

Re: Re: Review Request: Make python scriptengine installable if python3 is your main python

2011-11-09 Thread Albert Astals Cid
A Dimecres, 9 de novembre de 2011, Luca Beltrame vàreu escriure: > In data mercoledì 09 novembre 2011 19:25:12, Aaron J. Seigo ha scritto: > > this looks like valid python 2 and 3 from what i've seen in the python > > docu online.. :) > > However it won't work in Python 3 because the plugin factor

Re: Review Request: Make python scriptengine installable if python3 is your main python

2011-11-09 Thread Luca Beltrame
In data mercoledì 09 novembre 2011 19:25:12, Aaron J. Seigo ha scritto: > this looks like valid python 2 and 3 from what i've seen in the python docu > online.. :) However it won't work in Python 3 because the plugin factory needed to use Python ScriptEngines is Python 2 only. So the proper fix i

Review Request: Add a groupingstrategy to automatically group tasks that are grouped using kwin's windowtabbing

2011-11-09 Thread Anton Kreuzkamp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103101/ --- Review request for Plasma. Description --- This patch adds a grouping

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-11-09 Thread John Layt
> On Nov. 9, 2011, 10:33 a.m., David Narváez wrote: > > If there are no more comments against or in favor of this patch, I'm > > assuming everyone is OK with it so I'll commit this patch. > > Sergio Luis Martins wrote: > Ok. > > Please add a note in the TODO that we'll need to look

Re: Review Request: Make IconTask use Plasma::Theme'd "close" button

2011-11-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103092/#review8061 --- This review has been submitted with commit e38d61795c3eb58d14c2

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-11-09 Thread Sergio Luis Martins
> On Nov. 9, 2011, 10:33 a.m., David Narváez wrote: > > If there are no more comments against or in favor of this patch, I'm > > assuming everyone is OK with it so I'll commit this patch. Ok. Please add a note in the TODO that we'll need to look at this again when using the kdepimlibs library

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-11-09 Thread Sergio Luis Martins
> On Nov. 1, 2011, 7:39 p.m., Sergio Luis Martins wrote: > > A Calendar object is supposed to mirror what's in akonadi, so we can't > > change Incidence's timezones in there. > > > > I think this should be resolved in the presentation layer, converting to > > the local timezone there ( KSystem

Re: Re: Introducing components, how to

2011-11-09 Thread Martin Gräßlin
On Wednesday 09 November 2011 20:05:00 Marco Martin wrote: > On Wednesday 09 November 2011, Marco Martin wrote: > > When writing a widget, an application etc, just use > > import org.kde.plasma.components, the proper one is decided by the > > kdeclarativerc file, if it has > > [Components-platform]

Re: Review Request: Make python scriptengine installable if python3 is your main python

2011-11-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103096/#review8058 --- This review has been submitted with commit 23b6cb0404d586104dcb

Re: Review Request: Make python scriptengine installable if python3 is your main python

2011-11-09 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103096/#review8057 --- Ship it! this looks like valid python 2 and 3 from what i've se

Re: Review Request: Make IconTask use Plasma::Theme'd "close" button

2011-11-09 Thread Craig Drummond
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103092/#review8056 --- Ship it! I'm not 100% sure if I prefer this big X to the close

Review Request: Make python scriptengine installable if python3 is your main python

2011-11-09 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103096/ --- Review request for Plasma. Description --- Updated the syntax to be l

Re: Introducing components, how to

2011-11-09 Thread Marco Martin
On Wednesday 09 November 2011, Marco Martin wrote: > When writing a widget, an application etc, just use > import org.kde.plasma.components, the proper one is decided by the > kdeclarativerc file, if it has > [Components-platform] > name=touch something Sune just noted to me.. maybe an environment

Re: Introducing components, how to

2011-11-09 Thread Aaron J. Seigo
On Wednesday, November 9, 2011 19:31:46 Marco Martin wrote: > Hi all, > > there is still some work to do, but the components are almost done in their > final structure (good for the upoming freeze, ehehe :) cool; it's worth sending this to kde-core-devel and perhap seven kde-devel as well imho .

Introducing components, how to

2011-11-09 Thread Marco Martin
Hi all, there is still some work to do, but the components are almost done in their final structure (good for the upoming freeze, ehehe :) components are imported with: import org.kde.plasma.components regardless of the platform we're in. We have at the moment 37 widgets in the touch profile,

Re: Small improvement regarding activity icons, suggestions needed

2011-11-09 Thread Aaron J. Seigo
On Wednesday, November 9, 2011 18:58:48 Hans Chen wrote: > On Wed, Nov 9, 2011 at 16:39, Aaron J. Seigo wrote: > > fine idea, except please don't use "Nepomuk Semantic Desktop" in the text. > > perhaps ... "The Desktop Search framework must be enabled ..." > > I used "Nepomuk Semantic Desktop" be

Re: Small improvement regarding activity icons, suggestions needed

2011-11-09 Thread Hans Chen
On Wed, Nov 9, 2011 at 16:39, Aaron J. Seigo wrote: > fine idea, except please don't use "Nepomuk Semantic Desktop" in the text. > perhaps ... "The Desktop Search framework must be enabled ..." > I used "Nepomuk Semantic Desktop" because that's what it says in System Settings; I don't like the t

Re: Review Request: Make IconTask use Plasma::Theme'd "close" button

2011-11-09 Thread Diego Casella
> On Nov. 9, 2011, 4:25 p.m., Aaron J. Seigo wrote: > > other than the small issue with QDir, it looks good to me ... it's Craig's > > widget though so he has to have the last say to ship it or not. Thank you a lot :) I'll wait for Craig's approval, if he agrees with the changes :) - Diego

Re: Review Request: Make IconTask use Plasma::Theme'd "close" button

2011-11-09 Thread Diego Casella
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103092/ --- (Updated Nov. 9, 2011, 4:33 p.m.) Review request for Plasma and Craig Drum

Re: Review Request: Make IconTask use Plasma::Theme'd "close" button

2011-11-09 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103092/#review8049 --- other than the small issue with QDir, it looks good to me ... it

Re: Review Request: Make IconTask use Plasma::Theme'd "close" button

2011-11-09 Thread Diego Casella
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103092/ --- (Updated Nov. 9, 2011, 3:59 p.m.) Review request for Plasma and Craig Drum

Re: Review Request: Make IconTask use Plasma::Theme'd "close" button

2011-11-09 Thread Diego Casella
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103092/ --- (Updated Nov. 9, 2011, 3:56 p.m.) Review request for Plasma and Craig Drum

Re: Small improvement regarding activity icons, suggestions needed

2011-11-09 Thread Aaron J. Seigo
On Wednesday, November 9, 2011 15:37:33 Hans Chen wrote: > change some icons. My idea is to add a tooltip when the button is disabled, > something along the lines of "Nepomuk Semantic Desktop must be enabled in > order to change this icon". fine idea, except please don't use "Nepomuk Semantic Desk

Small improvement regarding activity icons, suggestions needed

2011-11-09 Thread Hans Chen
Hi, I'm currently on a quest to fix minor things that bother me in Plasma Desktop. :) One thing I don't like is that when you configure activities, the icon button is simply disabled if Nepomuk isn't enabled. It's far from obvious to users that you need to enable "Nepomuk Semantic Desktop" in ord

Re: Review Request: Make IconTask use Plasma::Theme'd "close" button

2011-11-09 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103092/#review8046 --- applets/icontasks/tooltips/windowpreview.cpp

Re: Review Request: Make IconTask use Plasma::Theme'd "close" button

2011-11-09 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103092/ --- (Updated Nov. 9, 2011, 12:29 p.m.) Review request for Plasma and Craig Dru

Re: Review Request: Make IconTask use Plasma::Theme'd "close" button

2011-11-09 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103092/#review8045 --- applets/icontasks/tooltips/windowpreview.cpp

Re: Review Request: Plasmate:add a new label at the startpage

2011-11-09 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102991/#review8040 --- startpage.cpp

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-11-09 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102997/#review8038 --- If there are no more comments against or in favor of this patch,

Re: Review Request: Make IconTask use Plasma::Theme'd "close" button

2011-11-09 Thread Diego Casella
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103092/ --- (Updated Nov. 9, 2011, 10:22 a.m.) Review request for Plasma, Aaron J. Sei

Re: Review Request: Make IconTask use Plasma::Theme'd "close" button

2011-11-09 Thread Diego Casella
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103092/ --- (Updated Nov. 9, 2011, 10:22 a.m.) Review request for Plasma, Aaron J. Sei

Review Request: Make IconTask use Plasma::Theme'd "close" button

2011-11-09 Thread Diego Casella
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103092/ --- Review request for Plasma, Aaron J. Seigo and Craig Drummond. Description