Looking for Advisory on ActivityBar Size Policy

2011-11-15 Thread David Narvaez
Hi all, My first disclaimer is that I'm not a UI developer at all, so I'm pretty lost here. I'm trying to address bug 225078, trying to fix the situation described in comment 7. The problem is I'm not clear on what is the expected behavior, so this is what I think should happen (assuming horizonta

Review Request: Don't set Icon if iconName is Empty in ActivityBar

2011-11-15 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103153/ --- Review request for Plasma. Description --- Actually just copying code

Re: Extenders in libplasma2 (or.. not)

2011-11-15 Thread Aaron J. Seigo
On Tuesday, November 15, 2011 16:08:17 Marco Martin wrote: > now, crazy usual crazy idea moment: > funny thing, in qml it would be way easier to do them: we could have an we talked about exactly this, only SVG+Javascript, at the kdelibs meeting trysil ... yes, that one. way before 4.0. :) some t

Re: Krunner Katch-22

2011-11-15 Thread Aaron J. Seigo
On Tuesday, November 15, 2011 20:59:48 you wrote: > On Monday 17 Heshvan 5772 09:22:20 Aaron J. Seigo wrote: > > On Sunday, November 13, 2011 17:43:22 David Baron wrote: > > > How might these be accomplished? > > > > by returning QueryMatch objects of type InformationalMatch with the data > > set

Re: Krunner Katch-22

2011-11-15 Thread David Baron
On Monday 17 Heshvan 5772 09:22:20 Aaron J. Seigo wrote: > On Sunday, November 13, 2011 17:43:22 David Baron wrote: > > How might these be accomplished? > > by returning QueryMatch objects of type InformationalMatch with the data > set to whatever the subsequent match should be. As said, Informat

Re: Review Request: RSSNow QML clean up some code

2011-11-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103145/#review8212 --- Ship it! - Marco Martin On Nov. 15, 2011, 4:32 p.m., Giorgos

Review Request: RSSNow QML clean up some code

2011-11-15 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103145/ --- Review request for Plasma. Description --- Hello, i cleaned up some

Re: Extenders in libplasma2 (or.. not)

2011-11-15 Thread Ivan Čukić
+1 for removal with a small note - I don't think that extenders turned up to be a bad idea - from my pov, extenders in plasma failed because of a few design decisions (eg could have been dropped on an unlocked desktop and nowhere else) and bugs :) -- Cheerio, Ivan -- While you were hanging y

Re: Review Request: Microblog QML add a package folder and also modify the CMakeLists.txt

2011-11-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103144/#review8211 --- why a subdirectory more? this is not used anywhere else - Marco

Re: Review Request: Microblog QML add a package folder and also modify the CMakeLists.txt

2011-11-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103144/#review8210 --- why a subdirectory more? this is not used anywhere else - Marco

Review Request: Microblog QML add a package folder and also modify the CMakeLists.txt

2011-11-15 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103144/ --- Review request for Plasma. Description --- Hello, i modified the dir

Review Request: port dictionary qml to Plasma Components

2011-11-15 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103143/ --- Review request for Plasma. Description --- Hello, i ported the plasm

Re: Extenders in libplasma2 (or.. not)

2011-11-15 Thread Marco Martin
On Tuesday 15 November 2011, Aaron J. Seigo wrote: > hi :) > > after today's research and reflecting on the situation, i consider them a > failed experiment. not a terrible one, but it didn't exactly succeed. i > suppose it's the same thing as the old tear-off menus -> neat idea, few > used them,

Extenders in libplasma2 (or.. not)

2011-11-15 Thread Aaron J. Seigo
hi :) i've been working a bit yesterday and today on the de-QGraphicsView-ification of libplasma2. Applet no longer uses any of the Plasma QGraphicsProxyWidgets and i believe i have it on a path towards proper abstraction so we can have a QGraphicsWidget and a QML Item based implementation. ho

Re: Review Request: KControl/randr: Make changes to the absolute X/Y coordinates of a display call setConfigDirty

2011-11-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102631/#review8203 --- This review has been submitted with commit 558bc0d77e7076e5111f

Re: Review Request: Plasmate:now StartPage::createNewProject() creates the plasmateprojectrc and not the StartPage::loadLocalProject()

2011-11-15 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102732/#review8202 --- startpage.cpp