Re: Quicklaunch QML porting questions

2012-01-19 Thread Ingomar Wesp
Hi! On 01/19/2012 12:35 PM, Sebastian Kügler wrote: > You can create a dynamically loaded import in C++ as well, and this might > even be the cleanest solution […] I've had a glance at the work Martin did for porting kickoff to QML and it seems like this is a good template for how to register you

Re: Review Request: Account for the SVG margins in FolderView::IconView::itemSize()

2012-01-19 Thread Ignat Semenov
> On Jan. 19, 2012, 5:24 p.m., Aaron J. Seigo wrote: > > small comment below, but looks ok otherwise. I think qRound() should go away, as per diff r2, because the code for the size calc based on the icon size a few lines above does not do this. If we qRound() the sum of the margins, we could e

Re: Review Request: Account for the SVG margins in FolderView::IconView::itemSize()

2012-01-19 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103735/#review9953 --- Ship it! small comment below, but looks ok otherwise. plasma/

Re: Review Request: Account for the SVG margins in FolderView::IconView::itemSize()

2012-01-19 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103735/ --- (Updated Jan. 19, 2012, 2:38 p.m.) Review request for Plasma, Aaron J. Sei

Review Request: Account for the SVG margins in FolderView::IconView::itemSize()

2012-01-19 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103735/ --- Review request for Plasma, Aaron J. Seigo and Marco Martin. Description --

Re: Quicklaunch QML porting questions

2012-01-19 Thread Sebastian Kügler
Hi Ingomar, On Wednesday, January 18, 2012 23:32:10 Ingomar Wesp wrote: > I'm about to start porting the quicklaunch applet to QML. Since I'm just > getting started with QML and the JavaScript API, I'm still unsure as to > what's possible, so please bear with me if I'm missing something that's > c