Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-03-31 Thread makis marimpis
> On March 31, 2012, 5:04 p.m., Lamarque Vieira Souza wrote: > > service/plugins/globalshortcuts/globalshortcuts.cpp, line 66 > > > > > > please stick to the code style, use "QString & activity" here. It will not co

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-03-31 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/#review12071 --- service/plugins/globalshortcuts/activitymanager-plugin-globals

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-03-31 Thread makis marimpis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/ --- (Updated March 31, 2012, 7:48 p.m.) Review request for KDE Base Apps, KDE

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-03-31 Thread makis marimpis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/ --- (Updated March 31, 2012, 6:15 p.m.) Review request for KDE Base Apps, KDE

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-03-31 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/#review12067 --- service/plugins/globalshortcuts/globalshortcuts.h

Re: Python plasmoid works in plasmoidviewer but not in Plasma

2012-03-31 Thread Shaun Reich
because when it's in plasma-desktop, all of the sources are already created. but in plasmoidviewer, it's starting everything from scratch. i'm guessing that's the problem, so you just need to iterate over dataengine::sources() on init. -- Shaun Reich, KDE Software Developer (kde.org)

Re: Review Request: Remember current desktop when changing activity

2012-03-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104261/#review12069 --- This review has been submitted with commit 43b05d53caa0f382dcf

Re: Review Request: Remember current desktop when changing activity

2012-03-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104261/#review12068 --- This review has been submitted with commit 6397ef5f8977af0d867

Python plasmoid works in plasmoidviewer but not in Plasma

2012-03-31 Thread Alex Dancu
Hi, I'm trying to write a plasmoid which displays lmsensors information using the systemmonitor dataengine, and I have this issue. Since I don't know the available sensors name, I connect the sourceAdded() signal of the dataengine to a slot called addSource() where I actually call connectToSo

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-03-31 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/#review12066 --- You're awesome mate :) service/plugins/globalshortcuts/activi

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-03-31 Thread makis marimpis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/ --- (Updated March 31, 2012, 4:19 p.m.) Review request for KDE Base Apps, KDE