Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-04-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review12114 --- Ship it! Looking good now, thanks a lot for your patience! I'

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-04-02 Thread Viranch Mehta
> On April 2, 2012, 12:25 p.m., Sebastian Kügler wrote: > > Looking good now, thanks a lot for your patience! > > > > I'm getting this TypeError still, haven't looked into the reason behind it: > > file:///home/sebas/kdesvn/install/share/apps/plasma/plasmoids/battery/contents/ui/batterymonitor.q

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-04-02 Thread Marco Martin
On Monday 02 April 2012, Viranch Mehta wrote: > > On April 2, 2012, 12:25 p.m., Sebastian Kügler wrote: > > > Looking good now, thanks a lot for your patience! > > > > > > I'm getting this TypeError still, haven't looked into the reason behind > > > it: > > > file:///home/sebas/kdesvn/install/shar

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-04-02 Thread Viranch Mehta
On Mon, Apr 2, 2012 at 7:52 PM, Marco Martin wrote: > hmm, not too happy about both, let's make lock/logout work as well then > merge > everything? > That sounds fine. I'll soon open a review request. Viranch ___ Plasma-devel mailing list Plasma-devel

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-04-02 Thread Viranch Mehta
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/ --- (Updated April 3, 2012, 5:12 a.m.) Review request for Plasma. Changes --