Re: Review Request: Plasmate: Add Tabbox support to the startpage

2012-05-22 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105011/ --- (Updated May 23, 2012, 5:20 a.m.) Review request for kwin, Plasma and Mart

Re: Review Request: Plasmate: fix publisher's combobox and doCMake slot

2012-05-22 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104969/#review14069 --- Looks like a sensible change, otherwise. If you've fixed the is

Re: HIG standards (from KDE-Frameworks)

2012-05-22 Thread Djuro Drljaca
On Tue, May 22, 2012 at 10:51 AM, Aurélien Gâteau wrote: > Le jeudi 17 mai 2012 09:28:49 Rick Stockton a écrit : > > > While looking at the shortcut for switching tabs i notice that kde' > > > own SC apps are not even following it. > > > According to the docs: > > > Next tab: Ctrl+PageUp > > > Pr

Re: Review Request: Use Config to Provide Activity Icons

2012-05-22 Thread Ivan Čukić
> On May 22, 2012, 12:52 p.m., Aaron J. Seigo wrote: > > "nepomuk works differently" should not be a reason for this particular > > change. > > > > the question is whether to store the icons in nepomuk or not. if they are > > stored in nepomuk, then the information stays with the activities. i

Re: Review Request: Use Config to Provide Activity Icons

2012-05-22 Thread David Narváez
> On May 22, 2012, 12:52 p.m., Aaron J. Seigo wrote: > > "nepomuk works differently" should not be a reason for this particular > > change. > > > > the question is whether to store the icons in nepomuk or not. if they are > > stored in nepomuk, then the information stays with the activities. i

Re: Review Request: Use Config to Provide Activity Icons

2012-05-22 Thread Aaron J. Seigo
> On May 22, 2012, 12:52 p.m., Aaron J. Seigo wrote: > > "nepomuk works differently" should not be a reason for this particular > > change. > > > > the question is whether to store the icons in nepomuk or not. if they are > > stored in nepomuk, then the information stays with the activities. i

Re: Review Request: Use Config to Provide Activity Icons

2012-05-22 Thread David Narváez
> On May 22, 2012, 12:52 p.m., Aaron J. Seigo wrote: > > "nepomuk works differently" should not be a reason for this particular > > change. > > > > the question is whether to store the icons in nepomuk or not. if they are > > stored in nepomuk, then the information stays with the activities. i

Re: Review Request: Use Config to Provide Activity Icons

2012-05-22 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105008/#review14047 --- "nepomuk works differently" should not be a reason for this par

Re: Review Request: Plasmate: fix publisher's combobox and doCMake slot

2012-05-22 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104969/#review14046 --- publisher/publisher.cpp

Re: Review Request: qml port of showActivityManager (it's just an icon)

2012-05-22 Thread Aaron J. Seigo
> On May 20, 2012, 10:24 p.m., Mark Gaiser wrote: > > Ehm, sorry for nitpicking but why is shipping allowed? > > It (probably) can't be closed by pressing CTRL+Q and the glow hover is > > missing... > > > > There is an import to import org.kde.plasma.graphicswidgets 0.1 as > > PlasmaWidgets wh

Re: Review Request: Backport 'Fixed Lancelot build when pimlibs are not present'

2012-05-22 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104875/#review14044 --- Ship it! Ship It! - Aaron J. Seigo On May 6, 2012, 7:27 p.m

Re: Plasma Applet Testing for 4.9

2012-05-22 Thread Anne-Marie Mahfouf
On 05/22/2012 10:51 AM, Jacopo De Simoi wrote: On Monday 21 May 2012 00:37:07 Viranch Mehta wrote: On Thu, May 17, 2012 at 3:58 AM, David Edmundson wrote: - a list of all the new QML-based applets (by the time of the first beta) (afaik, nowplaying, battery, locklogout, activitymanager.. b

Re: Plasma Applet Testing for 4.9

2012-05-22 Thread Jacopo De Simoi
On Monday 21 May 2012 00:37:07 Viranch Mehta wrote: > On Thu, May 17, 2012 at 3:58 AM, David Edmundson > wrote: > > - a list of all the new QML-based applets (by the time of the first beta) > > > >(afaik, nowplaying, battery, locklogout, activitymanager.. but > > > > there are so many more

Re: HIG standards (from KDE-Frameworks)

2012-05-22 Thread Aurélien Gâteau
Le jeudi 17 mai 2012 09:28:49 Rick Stockton a écrit : > > While looking at the shortcut for switching tabs i notice that kde' > > own SC apps are not even following it. > > According to the docs: > > Next tab: Ctrl+PageUp > > Previous tab: Ctrl+PageDown > > > > Doesn't work in: > > Dolphin (uses C