Re: Review Request: Adding notify signals to SvgItem

2012-05-27 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105072/#review14220 --- Ship it! Ship It! - Aaron J. Seigo On May 27, 2012, 7:54 p.

Re: The tooltip state. Not that good. Proposal for improvement.

2012-05-27 Thread Aaron J. Seigo
On Sunday, May 27, 2012 21:15:30 Mark wrote: > You perhaps made the mental leap, for met it's still "KDE" without the SC. > It's just the way people call KDE and that sticks. the SC seems like some > expra part that people don't seem to remember. "SC" is part of the engineering jargon we use: it's

Review Request: Adding notify signals to SvgItem

2012-05-27 Thread Luis Gabriel Lima
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105072/ --- Review request for Plasma and Marco Martin. Description --- The signa

Re: The tooltip state. Not that good. Proposal for improvement.

2012-05-27 Thread Mark
On Sun, May 27, 2012 at 8:02 PM, Aaron J. Seigo wrote: > On Sunday, May 27, 2012 18:22:10 Mark wrote: > > Is this (tooltip refactoring) going to be for frameworks only or for KDE > > 4.10(?) as well? > > there's no reason we could not start using the new tooltips classes in 4.x > code AND for the

Re: Review Request: SortFilterModel: Do not reset model while changing the regexp

2012-05-27 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105042/#review14213 --- given the comment in there about crashes and holes in models, M

Re: Review Request: SortFilterModel: add mapRowToSource() and mapRowFromSource()

2012-05-27 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105044/#review14212 --- Ship it! Ship It! - Aaron J. Seigo On May 25, 2012, 3:12 p.

Re: Review Request: Plasmate: port Publisher to a ui file and add an install action

2012-05-27 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105031/#review14211 --- is the "testing done" comment about doPublish being called stil

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

2012-05-27 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/#review14210 --- i'm unsure if the user should have to enter the tmp directory o

Re: Review Request: Fix behavior of "runners" property

2012-05-27 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105024/#review14209 --- good catch; two small fixes needed and then please commit :)

Re: The tooltip state. Not that good. Proposal for improvement.

2012-05-27 Thread Aaron J. Seigo
On Sunday, May 27, 2012 18:22:10 Mark wrote: > Is this (tooltip refactoring) going to be for frameworks only or for KDE > 4.10(?) as well? there's no reason we could not start using the new tooltips classes in 4.x code AND for the library to be part of Frameworks as well. there's a number of rea

Re: The tooltip state. Not that good. Proposal for improvement.

2012-05-27 Thread Mark
On Sun, May 27, 2012 at 5:48 PM, Aaron J. Seigo wrote: > On Sunday, May 27, 2012 14:44:50 Mark wrote: > > On Sun, May 27, 2012 at 9:43 AM, Aaron J. Seigo wrote: > > > On Saturday, May 26, 2012 03:08:41 Mark wrote: > > > > For dolphin i can understand the reason to have it's own tooltip > class >

Re: The tooltip state. Not that good. Proposal for improvement.

2012-05-27 Thread Aaron J. Seigo
On Sunday, May 27, 2012 19:55:58 Ben Cooksley wrote: > For System Settings, the listing has icons as well. Is this possible > with Plasma's tooltip classes? yes, as Marco pointed out. but since we're looking at some re-work of the implementation anyways, it might make sense to give ToolTipConten

Re: The tooltip state. Not that good. Proposal for improvement.

2012-05-27 Thread Aaron J. Seigo
On Sunday, May 27, 2012 14:44:50 Mark wrote: > On Sun, May 27, 2012 at 9:43 AM, Aaron J. Seigo wrote: > > On Saturday, May 26, 2012 03:08:41 Mark wrote: > > > For dolphin i can understand the reason to have it's own tooltip class > > > because it wants to fetch the tooltip data in a separate proce

Re: The tooltip state. Not that good. Proposal for improvement.

2012-05-27 Thread Djuro Drljaca
On Sun, May 27, 2012 at 2:44 PM, Mark wrote: > On Sun, May 27, 2012 at 9:43 AM, Aaron J. Seigo wrote: > >> On Saturday, May 26, 2012 03:08:41 Mark wrote: >> > For dolphin i can understand the reason to have it's own tooltip class >> > because it wants to fetch the tooltip data in a separate proc

Re: The tooltip state. Not that good. Proposal for improvement.

2012-05-27 Thread Mark
On Sun, May 27, 2012 at 9:43 AM, Aaron J. Seigo wrote: > On Saturday, May 26, 2012 03:08:41 Mark wrote: > > For dolphin i can understand the reason to have it's own tooltip class > > because it wants to fetch the tooltip data in a separate process in order > > to prevent a crash in the tooltip fr

Re: The tooltip state. Not that good. Proposal for improvement.

2012-05-27 Thread Marco Martin
On Sunday 27 May 2012, Ben Cooksley wrote: > > however, do we really need radically different visual styles? > > > > all three application have a pixmap on the left and text on the right. > > the text on the right changes a fair amount from app to app, though: in > > systemsettings it is a categor

Re: The tooltip state. Not that good. Proposal for improvement.

2012-05-27 Thread Ben Cooksley
On Sun, May 27, 2012 at 7:43 PM, Aaron J. Seigo wrote: > On Saturday, May 26, 2012 03:08:41 Mark wrote: >> For dolphin i can understand the reason to have it's own tooltip class >> because it wants to fetch the tooltip data in a separate process in order >> to prevent a crash in the tooltip from c

Re: The tooltip state. Not that good. Proposal for improvement.

2012-05-27 Thread Aaron J. Seigo
On Saturday, May 26, 2012 03:08:41 Mark wrote: > For dolphin i can understand the reason to have it's own tooltip class > because it wants to fetch the tooltip data in a separate process in order > to prevent a crash in the tooltip from crashing dolphin. there is no reason this could not be accomo