Re: Review Request: Dolphin reports open locations to the activity manager

2012-08-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105973/#review17426 --- This review has been submitted with commit 50d9937eadf9306d03b

Re: Translations

2012-08-14 Thread Dmitry
15.08.2012 03:19, Alexander Potashev пишет: Hi Dmitry, (I'm CC'ing the KDE localization mailing list.) This happens due to missing code that would import required translation catalogs (.po files), for example: KGlobal::locale()->insertCatalog( "kcm_akonadi" ); or static const KCatalog

Re: Review Request: rtm: Add rtm.pro for use when building librtm with qmake in QTONLY mode.

2012-08-14 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105734/ --- (Updated Aug. 15, 2012, 12:07 a.m.) Review request for Plasma and Andrew S

Re: Review Request: rtm: Add rtm.pro for use when building librtm with qmake in QTONLY mode.

2012-08-14 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105734/ --- (Updated Aug. 15, 2012, 12:01 a.m.) Review request for Plasma and Andrew S

Re: Review Request: Clean up rtm headers and move private data from Auth and Request classes into private classes. Also move webview from rtm library into plasma applet.

2012-08-14 Thread Jeremy Paul Whiting
> On Aug. 2, 2012, 6:27 p.m., Andrew Stromme wrote: > > libs/rtm/auth.cpp, lines 124-126 > > > > > > The frob could be empty for two reasons: > > > >1. It wasn't requested > >2. There was some

Re: Translations

2012-08-14 Thread Alexander Potashev
Hi Dmitry, (I'm CC'ing the KDE localization mailing list.) This happens due to missing code that would import required translation catalogs (.po files), for example: KGlobal::locale()->insertCatalog( "kcm_akonadi" ); or static const KCatalogLoader loader( "libincidenceeditors" ); I may

Re: plasma components ContextMenu

2012-08-14 Thread Marco Martin
On Tuesday 14 August 2012, Gregor Tätzner wrote: > > > > the plasmoid right menu should trigger only if no of the child element > > manages the right mouse click event on its own > > excellent :) > > One last issue: What would be the best approach to align the context menu > popup to the mouse

Re: plasma components ContextMenu

2012-08-14 Thread Gregor Tätzner
On Sunday 12 August 2012 12:51:19 Marco Martin wrote: > On Saturday 11 August 2012, Gregor Tätzner wrote: > > On Friday 10 August 2012 19:20:46 Marco Martin wrote: > > > On Friday 10 August 2012, Gregor Tätzner wrote: > > > > I need a nice context menu for kickoff qml. Is someone working on > > > >

Re: System tray: size of icons

2012-08-14 Thread Dmitry
14.08.2012 21:59, Dmitry пишет: 14.08.2012 21:01, Marco Martin пишет: On Tuesday 14 August 2012, Dmitry wrote: Hello! I thought that all icons in tray have to be the same size (i.e. to be limited in size), but current C++ system tray

Re: Review Request: Fix misplaced panel (especially when more than one monitor is involved)

2012-08-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105596/#review17406 --- This review has been submitted with commit 59b1e4e4387a9194125

Re: System tray: size of icons

2012-08-14 Thread Dmitry
14.08.2012 21:01, Marco Martin пишет: On Tuesday 14 August 2012, Dmitry wrote: Hello! I thought that all icons in tray have to be the same size (i.e. to be limited in size), but current C++ system tray doesn't fix size of icons (plasmoids). For example, batter

Re: System tray: size of icons

2012-08-14 Thread Marco Martin
On Tuesday 14 August 2012, Dmitry wrote: > Hello! > > I thought that all icons in tray have to be the same size (i.e. to be > limited in size), but current C++ system tray doesn't fix size of icons > (plasmoids). For example, battery may be larger that other icons. It > looks very strange: > SysTr

System tray: size of icons

2012-08-14 Thread Dmitry
Hello! I thought that all icons in tray have to be the same size (i.e. to be limited in size), but current C++ system tray doesn't fix size of icons (plasmoids). For example, battery may be larger that other icons. It looks very strange: I assumed that all i

Re: Review Request: Do not trigger krunner when the Space key is pressed in desktop

2012-08-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105989/#review17381 --- This review has been submitted with commit 9116d752266d48c11a9

Re: Review Request: Dolphin reports open locations to the activity manager

2012-08-14 Thread Ivan Čukić
> On Aug. 14, 2012, 10:39 a.m., Frank Reininghaus wrote: > > OK, thanks for the explanation! If there is a way to opt-out, this can go > > into master from my point of view. > > > > I've noticed a possible problem though: the CMake message about kactivities > > in your patch says "STRONGLY_REC

Re: Review Request: Do not trigger krunner when the Space key is pressed in desktop

2012-08-14 Thread Jekyll Wu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105989/ --- (Updated Aug. 14, 2012, 12:54 p.m.) Review request for Plasma. Changes -

Re: Review Request: Do not trigger krunner when the Space key is pressed in desktop

2012-08-14 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105989/#review17372 --- Ship it! plasma/desktop/containments/desktop/desktop.cpp

Re: Review Request: Do not trigger krunner when the Space key is pressed in desktop

2012-08-14 Thread Jekyll Wu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105989/ --- (Updated Aug. 14, 2012, 11:06 a.m.) Review request for Plasma. Changes -

Re: Review Request: Do not trigger krunner when the Space key is pressed in desktop

2012-08-14 Thread Jekyll Wu
> On Aug. 14, 2012, 10:58 a.m., Sebastian Kügler wrote: > > Did you forget to add the patch to the preview? My stupid mistake :( - Jekyll --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/1

Re: Review Request: Fix misplaced panel (especially when more than one monitor is involved)

2012-08-14 Thread Sebastian Kügler
On Friday, July 27, 2012 17:31:08 Rolf Eike Beer wrote: > Am Donnerstag 26 Juli 2012, 10:14:42 schrieb Marco Martin: > > --- > > This is an automatically generated e-mail. To reply, visit: > > http://git.reviewboard.kde.org/r/105596/#review164

Re: Review Request: Reduce the memory usage of the fileWatcher plasmoid

2012-08-14 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105940/#review17369 --- Ship it! Makes sense. Thanks! - Sebastian Kügler On Aug. 9,

Re: Review Request: Do not trigger krunner when the Space key is pressed in desktop

2012-08-14 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105989/#review17368 --- Did you forget to add the patch to the preview? - Sebastian Kü

Re: Review Request: Dolphin reports open locations to the activity manager

2012-08-14 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105973/#review17365 --- OK, thanks for the explanation! If there is a way to opt-out, t