Re: Review Request: Add comment to blackboard applet

2012-08-23 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105704/ --- (Updated Aug. 23, 2012, 11:13 a.m.) Review request for Plasma. Changes -

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

2012-08-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/#review17927 --- konsole/konsolepreviewer.cpp

Re: Activities KCM

2012-08-23 Thread Christoph Feck
On Thursday 23 August 2012 15:45:02 Ivan Čukić wrote: > I don't know what to think of this. Hiding is prettier (to me) > while disabling has its own advantages. Anyone else cares to pitch > in? > > As far as I see, we have both approaches in kcm. I just checked System Settings, and all modules ex

Re: Review Request: Usability: Add keyboard navigation to Kickoff GUI (within and among all Views)

2012-08-23 Thread Richard Stockton
> On Aug. 23, 2012, 2:53 p.m., Greg T wrote: > > I think this time we can get kickoff-qml into kde 4.10. But this is no > > reason to push this fix not into master :) Thanks, Greg! I think we both plan this method for managing the two modules, please advise if I am no correct: First, right now

Re: Review Request: Usability: Add keyboard navigation to Kickoff GUI (within and among all Views)

2012-08-23 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106125/#review17903 --- I think this time we can get kickoff-qml into kde 4.10. But thi

Re: Activities KCM

2012-08-23 Thread todd rme
On Thu, Aug 23, 2012 at 3:45 PM, Ivan Čukić wrote: > >> > This should be done automatically - the activities should be scored based >> > on the current location and stuff like in Plasma Active, and the switcher >> > should sort them by the score, or mark them in some way. >> >> I don't really agre

Re: Activities KCM

2012-08-23 Thread Ivan Čukić
> > This should be done automatically - the activities should be scored based > > on the current location and stuff like in Plasma Active, and the switcher > > should sort them by the score, or mark them in some way. > > I don't really agree here. There are some activities you probably > never w

Re: Activities KCM

2012-08-23 Thread todd rme
On Thu, Aug 23, 2012 at 11:47 AM, Ivan Čukić wrote: > Thanks for the suggestions. > > First, lets start with the feature requests. > >> 1. Which applications start automatically with a given activity. > > As Marco said (and I agree), this shouldn't be for per-activity settings. > But I do think we

Re: Review Request: Activities KCM

2012-08-23 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106130/ --- (Updated Aug. 23, 2012, 1:08 p.m.) Review request for Plasma. Descriptio

Re: Review Request: Add comment to blackboard applet

2012-08-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105704/#review17897 --- committed - Marco Martin On Aug. 23, 2012, 11:13 a.m., Maart

Re: Review Request: Add comment to blackboard applet

2012-08-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105704/#review17896 --- This review has been submitted with commit 2c0b9004a516b23012d

Re: Review Request: Add fade effect on the nowplaying text cycling

2012-08-23 Thread Martin Klapetek
> On Aug. 21, 2012, 3:54 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 48ccff55dabc7ad9a173ee6b50d955c85e42aa27 by Martin Klapetek to branch > > KDE/4.9. > > Alex Merry wrote: > I don't think this should really have gone into 4.9, as it is a feature, > rather

Re: Review Request: Make autohide panel do not intercept events in fullscreen app

2012-08-23 Thread Alexey Shmalko
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106110/ --- (Updated Aug. 22, 2012, 6:44 p.m.) Review request for kwin and Plasma. D

Re: Review Request: Make autohide panel do not intercept events in fullscreen app

2012-08-23 Thread Alexey Shmalko
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106110/ --- (Updated Aug. 22, 2012, 11:50 a.m.) Review request for kwin and Plasma.

Re: Review Request: Make autohide panel do not intercept events in fullscreen app

2012-08-23 Thread Alexey Shmalko
> On Aug. 21, 2012, 4:22 a.m., Martin Gräßlin wrote: > > I do not see a reason why the hidden panel should not be allowed to go > > above a fullscreen window. True it's not possible for the normal panel > > case, but hidden panel is kind of special. > > > > Apart from that I think you modified

Re: Review Request: Add fade effect on the nowplaying text cycling

2012-08-23 Thread Alex Merry
> On Aug. 21, 2012, 3:54 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 48ccff55dabc7ad9a173ee6b50d955c85e42aa27 by Martin Klapetek to branch > > KDE/4.9. I don't think this should really have gone into 4.9, as it is a feature, rather than a bug fix. - Alex --

Re: Activities KCM

2012-08-23 Thread Ivan Čukić
Thanks for the suggestions. First, lets start with the feature requests. > 1. Which applications start automatically with a given activity. As Marco said (and I agree), this shouldn't be for per-activity settings. But I do think we should have this feature. > 2. Which activities are started aut

Re: Activities KCM

2012-08-23 Thread todd rme
On Wed, Aug 22, 2012 at 8:21 PM, Ivan Čukić wrote: > What would you like to see configurable in activities? 1. Which applications start automatically with a given activity. 2. Which activities are started automatically on boot 3. Which activity is shown when the system starts 4. Location, network