Re: Fit Grid elements in Item

2012-09-24 Thread Nuno Pinheiro
A Segunda, 24 de Setembro de 2012 00:05:45 Luiz Romário Santana Rios escreveu: > Hello. > > I'm trying to port the Calculator plasmoid to QML, but I'm stuck > trying to make the buttons fit their parent item. I'm doing this: > > Item { > anchors { > top: resultArea.bottom > bo

Re: Fit Grid elements in Item

2012-09-24 Thread David Edmundson
On Mon, Sep 24, 2012 at 4:05 AM, Luiz Romário Santana Rios wrote: > Hello. > > I'm trying to port the Calculator plasmoid to QML, but I'm stuck > trying to make the buttons fit their parent item. I'm doing this: > > Item { > anchors { > top: resultArea.bottom > bottom: parent.b

Re: Review Request: improve wheel scrolling behaviour inside thumbnail view in virus and pattern wallpaper plugins

2012-09-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106541/#review19381 --- This review has been submitted with commit ae769dc1184a3dfe133

Re: Fit Grid elements in Item

2012-09-24 Thread Sebastian Kügler
On Monday, September 24, 2012 11:45:22 David Edmundson wrote: > Although you've told the grid to anchor on the right hand side, you've > also (implicitly) told it it needs to be 4 buttons wide, and each > button is hardcoded to be at least 12 characters wide. > (plasmacomponents/qml/Button.qml:95).

Re: Review Request: improve wheel scrolling behaviour inside thumbnail view in virus and pattern wallpaper plugins

2012-09-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106541/#review19382 --- This review has been submitted with commit 03fe9c2110baa552749

Re: Fit Grid elements in Item

2012-09-24 Thread David Edmundson
On Mon, Sep 24, 2012 at 1:16 PM, Sebastian Kügler wrote: > On Monday, September 24, 2012 11:45:22 David Edmundson wrote: >> Although you've told the grid to anchor on the right hand side, you've >> also (implicitly) told it it needs to be 4 buttons wide, and each >> button is hardcoded to be at le

Re: Review Request: Make it possible to use QtCreator QML profiler and debugger with KDE Applications

2012-09-24 Thread Aurélien Gâteau
> On Sept. 23, 2012, 8:56 a.m., David Faure wrote: > > kdecore/kernel/kcmdlineargs.cpp, line 1413 > > > > > > Pff, this is completely inconsistent in Qt, and Qt should really be > > fixed to accept ' ' as a separa

Re: Review Request: Make it possible to use QtCreator QML profiler and debugger with KDE Applications

2012-09-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106527/#review19385 --- This review has been submitted with commit ae28f8d00a35c0b0513

Re: commit problem

2012-09-24 Thread Aaron J. Seigo
On Monday, September 24, 2012 10:06:44 Reza Shah wrote: > And later how to merge this to master? Does 'git cherry-pick sha' when > i'm at master enough? you need to `git push` again after the cherry pick. a cherry pick, like any git change set, is made locally only and you have to tell git to cop

Re: Fit Grid elements in Item

2012-09-24 Thread Aaron J. Seigo
On Monday, September 24, 2012 11:45:22 David Edmundson wrote: > the plasmoid > should fit the size of the content, not shrinking the content to fit. in this case, yes, as it is a popup applet which has an inherent minimum useful size. however, this is only acceptable when there is no other option

api review for DataEngineConsumer

2012-09-24 Thread Aaron J. Seigo
hi... i just pushed DataEngineConsumer as public API in libplasma2. this class is used extensively in libplasma1 (and wherever it was copy and pasted ;) to make it easy to tie usage of DataEngineManager to the lifespan of a given object (such as Applet, Runner, etc.) turns out that this is how

Re: Review Request: Fix wrong selection background rendering (visible e.g. with Plastique)

2012-09-24 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106544/#review19389 --- Ship it! Ship It! - Aaron J. Seigo On Sept. 23, 2012, 5:45

Re: Review Request: fix crash in runner due to bookmarks

2012-09-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106504/#review19390 --- This review has been submitted with commit 92f977e05785b201d0f

Review Request: expand the theme package in order to include *.svgz files

2012-09-24 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106557/ --- Review request for kdelibs and Plasma. Description --- The theme pack

Re: Review Request: The preview action shouldn't be visible all the time

2012-09-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106477/#review19391 --- This review has been submitted with commit 19792002e9e8055c052

Re: Review Request: make plasmate able to load a project in the second time

2012-09-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106479/#review19392 --- This review has been submitted with commit 331d5b7eb99d5779131

Re: my features plan for 4.10

2012-09-24 Thread Shaun Reich
Have you talked to mat69 (irc nick, forget his real name) iirc I asked him one time and there were some areas that were kinda tricky to do the comic plasmoid in qml1. Either way, you should prolly talk to him since he's the maintainer. ___ Plasma-devel ma

Re: declarative tabbutton style

2012-09-24 Thread Shaun Reich
The valid use case would probably be when you have a lot of comics/sources displayed, that the tab bar just gets too big. Though it'd be nice if this were a bit automatic, just resorting to icons or something. ___ Plasma-devel mailing list Plasma-devel@kd

Re: IRC meeting summary

2012-09-24 Thread Shaun Reich
Could you please elaborate on what you mean by security issues? On Sep 13, 2012 1:08 PM, "Fredrik Höglund" wrote: > On Wednesday 12 September 2012, Ivan Čukić wrote: > > > even tough is materal way post 4.10, if there is something really > needed for > > > plasma that is still not present in the

Re: Comic plasmoid progress

2012-09-24 Thread Shaun Reich
Oh my gosh yes, I've always hated that feature. When the desktop is locked things shouldn't move around like that... I'd love to see that disappear. On Sep 16, 2012 7:55 AM, "Marco Martin" wrote: > On Sunday 16 September 2012, Reza Shah wrote: > > Hi, > > > > I have pushed some changes for comic

Re: Re: IRC meeting summary

2012-09-24 Thread Martin Gräßlin
On Monday 24 September 2012 12:45:22 Shaun Reich wrote: > Could you please elaborate on what you mean by security issues? X11 is extremely insecure, e.g. * each window can eavesdrop the input to other windows * each window can get the pixmap of other windows * each window can get the position and s

plasma: QGraphicsView-ectomy

2012-09-24 Thread Marco Martin
Hi all, I've committed in the kdelibs branch plasma/mart/qgvremoval a pretty big diff. it makes Applet inherit only from QObject this causes a nice doino effect: all api that was coming from QGraphics* isn't there anymore, so i had to cut pretty badly, and that's good, because i think the applet cl

Re: Fit Grid elements in Item

2012-09-24 Thread Sebastian Kügler
On Monday, September 24, 2012 14:14:39 David Edmundson wrote: > To clarify, by change I meant to consider adding a > minimumWidth/minimumHeight property, not removing the current > implicitWidth > > It's impossible for a user of the component to do this accurately > because it needs both the label

Re: Review Request: expand the theme package in order to include *.svgz files

2012-09-24 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106557/#review19393 --- Ship it! Ship It! - Aaron J. Seigo On Sept. 24, 2012, 3:38

Re: api review for DataEngineConsumer

2012-09-24 Thread Marco Martin
On Mon, Sep 24, 2012 at 4:26 PM, Aaron J. Seigo wrote: > turns out that this is how DataEngineManager was nearly *always* used, and > when it wasn't (e.g. in individual Applets) it often caused problems. problems > which DataEngineConsumer avoids. > > so ... in these changes to libplasma2, DataEng

Re: commit problem

2012-09-24 Thread Reza Shah
Hi Aaron, Thanks, yesterday talked with Marco at #plasma and managed to solve this. Regards, Reza On Mon, Sep 24, 2012 at 11:18 PM, Aaron J. Seigo wrote: > On Monday, September 24, 2012 10:06:44 Reza Shah wrote: >> And later how to merge this to master? Does 'git cherry-pick sha' when >> i'm at

Re: my features plan for 4.10

2012-09-24 Thread Reza Shah
Hi Shaun, I have not talked with mat69, will try to reach him. Thanks for the info. Regards, Reza On Tue, Sep 25, 2012 at 1:17 AM, Shaun Reich wrote: > Have you talked to mat69 (irc nick, forget his real name) iirc I asked him > one time and there were some areas that were kinda tricky to do th

Re: Review Request: reuse knewstuff's itemsview class to provide smooth scrolling in wallpaper configuration screen

2012-09-24 Thread Sebastian Kügler
On Sunday, September 23, 2012 11:02:02 Commit Hook wrote: > Can this also pushed to 4.9 branch? Don't forget to push to master as well. (Or maybe I missed that one?) -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-d

Re: commit problem

2012-09-24 Thread Sebastian Kügler
On Tuesday, September 25, 2012 06:26:15 Reza Shah wrote: > Thanks, yesterday talked with Marco at #plasma and managed to solve this. A short note that it's solved would have been nice in this case, it saves others some time. Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key I

Re: Review Request: expand the theme package in order to include *.svgz files

2012-09-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106557/#review19398 --- This review has been submitted with commit 3777eeb0cb00941f7f8

Re: Fit Grid elements in Item

2012-09-24 Thread Luiz Romário Santana Rios
2012/9/24 Sebastian Kügler : > On Monday, September 24, 2012 11:45:22 David Edmundson wrote: >> Although you've told the grid to anchor on the right hand side, you've >> also (implicitly) told it it needs to be 4 buttons wide, and each >> button is hardcoded to be at least 12 characters wide. >> (p

Re: Plasma Wallpapers in QML

2012-09-24 Thread Aleix Pol
On Mon, Sep 17, 2012 at 6:54 PM, Aleix Pol wrote: > On Mon, Sep 17, 2012 at 4:55 PM, Aleix Pol wrote: >> On Fri, Sep 14, 2012 at 6:19 PM, Marco Martin wrote: >>> On Thursday 13 September 2012, Aleix Pol wrote: Hi, So I was tired of KPeople for today and I've decided to play a bit

Re: Fit Grid elements in Item

2012-09-24 Thread Mark
On Tue, Sep 25, 2012 at 3:06 AM, Luiz Romário Santana Rios wrote: > 2012/9/24 Sebastian Kügler : >> On Monday, September 24, 2012 11:45:22 David Edmundson wrote: >>> Although you've told the grid to anchor on the right hand side, you've >>> also (implicitly) told it it needs to be 4 buttons wide,

Re: Fit Grid elements in Item

2012-09-24 Thread Luiz Romário Santana Rios
2012/9/24 Luiz Romário Santana Rios : > 2012/9/24 Sebastian Kügler : >> On Monday, September 24, 2012 11:45:22 David Edmundson wrote: >>> Although you've told the grid to anchor on the right hand side, you've >>> also (implicitly) told it it needs to be 4 buttons wide, and each >>> button is hardco