kephal or qdesktopwidget

2012-10-08 Thread Reza Shah
Hi, I managed to test my patch for color and pattern wallpaper in multi monitor setup with different resolution. The pattern wallpaper has proper result compared the color wallpaper. I think, i miss understood the kephal::primaryScreen function in color wallpaper so the result was not correct(both

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-08 Thread Aleix Pol Gonzalez
> On Oct. 8, 2012, 5:31 p.m., Martin Gräßlin wrote: > > just an idea: what about hiding the whole X screen saver stuff behind > > another configure dialog. Looking at the screenshot I find the design puts > > emphasis on the wrong part: what we want to remove takes more than 50 % of > > the av

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-08 Thread Aurélien Gâteau
> On Oct. 8, 2012, 5:31 p.m., Martin Gräßlin wrote: > > just an idea: what about hiding the whole X screen saver stuff behind > > another configure dialog. Looking at the screenshot I find the design puts > > emphasis on the wrong part: what we want to remove takes more than 50 % of > > the av

Re: Re: reminder: fixes into 4.9

2012-10-08 Thread Martin Gräßlin
On Monday 08 October 2012 21:21:42 Antonis Tsiapaliokas wrote: > > [*] even better is it to create a new branch for each of your bug > > fixes/features. > > good idea. But (if we do something like that) i think that all those > bug fixes should have a > standard prefix. Otherwise someone might get

Re: reminder: fixes into 4.9

2012-10-08 Thread Antonis Tsiapaliokas
> [*] even better is it to create a new branch for each of your bug > fixes/features. good idea. But (if we do something like that) i think that all those bug fixes should have a standard prefix. Otherwise someone might get lost with the git branch -a As regards the bugfixes, is it possible to ad

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-08 Thread Aleix Pol Gonzalez
> On Oct. 8, 2012, 5:31 p.m., Martin Gräßlin wrote: > > just an idea: what about hiding the whole X screen saver stuff behind > > another configure dialog. Looking at the screenshot I find the design puts > > emphasis on the wrong part: what we want to remove takes more than 50 % of > > the av

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-08 Thread Marco Martin
> On Oct. 8, 2012, 5:31 p.m., Martin Gräßlin wrote: > > just an idea: what about hiding the whole X screen saver stuff behind > > another configure dialog. Looking at the screenshot I find the design puts > > emphasis on the wrong part: what we want to remove takes more than 50 % of > > the av

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-08 Thread Martin Gräßlin
> On Oct. 8, 2012, 3:50 p.m., Jeremy Paul Whiting wrote: > > That looks a bit better in my opinion. I would change/fix the wording for > > the dashboard screen locker a bit "Click configure to find more about it!" > > doesn't sound quite right for a tooltip, maybe something like "Click the >

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-08 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106768/#review20087 --- just an idea: what about hiding the whole X screen saver stuff

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-08 Thread Kai Uwe Broulik
> On Oct. 8, 2012, 3:50 p.m., Jeremy Paul Whiting wrote: > > That looks a bit better in my opinion. I would change/fix the wording for > > the dashboard screen locker a bit "Click configure to find more about it!" > > doesn't sound quite right for a tooltip, maybe something like "Click the >

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-08 Thread Marco Martin
> On Oct. 8, 2012, 3:50 p.m., Jeremy Paul Whiting wrote: > > That looks a bit better in my opinion. I would change/fix the wording for > > the dashboard screen locker a bit "Click configure to find more about it!" > > doesn't sound quite right for a tooltip, maybe something like "Click the >

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-08 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106768/#review20082 --- That looks a bit better in my opinion. I would change/fix the

Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106768/ --- Review request for Plasma and KDE Usability. Description --- After co

Re: reminder: fixes into 4.9

2012-10-08 Thread Martin Gräßlin
On Monday 08 October 2012 16:51:10 Aaron J. Seigo wrote: > hi :) > > i just finished backporting a number of commits from KDE/4.9 into master in > kde-runtime/plasma/ > > when pushing fixes into master, as long as they are not large changes that > may possibly lead to problems, please be sure the

Re: un-NIH-ing accounts?

2012-10-08 Thread Kevin Krammer
On Monday, 2012-10-08, Mark wrote: > On Mon, Oct 8, 2012 at 3:09 AM, David Edmundson > > It's already fragmented it seems. > > http://debarshiray.wordpress.com/2012/10/06/goa-why-it-is-the-way-it-is/ > > I can't say that it surprises me.. Though i would have hoped > otherwise. On the other hand i

reminder: fixes into 4.9

2012-10-08 Thread Aaron J. Seigo
hi :) i just finished backporting a number of commits from KDE/4.9 into master in kde-runtime/plasma/ when pushing fixes into master, as long as they are not large changes that may possibly lead to problems, please be sure they also land in the current *stable* branch as well. or even better y

Re: Review Request: Make it possible to have a QAbstractItemModel as a property

2012-10-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106267/#review20076 --- This review has been submitted with commit a9d88406e9b5e851a03

Re: Review Request: make pattern wallpaper thumbnail aspect ratio similar to primary screen aspect ratio

2012-10-08 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106766/#review20074 --- Ship it! Ship It! - Aaron J. Seigo On Oct. 8, 2012, 1:06 p.

Re: Review Request: remove the child from the factory

2012-10-08 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106767/#review20073 --- Ship it! Ship It! - Aaron J. Seigo On Oct. 8, 2012, 1:17 p.

Re: Review Request: Add some documentation to the Fallback component

2012-10-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106716/#review20071 --- Ship it! Ship It! - Marco Martin On Oct. 8, 2012, 1:27 p.m.

Re: Review Request: Add some documentation to the Fallback component

2012-10-08 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106716/ --- (Updated Oct. 8, 2012, 1:27 p.m.) Review request for Plasma. Changes ---

Review Request: remove the child from the factory

2012-10-08 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106767/ --- Review request for Plasma. Description --- open plasmate-> load a pro

Re: Review Request: make pattern wallpaper thumbnail aspect ratio similar to primary screen aspect ratio

2012-10-08 Thread Reza Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106766/ --- (Updated Oct. 8, 2012, 1:06 p.m.) Review request for Plasma and Marco Mart

Review Request: make pattern wallpaper thumbnail aspect ratio similar to primary screen aspect ratio

2012-10-08 Thread Reza Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106766/ --- Review request for Plasma and Marco Martin. Description --- I tried t

Re: Review Request: make color wallpaper thumbnail aspect ratio similar to primary screen aspect ratio

2012-10-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106754/#review20067 --- This review has been submitted with commit 4352f477117c884d268

Re: Review Request: make color wallpaper thumbnail aspect ratio similar to primary screen aspect ratio

2012-10-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106754/#review20059 --- Ship it! Ship It! - Marco Martin On Oct. 8, 2012, 9:54 a.m.

Re: Review Request: Device notifier: show mounted device and path

2012-10-08 Thread Aaron J. Seigo
> On Oct. 8, 2012, 9:52 a.m., Aaron J. Seigo wrote: > > any application which expects the user to access files on disk but does not > > provide a clear representation of mounted / removable devices is broken. > > there's no point in degrading our own primary UI for such fixable > > brokenness.

Re: Review Request: make color wallpaper thumbnail aspect ratio similar to primary screen aspect ratio

2012-10-08 Thread Reza Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106754/ --- (Updated Oct. 8, 2012, 9:54 a.m.) Review request for Plasma and Marco Mart

Re: Review Request: Device notifier: show mounted device and path

2012-10-08 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106755/#review20057 --- any application which expects the user to access files on disk

Re: Review Request: Device notifier: show mounted device and path

2012-10-08 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106755/ --- (Updated Oct. 8, 2012, 9:31 a.m.) Review request for KDE Base Apps and Pla

Re: un-NIH-ing accounts?

2012-10-08 Thread Marco Martin
On Monday 08 October 2012, Aaron J. Seigo wrote: > > :) > > :http://debarshiray.wordpress.com/2012/10/06/goa-why-it-is-the-way-it-is > > :/ > > > > read "The Split" section. It sums up a few reasons. > > i'm more interested in the reasons raised at the Active sprint. > I don't know much about i

Re: un-NIH-ing accounts?

2012-10-08 Thread Aaron J. Seigo
On Monday, October 8, 2012 09:34:41 Mark wrote: > On Mon, Oct 8, 2012 at 9:31 AM, Aaron J. Seigo wrote: > > On Monday, October 8, 2012 02:50:57 Alex Fiestas wrote: > >> This project came out at the last Active sprint, at least 2 people there > >> mentioned that the MeeGo system wasn't something we

Re: un-NIH-ing accounts?

2012-10-08 Thread Mark
On Mon, Oct 8, 2012 at 9:31 AM, Aaron J. Seigo wrote: > On Monday, October 8, 2012 02:50:57 Alex Fiestas wrote: >> This project came out at the last Active sprint, at least 2 people there >> mentioned that the MeeGo system wasn't something we wanted to keep. > > Could someone share what the reason

Re: un-NIH-ing accounts?

2012-10-08 Thread Aaron J. Seigo
On Monday, October 8, 2012 02:50:57 Alex Fiestas wrote: > This project came out at the last Active sprint, at least 2 people there > mentioned that the MeeGo system wasn't something we wanted to keep. Could someone share what the reasoning was? -- Aaron J. Seigo signature.asc Description: This

Re: Review Request: make color wallpaper thumbnail aspect ratio similar to primary screen aspect ratio

2012-10-08 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106754/#review20051 --- Ship it! looks functional. plasma/generic/wallpapers/color/b

Re: un-NIH-ing accounts?

2012-10-08 Thread Aaron J. Seigo
On Monday, October 8, 2012 02:09:23 David Edmundson wrote: > It's already fragmented it seems. > http://debarshiray.wordpress.com/2012/10/06/goa-why-it-is-the-way-it-is/ that's just GNOME doing their own thing, as they usually do, and that blog entry is sharing their justification for doing so in

Re: Re: un-NIH-ing accounts?

2012-10-08 Thread Mark
On Mon, Oct 8, 2012 at 3:09 AM, David Edmundson wrote: > On Mon, Oct 8, 2012 at 1:50 AM, Alex Fiestas wrote: >> On Monday 08 October 2012 01:46:40 Aaron J. Seigo wrote: >>> On Sunday, October 7, 2012 23:10:47 Mark wrote: >>> > This page has a bit more info then the google code link (and the >>> >