Re: Review Request: remove the child from the factory

2012-10-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106767/#review20182 --- This review has been submitted with commit 62180cc478c2fae1d96

Re: Review Request: Add some documentation to the Fallback component

2012-10-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106716/#review20183 --- This review has been submitted with commit 0272ba16af7a68e4843

Re: Review Request: Fix KRunner's 'spell in foreign language' feature

2012-10-11 Thread Simeon Bird
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106244/#review20176 --- Does anyone have any objections? Given that the current behavio

Re: Review Request: Make it possible to use QtCreator QML profiler and debugger with KDE Applications

2012-10-11 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106527/#review20186 --- Finally took the time to file a Qt5 review: https://codereview

Re: Review Request: Device notifier: show mounted device and path

2012-10-11 Thread Jacopo De Simoi
> On Oct. 8, 2012, 9:52 a.m., Aaron J. Seigo wrote: > > any application which expects the user to access files on disk but does not > > provide a clear representation of mounted / removable devices is broken. > > there's no point in degrading our own primary UI for such fixable > > brokenness.

Review Request: Fix padding to the left and right of text in a textField

2012-10-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106797/ --- Review request for Plasma. Description --- Fix padding to the left an

Re: Review Request: Fix padding to the left and right of text in a textField

2012-10-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106797/#review20203 --- Ship it! i like the change. it keeps the same resulting pixel

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-11 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/ --- (Updated Oct. 11, 2012, 6:08 p.m.) Review request for Plasma and Martin Gr

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/#review20206 --- ksplash/ksplashqml/SplashWindow.cpp

Re: Review Request: Translate strings in Global Keyboard Shortcuts component KDE Keyboard Layout Switcher

2012-10-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106424/#review20209 --- This review has been submitted with commit b60ea1d3b6fa7e3dc04

Re: Review Request: Translate strings in Global Keyboard Shortcuts component KDE Keyboard Layout Switcher

2012-10-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106424/#review20210 --- This review has been submitted with commit 3d528d4e00654c8c50b

Re: Review Request: Fix padding to the left and right of text in a textField

2012-10-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106797/#review20213 --- This review has been submitted with commit ecf80ca70ad14381030

Re: Review Request: Fix padding to the left and right of text in a textField

2012-10-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106797/#review20215 --- This review has been submitted with commit 9e5a50dcd69bf4844af