Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107160/#review21280 --- Manager does not need to know about Applet (see comment below a

Re: Review Request: Add Package bindings from MobileComponents to PlasmaCore

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107166/#review21281 --- the reason this is still in MobileComponent is because it isn't

Re: Review Request: AppletContainer has moved to scriptengine

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107165/#review21282 --- Ship it! looks good from here... - Aaron J. Seigo On Oct. 3

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

> On Nov. 1, 2012, 9:47 a.m., Aaron J. Seigo wrote: > > plasma/generic/applets/systemtray/core/manager.h, line 54 > > > > > > the manager is shared across all instances of the system tray plasmoid. > > (look for s_m

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

> On Nov. 1, 2012, 9:47 a.m., Aaron J. Seigo wrote: > > plasma/generic/applets/systemtray/core/manager.h, line 54 > > > > > > the manager is shared across all instances of the system tray plasmoid. > > (look for s_m

Re: Review Request: AppletContainer has moved to scriptengine

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107165/#review21292 --- Ship it! +1 from here too - Marco Martin On Oct. 31, 2012,

Re: Review Request: Add Package bindings from MobileComponents to PlasmaCore

> On Nov. 1, 2012, 9:58 a.m., Aaron J. Seigo wrote: > > the reason this is still in MobileComponent is because it isn't quite > > "general purpose use" ready. the biggest issue is that it always assumes a > > Plasma/Generic type and can not load from anywhere other than the normal > > system i

Re: Review Request: Declarative bindings for ToolBox

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107150/#review21294 --- I'm quite on the fence with this. I'm not sure it should be the

Re: Review Request: Add Package bindings from MobileComponents to PlasmaCore

> On Nov. 1, 2012, 9:58 a.m., Aaron J. Seigo wrote: > > the reason this is still in MobileComponent is because it isn't quite > > "general purpose use" ready. the biggest issue is that it always assumes a > > Plasma/Generic type and can not load from anywhere other than the normal > > system i

Re: Review Request: Declarative bindings for ToolBox

Hi Marco, Thanks for the review! On Thursday, November 01, 2012 12:29:25 Marco Martin wrote: > I'm quite on the fence with this. > I'm not sure it should be the qml containment to explicitly create the > toolbox, but more: > > the c++ part of the containment scriptengine loads and parses the qml

Re: Review Request: Add Package bindings from MobileComponents to PlasmaCore

On Thursday, November 01, 2012 12:59:56 Aaron J. Seigo wrote: > even right now, even with generic packages, all sorts of files can be > fetched: org.kde.active.launcher, org.kde.activityswitcher, > org.kde.active.widgetsexplorer, etc. > > the security / cleanliness aspect of this is not opened up

Re: Review Request: AppletContainer has moved to scriptengine

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107165/#review21300 --- This review has been submitted with commit 1657f5ae8b4124ee2b8

Re: Review Request: load the images for the themes correctly

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106680/ --- (Updated Nov. 1, 2012, 3:08 p.m.) Review request for Plasma. Changes ---

Re: Review Request: Fix battery applet screen power management

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106784/#review21307 --- This review has been submitted with commit e1bf8805b3d0c8ddf22

Re: Review Request: load the images for the themes correctly

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106680/#review21311 --- you mean they can't have different descriptions? yes, that's tr

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

> On Nov. 1, 2012, 9:47 a.m., Aaron J. Seigo wrote: > > plasma/generic/applets/systemtray/core/manager.h, line 54 > > > > > > the manager is shared across all instances of the system tray plasmoid. > > (look for s_m

Re: Review Request: Fix battery applet screen power management

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106784/#review21321 --- This review has been submitted with commit 39bf5c0560791932d03

KDEREVIEW: share like connect and plasmate

Hello all ... This is to inform everyone that the plasmate and share-like-connect repositories have been moved into KDE Review so that, if all goes according to plan, we can move them to their more permanent homes in a couple of weeks. Most of the apps in the plasmate repo have actually been in

Re: Review Request: Fix battery applet screen power management

> On Nov. 1, 2012, 3:18 p.m., Commit Hook wrote: > > This review has been submitted with commit > > e1bf8805b3d0c8ddf22805f334faec8bd678742e by Oliver Henshaw to branch > > push/4.9. "push/4.9" is not a valid branch name for kde-workspace. If these commits should be part of KDE 4.9.3 release,

Re: PLASMA_PLATFORM and kdeglobals runtimePlatform

On Tuesday 30 October 2012, Aaron J. Seigo wrote: > QStringList KDeclarative::runtimePlatform() > QString KDeclarative::componentsTarget() > QString KDeclarative::defaultComponentsTarget() > > you can control this with the PLASMA_PLATFORM environment variable: > > PLASMA_PLATFORM=tablet:tou

Re: Review Request: Port the Calculator applet to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107001/ --- (Updated Nov. 1, 2012, 11:36 p.m.) Review request for Plasma. Changes --

Re: Review Request: Fix battery applet screen power management

> On Nov. 1, 2012, 3:18 p.m., Commit Hook wrote: > > This review has been submitted with commit > > e1bf8805b3d0c8ddf22805f334faec8bd678742e by Oliver Henshaw to branch > > push/4.9. > > Christoph Feck wrote: > "push/4.9" is not a valid branch name for kde-workspace. If these commits > sh