---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107160/#review21280
---
Manager does not need to know about Applet (see comment below
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107166/#review21281
---
the reason this is still in MobileComponent is because it
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107165/#review21282
---
Ship it!
looks good from here...
- Aaron J. Seigo
On Oct.
On Nov. 1, 2012, 9:47 a.m., Aaron J. Seigo wrote:
plasma/generic/applets/systemtray/core/manager.h, line 54
http://git.reviewboard.kde.org/r/107160/diff/1/?file=93099#file93099line54
the manager is shared across all instances of the system tray plasmoid.
(look for s_manager) this
On Nov. 1, 2012, 9:47 a.m., Aaron J. Seigo wrote:
plasma/generic/applets/systemtray/core/manager.h, line 54
http://git.reviewboard.kde.org/r/107160/diff/1/?file=93099#file93099line54
the manager is shared across all instances of the system tray plasmoid.
(look for s_manager) this
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107165/#review21292
---
Ship it!
+1 from here too
- Marco Martin
On Oct. 31, 2012,
On Nov. 1, 2012, 9:58 a.m., Aaron J. Seigo wrote:
the reason this is still in MobileComponent is because it isn't quite
general purpose use ready. the biggest issue is that it always assumes a
Plasma/Generic type and can not load from anywhere other than the normal
system install
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107150/#review21294
---
I'm quite on the fence with this.
I'm not sure it should be
On Nov. 1, 2012, 9:58 a.m., Aaron J. Seigo wrote:
the reason this is still in MobileComponent is because it isn't quite
general purpose use ready. the biggest issue is that it always assumes a
Plasma/Generic type and can not load from anywhere other than the normal
system install
Hi Marco,
Thanks for the review!
On Thursday, November 01, 2012 12:29:25 Marco Martin wrote:
I'm quite on the fence with this.
I'm not sure it should be the qml containment to explicitly create the
toolbox, but more:
the c++ part of the containment scriptengine loads and parses the qml of
On Thursday, November 01, 2012 12:59:56 Aaron J. Seigo wrote:
even right now, even with generic packages, all sorts of files can be
fetched: org.kde.active.launcher, org.kde.activityswitcher,
org.kde.active.widgetsexplorer, etc.
the security / cleanliness aspect of this is not opened up by
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107165/#review21300
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106680/
---
(Updated Nov. 1, 2012, 3:08 p.m.)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106680/#review21311
---
you mean they can't have different descriptions? yes, that's
On Nov. 1, 2012, 9:47 a.m., Aaron J. Seigo wrote:
plasma/generic/applets/systemtray/core/manager.h, line 54
http://git.reviewboard.kde.org/r/107160/diff/1/?file=93099#file93099line54
the manager is shared across all instances of the system tray plasmoid.
(look for s_manager) this
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106784/#review21321
---
This review has been submitted with commit
Hello all ...
This is to inform everyone that the plasmate and share-like-connect
repositories have been moved into KDE Review so that, if all goes according to
plan, we can move them to their more permanent homes in a couple of weeks.
Most of the apps in the plasmate repo have actually been
On Nov. 1, 2012, 3:18 p.m., Commit Hook wrote:
This review has been submitted with commit
e1bf8805b3d0c8ddf22805f334faec8bd678742e by Oliver Henshaw to branch
push/4.9.
push/4.9 is not a valid branch name for kde-workspace. If these commits
should be part of KDE 4.9.3 release, you
On Tuesday 30 October 2012, Aaron J. Seigo wrote:
QStringList KDeclarative::runtimePlatform()
QString KDeclarative::componentsTarget()
QString KDeclarative::defaultComponentsTarget()
you can control this with the PLASMA_PLATFORM environment variable:
PLASMA_PLATFORM=tablet:touch
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107001/
---
(Updated Nov. 1, 2012, 11:36 p.m.)
Review request for Plasma.
Changes
On Nov. 1, 2012, 3:18 p.m., Commit Hook wrote:
This review has been submitted with commit
e1bf8805b3d0c8ddf22805f334faec8bd678742e by Oliver Henshaw to branch
push/4.9.
Christoph Feck wrote:
push/4.9 is not a valid branch name for kde-workspace. If these commits
should be part
21 matches
Mail list logo
