[KDE Bugtracking System] REMINDER: current Plasma regressions

2013-01-06 Thread bugzilla_noreply
Please find below a list of the current regressions reported for Plasma. This is a weekly reminder. This search was scheduled by myr...@kde.org. Plasma regressions -- Bug 202336: https://bugs.kde.org/show_bug.cgi?id=202336 Priority: NOR Severity: normal Platform: Gentoo

Re: Review Request: use Plasma::Dialog for brightness osd

2013-01-06 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108222/ --- (Updated Jan. 6, 2013, 11:53 p.m.) Review request for kde-workspace, Plasm

Re: Review Request: use Plasma::Dialog for kmix osd

2013-01-06 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108223/ --- (Updated Jan. 6, 2013, 11:52 p.m.) Review request for Plasma, Solid, Kai U

Re: Review Request: Plasmate: Replace QDialogButtonBox with QVBoxLayout

2013-01-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108115/#review24858 --- Ship it! I would leave the label, maybe remove the parenthesis

Re: Review Request: use Plasma::Dialog for brightness osd

2013-01-06 Thread Kai Uwe Broulik
> On Jan. 6, 2013, 3:45 p.m., Kai Uwe Broulik wrote: > > Just applied the patch from Review 107983 and your patch resolves the > > issue. Would you mind if I use that code to fix KMix OSD? > > Xuetian Weng wrote: > Well.. actually I have a review for kmix :P > https://git.reviewboard.kd

Re: Review Request: use Plasma::Dialog for kmix osd

2013-01-06 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108223/ --- (Updated Jan. 6, 2013, 10:32 p.m.) Review request for Plasma, Kai Uwe Brou

Re: Review Request: use Plasma::Dialog for brightness osd

2013-01-06 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108222/ --- (Updated Jan. 6, 2013, 10:25 p.m.) Review request for kde-workspace, Plasm

Re: plasma and new shadow mess

2013-01-06 Thread Weng Xuetian
On Sunday 06 January 2013 16:43:58,Aaron J. Seigo : > On Sunday, January 6, 2013 08:47:28 Weng Xuetian wrote: > > Revert the code will also cause too much problem now IMHO.. revert the > > theme change thus we can use the old air which will reduce the impact to > > least. I don't think 3rd party th

Re: Review Request: use Plasma::Dialog for brightness osd

2013-01-06 Thread Xuetian Weng
> On Jan. 6, 2013, 3:45 p.m., Kai Uwe Broulik wrote: > > Just applied the patch from Review 107983 and your patch resolves the > > issue. Would you mind if I use that code to fix KMix OSD? Well.. actually I have a review for kmix :P https://git.reviewboard.kde.org/r/108223/ - Xuetian --

Re: KDEREVIEW: share like connect and plasmate

2013-01-06 Thread Aaron J. Seigo
On Sunday, January 6, 2013 18:27:48 David Edmundson wrote: > I noticed the API of providelib is still completely undocumented. As a agreed. and until it is documented, i don't expect anyone to reasonably write plugins for it. documentation of this internal API will happen (i've written enough ap

Re: KDEREVIEW: share like connect and plasmate

2013-01-06 Thread David Edmundson
On Sun, Jan 6, 2013 at 1:10 AM, Aaron J. Seigo wrote: > On Thursday, January 3, 2013 09:56:47 Ben Cooksley wrote: >> What about Share-Like-Connect? > > i was waiting until i was back in the office with time to work on it again > before requesting the move. :) > > so ... yes, SLC is ready to be mov

Re: Review Request: use Plasma::Dialog for brightness osd

2013-01-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108222/#review24840 --- Just applied the patch from Review 107983 and your patch resolv

Re: plasma and new shadow mess

2013-01-06 Thread Aaron J. Seigo
On Sunday, January 6, 2013 08:47:28 Weng Xuetian wrote: > Revert the code will also cause too much problem now IMHO.. revert the > theme change thus we can use the old air which will reduce the impact to > least. I don't think 3rd party theme would use this new shadow feature this > soon. i just c

Re: Review Request: use Plasma::Dialog for brightness osd

2013-01-06 Thread Xuetian Weng
> On Jan. 6, 2013, 3:25 p.m., Kai Uwe Broulik wrote: > > The code basically is fine, except that you could make the OSD a bit wider > > (increase width) like the old one. > > > > There is a problem on the Plasma side, however. I adapted your code for > > KMix which also suffers the same proble

Re: Review Request: use Plasma::Dialog for brightness osd

2013-01-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108222/#review24834 --- The code basically is fine, except that you could make the OSD

Re: plasma and new shadow mess

2013-01-06 Thread Weng Xuetian
On Sun, Jan 6, 2013 at 7:35 AM, Martin Graesslin wrote: > On Monday 24 December 2012 17:12:22 Weng Xuetian wrote: > > I think some action need to be taken before the release, some possible > > solutions. > > 1. Revert the changes of new plasma air theme, so old shadow can be used. > > and try to

Re: Review Request: use Plasma::Dialog for brightness osd

2013-01-06 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108222/ --- (Updated Jan. 6, 2013, 1:36 p.m.) Review request for kde-workspace, Plasma

Re: plasma and new shadow mess

2013-01-06 Thread Martin Graesslin
On Monday 24 December 2012 17:12:22 Weng Xuetian wrote: > I think some action need to be taken before the release, some possible > solutions. > 1. Revert the changes of new plasma air theme, so old shadow can be used. > and try to fix all the things in KDE 4.11 Personal opinion: the change should b

Re: Review Request: fix kwin tabbox shadow

2013-01-06 Thread Martin Gräßlin
> On Jan. 6, 2013, 7:34 a.m., Martin Gräßlin wrote: > > I don't like having a link dependency on plasmagenericshell. If that is > > supposed to be used, then it needs to go to the workspaces libs. > > > > I also think that this approach just doesn't scale. We use Plasma styled > > dialogs for

Re: Review Request: fix kwin tabbox shadow

2013-01-06 Thread Thomas Lübking
> On Jan. 6, 2013, 7:34 a.m., Martin Gräßlin wrote: > > I don't like having a link dependency on plasmagenericshell. If that is > > supposed to be used, then it needs to go to the workspaces libs. > > > > I also think that this approach just doesn't scale. We use Plasma styled > > dialogs for

Re: Review Request: Fix bug 289427 - plasma-desktop freezes when selecting fixed-size fonts in the clock widget

2013-01-06 Thread Chao Feng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108102/ --- (Updated Jan. 5, 2013, 3:14 a.m.) Review request for Plasma. Changes ---

Review Request: Fix bug 289427 - plasma-desktop freezes when selecting fixed-size fonts in the clock widget

2013-01-06 Thread Chao Feng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108102/ --- Review request for Plasma. Description --- Bug 289427 is caused by a

Re: Review Request: fix kwin tabbox shadow

2013-01-06 Thread Xuetian Weng
> On Jan. 6, 2013, 7:34 a.m., Martin Gräßlin wrote: > > I don't like having a link dependency on plasmagenericshell. If that is > > supposed to be used, then it needs to go to the workspaces libs. > > > > I also think that this approach just doesn't scale. We use Plasma styled > > dialogs for