Review Request: Do not clip away shadows in SlidingPopupsEffect

2013-01-08 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108255/ --- Review request for kwin and Plasma. Description --- Do not clip away

Re: Review Request: use Plasma::Dialog for icontasks tooltips

2013-01-08 Thread Cedric Bellegarde
> On Jan. 7, 2013, 3 p.m., Xuetian Weng wrote: > > applets/icontasks/tooltips/tooltip.cpp, line 267 > > > > > > You'd better manually set > > > > setAttribute(Qt::WA_X11NetWmWindowTypeToolTip, true); > >

Re: Review Request: use Plasma::Dialog for icontasks tooltips

2013-01-08 Thread Cedric Bellegarde
> On Jan. 7, 2013, 4:49 p.m., Xuetian Weng wrote: > > And I don't really think Plasma::Dialog is suitable here. Plasma::Dialog > > use hardcoded dialogs/background svg path internally, which should be > > tooltips. And paintEvent is duplicated, you don't really use Plasma::Dialog > > paintEven

Re: Review Request: use Plasma::Dialog for icontasks tooltips

2013-01-08 Thread Cedric Bellegarde
> On Jan. 7, 2013, 3 p.m., Xuetian Weng wrote: > > applets/icontasks/tooltips/tooltip.cpp, line 267 > > > > > > You'd better manually set > > > > setAttribute(Qt::WA_X11NetWmWindowTypeToolTip, true); > >

Re: Review Request: use Plasma::Dialog for icontasks tooltips

2013-01-08 Thread Cedric Bellegarde
> On Jan. 7, 2013, 4:49 p.m., Xuetian Weng wrote: > > And I don't really think Plasma::Dialog is suitable here. Plasma::Dialog > > use hardcoded dialogs/background svg path internally, which should be > > tooltips. And paintEvent is duplicated, you don't really use Plasma::Dialog > > paintEven

Re: Review Request: use Plasma::Dialog for icontasks tooltips

2013-01-08 Thread Cedric Bellegarde
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108241/ --- (Updated Jan. 8, 2013, 9:50 a.m.) Review request for Plasma and Aaron J. S

Re: Review Request: Fix bug 289427 - plasma-desktop freezes when selecting fixed-size fonts in the clock widget

2013-01-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108102/#review24974 --- This review has been submitted with commit 7ef30a8453dc0f37c42

Re: Review Request: Fix bug 289427 - plasma-desktop freezes when selecting fixed-size fonts in the clock widget

2013-01-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108102/#review24975 --- This review has been submitted with commit c7301544bc07dd024de

Re: Review Request: Do not clip away shadows in SlidingPopupsEffect

2013-01-08 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108255/#review24977 --- Tested only with XRender so far: Works fine, had a weird intera

Review Request: port kdelib's tooltip shadow code to icontasks, and remove halo

2013-01-08 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108265/ --- Review request for Plasma, Cedric Bellegarde and Aaron J. Seigo. Descripti

Re: Review Request: Do not clip away shadows in SlidingPopupsEffect

2013-01-08 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108255/#review24980 --- Test with OpenGL/XRender, seems when it get popup from bottom t

Re: Review Request: Do not clip away shadows in SlidingPopupsEffect

2013-01-08 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108255/#review24992 --- when hide popup from screen edge, it might get some shadow rema

Re: Review Request: Do not clip away shadows in SlidingPopupsEffect

2013-01-08 Thread Martin Gräßlin
> On Jan. 8, 2013, 5:05 p.m., Xuetian Weng wrote: > > when hide popup from screen edge, it might get some shadow remain on the > > screen, screen shot for hiding krunner: > > http://wstaw.org/m/2013/01/08/exp3_1.png ok, looks like I have to look at it again tomorrow. - Martin -

Review Request: fix random battery cumulative data error update upon resume

2013-01-08 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108280/ --- Review request for Plasma, Viranch Mehta and Viranch Mehta. Description --

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-08 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review25012 --- after I apply the patch, I notice that in some random unknnow c

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-08 Thread Thomas Lübking
> On Jan. 8, 2013, 11:15 p.m., Xuetian Weng wrote: > > after I apply the patch, I notice that in some random unknnow case > > KWindowSystem will emit the signal, while KSelectionOwner is not. (And I > > think KSelectionOwner is correct since I didn't do anything to kwin), and I > > notice some

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-08 Thread Xuetian Weng
> On Jan. 8, 2013, 11:15 p.m., Xuetian Weng wrote: > > after I apply the patch, I notice that in some random unknnow case > > KWindowSystem will emit the signal, while KSelectionOwner is not. (And I > > think KSelectionOwner is correct since I didn't do anything to kwin), and I > > notice some

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-08 Thread Xuetian Weng
> On Jan. 8, 2013, 11:15 p.m., Xuetian Weng wrote: > > after I apply the patch, I notice that in some random unknnow case > > KWindowSystem will emit the signal, while KSelectionOwner is not. (And I > > think KSelectionOwner is correct since I didn't do anything to kwin), and I > > notice some

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-08 Thread Thomas Lübking
> On Jan. 8, 2013, 11:15 p.m., Xuetian Weng wrote: > > after I apply the patch, I notice that in some random unknnow case > > KWindowSystem will emit the signal, while KSelectionOwner is not. (And I > > think KSelectionOwner is correct since I didn't do anything to kwin), and I > > notice some

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-08 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review25025 --- kdeui/windowmanagement/kwindowsystem_x11.cpp

Re: Review Request: Fix KWindowSystem::compositingChanged signal

2013-01-08 Thread Thomas Lübking
> On Jan. 9, 2013, 1:38 a.m., Xuetian Weng wrote: > > kdeui/windowmanagement/kwindowsystem_x11.cpp, line 168 > > > > > > I don't quite get why this part is required. Since KWindowSystem > > already calls SelectSe

Review Request: plasmoidviewer: respect --containment flag in sizing and scenerect

2013-01-08 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108284/ --- Review request for Plasma. Description --- plasmoidviewer: respec

[KDE Bugtracking System] REMINDER: current Plasma regressions

2013-01-08 Thread bugzilla_noreply
Please find below a list of the current regressions reported for Plasma. This is a weekly reminder. This search was scheduled by myr...@kde.org. Plasma regressions -- Bug 202336: https://bugs.kde.org/show_bug.cgi?id=202336 Priority: NOR Severity: normal Platform: Gentoo

Re: Review Request: Do not clip away shadows in SlidingPopupsEffect

2013-01-08 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108255/ --- (Updated Jan. 9, 2013, 7:08 a.m.) Review request for kwin and Plasma. Ch