Re: Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-29 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108438/ --- (Updated Jan. 30, 2013, 8:25 a.m.) Review request for kwin, Plasma, Sebast

Re: Review Request 108664: Remove absolute paths from Plasma/Generic packages

2013-01-29 Thread Sebastian Kügler
> On Jan. 29, 2013, 10:51 p.m., Sebastian Kügler wrote: > > Patch looks good, code *now* does what I'd expect it to. > > > > I've tested it, and it fixes the issue. > > > > A grep through my src checkouts reveals 29 uses of PackageStructure with > > Plasma/Generic, so the work to check it all

Re: Review Request 108664: Remove absolute paths from Plasma/Generic packages

2013-01-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108664/#review26386 --- Ship it! Patch looks good, code *now* does what I'd expect it

Re: Review Request 108425: Fixes for grace time in screenlocker

2013-01-29 Thread Oliver Henshaw
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108425/#review26384 --- The "Stop grace period on unlock" part might be serious enough

Re: Review Request 108664: Remove absolute paths from Plasma/Generic packages

2013-01-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108664/ --- (Updated Jan. 29, 2013, 8:07 p.m.) Review request for Plasma, Marco Martin

Re: plasma javascripting

2013-01-29 Thread Aaron J. Seigo
On Tuesday, January 29, 2013 16:24:31 Nowardev-Team wrote: > and it worked fine but for dolphin you get this > > > dolphin %i -caption "%c" %u this is the exec line from the .desktop file. i supose it could either: * simply return the .desktop file path (might break any users of it that don't

Review Request 108664: Remove absolute paths from Plasma/Generic packages

2013-01-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108664/ --- Review request for Plasma, Marco Martin and Sebastian Kügler. Description

Re: Review Request 108425: Fixes for grace time in screenlocker

2013-01-29 Thread Oliver Henshaw
> On Jan. 15, 2013, 4:47 p.m., Marco Martin wrote: > > if a password isn't required, shouldn't hide the password dialog as well? > > (like showing only the background) Good point. Maybe the dialog shouldn't be shown immediately on lock either? I've tried playing with hiding the dialog to exten

Re: [Kde-hardware-devel] Plasma / Solid sprint

2013-01-29 Thread Sebastian Kügler
On Tuesday, January 29, 2013 16:58:44 Lukáš Tinkl wrote: > Dne 29.1.2013 15:21, Sebastian Kügler napsal(a): > > So we still want to have Plasma and Solid sprints this spring, time to > > make > > some arrangements for that. > > > > I've talked to our potential sponsor, and they said they could hos

Re: Review Request 108643: Fix screenlocker lockwindow geometry on screen resizes (take 2)

2013-01-29 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108643/#review26372 --- Ship it! Please revert the forceActiveWindow call to activateW

Re: repository changes for plasma2/frameworks5

2013-01-29 Thread David Faure
On Tuesday 29 January 2013 09:03:00 Kevin Ottens wrote: > On Monday 28 January 2013 18:54:12 Stephen Kelly wrote: > > Marco Martin wrote: > > > Most important, what is the less messy git way to do it? > > > > As we discussed on IRC, it may be better to split plasma out into its own > > repo now al

Re: repository changes for plasma2/frameworks5

2013-01-29 Thread Marco Martin
On Tuesday 29 January 2013, Kevin Ottens wrote: > > plasma repo and discovers they now need another include or whatever. Then > > it just depends on how often they update/build. People working on > > frameworks/plasma are not inexperienced newbies who don't know how to fix > > minor issues like th

plasma javascripting

2013-01-29 Thread Nowardev-Team
i did this print (defaultApplication("video/quicktime")) print (defaultApplication("browser")) print (defaultApplication("filemanager")) print (defaultApplication("mailer")) print (defaultApplication("terminal")) print (defaultApplication("imClient")) and it worked fine but for dolphin you get

Plasma / Solid sprint

2013-01-29 Thread Sebastian Kügler
Hey all, So we still want to have Plasma and Solid sprints this spring, time to make some arrangements for that. I've talked to our potential sponsor, and they said they could host also a "larger group", so combining two sprints would probably work (but not be necessary, if we decide so). The

Re: Non-OAuth Support in Microblogging Plasmoid

2013-01-29 Thread Sebastian Kügler
On Monday, January 28, 2013 23:10:54 David Narvaez wrote: > As you'll see in the logs, I've been giving some maintenance to the > Microblogging plasmoid. As I was reviewing open bug reports I stumbled upon > bug 304704. The users expecto be able to use the microblogging plasmoid to > log into any S

Re: repository changes for plasma2/frameworks5

2013-01-29 Thread Kevin Ottens
On Tuesday 29 January 2013 09:11:54 Stephen Kelly wrote: > Kevin Ottens wrote: > > OTOH, there's also reasons to not split too early. It depended on quite > > some stuff in other modules last I checked (could have changed), moving it > > to another repo that early means less eyeballs and build prob

Re: repository changes for plasma2/frameworks5

2013-01-29 Thread Kevin Ottens
On Monday 28 January 2013 18:54:12 Stephen Kelly wrote: > Marco Martin wrote: > > Most important, what is the less messy git way to do it? > > As we discussed on IRC, it may be better to split plasma out into its own > repo now already, like we did with nepomuk. OTOH, there's also reasons to not s