Re: Review Request 109604: Model to provide easy access to KWin's Clients from QML

2013-03-27 Thread Martin Gräßlin
On March 21, 2013, 10:06 p.m., Thomas Lübking wrote: kwin/scripting/scripting_model.cpp, line 190 http://git.reviewboard.kde.org/r/109604/diff/1/?file=120515#file120515line190 considered to keep m_clients and m_ids as hash/map or at least a pair (implicitly documenting this is

Re: Meeting for Plasma Media Center - what next?

2013-03-27 Thread Sinny Kumari
Plasma Media Center IRC meeting started at #plasma. Feel free to join into discussion. On Mon, Mar 25, 2013 at 12:05 AM, Shantanu Tushar Jha shant...@kde.org wrote: Including plasma active ML as well. On Sun, Mar 24, 2013 at 3:59 PM, Shantanu Tushar Jha shant...@kde.org wrote: Hi, I have

Re: FYI: Platform content discussion in Qt

2013-03-27 Thread Aaron J. Seigo
On Tuesday, March 26, 2013 13:53:29 Alan Alpert wrote: import org.kde.plasma.components 1.0 as... and import the right set, but the ideal way is (if we are importing touch components) to have a set of just the components that are rewritten for touchscreen, while falling back to the

Plasma Media Center IRC meeting log

2013-03-27 Thread Sinny Kumari
Hi! Thanks to all for joining Plasma Media Center IRC meeting and making it productive :) Here is the summary of meeting: Things to be completed for Plasma Media Center 1.1 release: 1. Merging Fabian’s branch into master. It is related to code re-factoring which provides reusable

Re: [Nepomuk] Nepomukcontroller rewritten in QML

2013-03-27 Thread Jörg Ehrichs
Nicely done! I did a quick look over the code and you're still using QDBusConnection::sessionBus().interface()-isServiceRegistered which unfortunately is a blocking DBus call. You can however replace it with something like [...] Thanks a lot for the hint. I've change my code to use these

Re: [Nepomuk] Nepomukcontroller rewritten in QML

2013-03-27 Thread David Edmundson
Awesome, Is it ready to give it another review? David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [Nepomuk] Nepomukcontroller rewritten in QML

2013-03-27 Thread Jörg Ehrichs
Is it ready to give it another review? Yes it is, but please have a look at the nepomukcontroller-qml branch in kde-workspace as this is the codebase I like to git merge in about 2 weeks if no one is against it. The code base is the same as in my scratch repo, but the cmake part is a bit

Re: [Nepomuk] Nepomukcontroller rewritten in QML

2013-03-27 Thread David Edmundson
Nicely done, a few minor comments still, but a ship it! from me. Applet: Missing Messages.sh file This is needed to tell the translation mechanism to extract the messages in the i18n functions Copy this from another existing applet. Make sure you copy a version from an applet that already

Re: Review Request 109595: active-welcome plasmoid: use plasmacomponents ToolButton

2013-03-27 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109595/#review29970 --- Ship it! Ship It! - Sebastian Kügler On March 21, 2013,

Re: Review Request 109773: New runner that translates words and sentences via Google Translate.

2013-03-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109773/#review29972 --- Your diff is broken. This looks like a case that your branch