Review Request 110382: Fix a crash that happens when you close some apps

2013-05-10 Thread Anne-Marie Mahfouf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110382/ --- Review request for Plasma. Description --- This patch fixes a crash

Re: Review Request 110382: Fix a crash that happens when you close some apps

2013-05-10 Thread Anne-Marie Mahfouf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110382/ --- (Updated May 10, 2013, 12:55 p.m.) Review request for Plasma.

Re: Review Request 110382: Fix a crash that happens when you close some apps

2013-05-10 Thread Anne-Marie Mahfouf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110382/ --- (Updated May 10, 2013, 12:57 p.m.) Review request for Plasma and Aurélien

Re: Review Request 110382: Fix a crash that happens when you close some apps

2013-05-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110382/#review32314 --- plasma/private/dialogshadows.cpp

Re: Review Request 110382: Fix a crash that happens when you close some apps

2013-05-10 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110382/#review32319 --- Ship it! please fix the coding style, and then commit. cheers

Re: Review Request 110382: Fix a crash that happens when you close some apps

2013-05-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110382/#review32320 --- This review has been submitted with commit

Re: Review Request 110382: Fix a crash that happens when you close some apps

2013-05-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110382/ --- (Updated May 10, 2013, 3:07 p.m.) Status -- This change has been

Using plasma enums from QML2

2013-05-10 Thread Marco Martin
Hi all, After many experiments in varuious failing directions, i have the branch PlasmaTypesClass of palsma-framework The problem: we need a way to expose the enums used in libplasma such as FormFactor, Location, Constraints etc in some way accessible to QML, for applet bindings, and any

Re: Using plasma enums from QML2

2013-05-10 Thread Shantanu Tushar Jha
The cons don't seem very problematic, any other reasons why you don't like the approach? I guess the only other thing you can do is use strings, and that would suck even more :P On Fri, May 10, 2013 at 11:14 PM, Marco Martin notm...@gmail.com wrote: Hi all, After many experiments in varuious