Review Request 110860: Window list using QML 1

2013-06-06 Thread Heena Mahour
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110860/ --- Review request for Plasma and Marco Martin. Description --- I have tr

Re: Review Request 110860: Window list using QML 1

2013-06-06 Thread Heena Mahour
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110860/ --- (Updated June 7, 2013, 4:02 a.m.) Review request for Plasma and Marco Mart

Re: Review Request 110843: Ensure we actually have Qwt 5 by looking for a header present only in Qwt 5

2013-06-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110843/#review33888 --- This review has been submitted with commit f48e01326dc23d45468

Re: Review Request 110856: A minor fix to make the "Back button" on the Media Controller of the PMC work when the user clicks on the empty homescreen space to open up the slideshow again.

2013-06-06 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110856/#review33887 --- backStopped should be set to true if and only if mediaBrowser.

Re: Review Request 110856: A minor fix to make the "Back button" on the Media Controller of the PMC work when the user clicks on the empty homescreen space to open up the slideshow again.

2013-06-06 Thread Akshay Ratan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110856/ --- (Updated June 6, 2013, 9:23 p.m.) Review request for Plasma, Shantanu Tush

Re: QML Task Manager merged

2013-06-06 Thread Eike Hein
On Thursday 06 June 2013 22:44:28 Aaron J. Seigo wrote: > btw, just noticed another regression: windows don't minimize to the tasks > widget anymore. This should generally work, and actually for the most part better than in the old widget, but there's a few more cases I need to handle for republis

Re: Review Request 110776: Bug 317451 Fix : A way to return to media from main screen

2013-06-06 Thread Akshay Ratan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110776/ --- (Updated June 6, 2013, 9:02 p.m.) Status -- This change has been mark

Re: QML Task Manager merged

2013-06-06 Thread Aaron J. Seigo
On Thursday, June 6, 2013 22:35:18 Eike Hein wrote: > So I fear all that sliding on the top-level bar might just be > too much really i have the same intuition. can't hurt to try it, but i expect it will be too much. btw, just noticed another regression: windows don't minimize to the tasks wid

Re: QML Task Manager merged

2013-06-06 Thread Eike Hein
On Thursday 06 June 2013 18:12:30 Marco Martin wrote: > On Thursday 06 June 2013, Aaron J. Seigo wrote: > > btw, i thought quite a bit about perhaps doing the same also in the main > > applet UI itself .. but with multiple rows it will likely look ugly; imo > > grids do not look great when the sele

Re: QML Task Manager merged

2013-06-06 Thread Marco Martin
On Thursday 06 June 2013, Aaron J. Seigo wrote: > > btw, i thought quite a bit about perhaps doing the same also in the main > applet UI itself .. but with multiple rows it will likely look ugly; imo > grids do not look great when the selection rect slides around, whereas it > works terrifically

Re: QML Task Manager merged

2013-06-06 Thread Aaron J. Seigo
On Thursday, June 6, 2013 14:45:15 Eike Hein wrote: > - Popup: Actually intentional after conferring with Sebas and IIRC Apol or > Marco when making that decision ... Sebas was passionate that not reusing > the task delegate would constitute information loss ("it's a task because > it looks like on

Re: Review Request 106110: Make autohide panel do not intercept events in fullscreen app

2013-06-06 Thread Aaron J. Seigo
> On May 3, 2013, 6:53 p.m., Marco Martin wrote: > > Ship It! > > Martin Gräßlin wrote: > has this review been merged yet? not to my knowledge, no. i'm neck deep in meetings today if someone else feels like doing it :) - Aaron J.

Re: QML Task Manager merged

2013-06-06 Thread Marco Martin
On Thursday 06 June 2013, Eike Hein wrote: > - Popup: Actually intentional after conferring with Sebas and IIRC Apol or > Marco when making that decision ... Sebas was passionate that not reusing > the task delegate would constitute information loss ("it's a task because > it looks like one"), and

Re: QML Task Manager merged

2013-06-06 Thread Eike Hein
Afk right now but quick replies: - Thanks for having a look :) - Sizing/clipping: Aye, I decided to go with 'correct' handling/respecting of the FrameSvg initially rather than optimize prematurely and clutter up the QML, but I agree a little extra mile for common small panel sizes would be swee

Re: QML Task Manager merged

2013-06-06 Thread Aaron J. Seigo
On Wednesday, June 5, 2013 22:36:40 Eike Hein wrote: > I've just merged the QML port of the default Task Manager widget so .. report #1 :) see screenshot here: http://makeplaylive.com/~aseigo/qml_tasks_take1.png a few issues can be spotted. first, the text is cut off at the bottom. my p

Re: QML Task Manager merged

2013-06-06 Thread Marco Martin
On Wednesday 05 June 2013 22:36:40 Eike Hein wrote: > Mid-term, I want to have the widget feature-complete and > regression-free by the time we release 4.11 - the bottom > line is to have something that's far less buggy and that's > portable to Plasma 2. > > Long-term, I intend to maintain the new

Re: Review Request 106110: Make autohide panel do not intercept events in fullscreen app

2013-06-06 Thread Martin Gräßlin
> On May 3, 2013, 8:53 p.m., Marco Martin wrote: > > Ship It! has this review been merged yet? - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106110/#review31964 ---