Re: Review Request 111650: Adjust RunnerManager to new ThreadWeaver API using JobPointer

2013-07-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111650/#review36430 --- Looks good overall, I still think a typedef for

Re: Review Request 111650: Adjust RunnerManager to new ThreadWeaver API using JobPointer

2013-07-24 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111650/#review36454 --- Ship it! Ship It! - Aaron J. Seigo On July 23, 2013, 11:23

framework5/plasma2

2013-07-24 Thread Heena Mahour
Hey , I want to build framework5/plasma2 to test the plasma2 plasmoids that I will be porting from plasma1 .For that what I need to build apart from plasma-framework ? Are these[1][2] links sufficient to build it? And, I could use plasmoidviewer for plasma2 plasmoids , so I will have to install

Re: framework5/plasma2

2013-07-24 Thread Heena Mahour
^^And, I could not use plasmoidviewer for plasma2 plasmoids :p On Thu, Jul 25, 2013 at 12:05 AM, Heena Mahour heena...@gmail.com wrote: Hey , I want to build framework5/plasma2 to test the plasma2 plasmoids that I will be porting from plasma1 .For that what I need to build apart from

Re: Proposal for branching policy towards KF5

2013-07-24 Thread Michael Pyne
On Fri, July 19, 2013 00:21:21 you wrote: After more live discussion with Sebas and Marco plus Aaron over a video chat, we came up with the following setup for the workspace repos (*) : - the development branch for their next feature release (based on Qt5/KF5) will be master. - *before*

Re: Review Request 111650: Adjust RunnerManager to new ThreadWeaver API using JobPointer

2013-07-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111650/ --- (Updated July 25, 2013, 4:57 a.m.) Status -- This change has been

Re: Review Request 111650: Adjust RunnerManager to new ThreadWeaver API using JobPointer

2013-07-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111650/#review36469 --- This review has been submitted with commit