Re: Review Request 111899: Make QGuiPlatformPlugin react to iconChanges

2013-08-06 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111899/ --- (Updated Aug. 6, 2013, 7:02 a.m.) Review request for Plasma and Olivier

Re: Review Request 111899: Make QGuiPlatformPlugin react to iconChanges

2013-08-06 Thread Olivier Goffart
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111899/#review37191 --- Ship it! Ship It! - Olivier Goffart On Aug. 6, 2013, 7:02

Re: Review Request 111748: Better wrap QMimeData by retaining support for QByteArray

2013-08-06 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111748/#review37196 --- Ship it! Ship It! - Marco Martin On July 27, 2013, 6:41

Re: Review Request 111748: Better wrap QMimeData by retaining support for QByteArray

2013-08-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111748/#review37198 --- This review has been submitted with commit

Re: Review Request 111748: Better wrap QMimeData by retaining support for QByteArray

2013-08-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111748/ --- (Updated Aug. 6, 2013, 10:01 a.m.) Status -- This change has been

Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-08-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/ --- Review request for KDE Frameworks and Plasma. Description --- Add

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-08-06 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/#review37219 --- As a non-Plasma user of this class, I fully support it being

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-08-06 Thread Martin Gräßlin
On Aug. 6, 2013, 4:52 p.m., David Edmundson wrote: tier1/kconfig/src/gui/kconfigloader.h, line 112 http://git.reviewboard.kde.org/r/111908/diff/1/?file=176360#file176360line112 This looks like it should be const I suspect it wasn't because KCoreConfigSeleton::findItem

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-08-06 Thread Aleix Pol Gonzalez
On Aug. 6, 2013, 2:52 p.m., David Edmundson wrote: tier1/kconfig/src/gui/kconfigloader.h, line 112 http://git.reviewboard.kde.org/r/111908/diff/1/?file=176360#file176360line112 This looks like it should be const I suspect it wasn't because KCoreConfigSeleton::findItem

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-08-06 Thread Martin Gräßlin
On Aug. 6, 2013, 4:52 p.m., David Edmundson wrote: tier1/kconfig/src/gui/kconfigloader.h, line 112 http://git.reviewboard.kde.org/r/111908/diff/1/?file=176360#file176360line112 This looks like it should be const I suspect it wasn't because KCoreConfigSeleton::findItem