Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112375/ --- Review request for Plasma and Hugo Pereira Da Costa. Description ---

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112375/ --- (Updated Aug. 30, 2013, 11:11 a.m.) Review request for Plasma and Hugo

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112375/#review38928 --- I respectfully disagree with the change. If I understand the

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread David Edmundson
On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote: I respectfully disagree with the change. If I understand the descripion right, the only thing that matters for QtQuick is to change the default returned value (if all else fail) from 1 to FRAME_FRAMEWIDTH. Correct ?

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread Christoph Feck
On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote: I respectfully disagree with the change. If I understand the descripion right, the only thing that matters for QtQuick is to change the default returned value (if all else fail) from 1 to FRAME_FRAMEWIDTH. Correct ?

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread Hugo Pereira Da Costa
On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote: I respectfully disagree with the change. If I understand the descripion right, the only thing that matters for QtQuick is to change the default returned value (if all else fail) from 1 to FRAME_FRAMEWIDTH. Correct ?

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread David Edmundson
On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote: I respectfully disagree with the change. If I understand the descripion right, the only thing that matters for QtQuick is to change the default returned value (if all else fail) from 1 to FRAME_FRAMEWIDTH. Correct ?

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread Marco Martin
On Friday 30 August 2013 13:44:35 Hugo Pereira Da Costa wrote: Second: support the lowest common denominator of QStyle that they both follow even I disagree, and besides, I believe this will simply not work. It 'sort of does' in this specific case, but then q_object_cast is used all over the

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread Hugo Pereira Da Costa
On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote: I respectfully disagree with the change. If I understand the descripion right, the only thing that matters for QtQuick is to change the default returned value (if all else fail) from 1 to FRAME_FRAMEWIDTH. Correct ?

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread Eike Hein
On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote: I respectfully disagree with the change. If I understand the descripion right, the only thing that matters for QtQuick is to change the default returned value (if all else fail) from 1 to FRAME_FRAMEWIDTH. Correct ?

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread David Edmundson
On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote: I respectfully disagree with the change. If I understand the descripion right, the only thing that matters for QtQuick is to change the default returned value (if all else fail) from 1 to FRAME_FRAMEWIDTH. Correct ?

Re: Review Request 112375: Use a single frame width for all PM_DefaultFrameWidth

2013-08-30 Thread Eike Hein
On Aug. 30, 2013, 12:43 p.m., Hugo Pereira Da Costa wrote: I respectfully disagree with the change. If I understand the descripion right, the only thing that matters for QtQuick is to change the default returned value (if all else fail) from 1 to FRAME_FRAMEWIDTH. Correct ?

Re: Review Request 112236: krunner: Add the full name of completion matches to history

2013-08-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112236/#review38954 --- Ship it! minus the unrelated change that got pulled it

Re: Review Request 112360: Enable mouse DataEngine on KF5

2013-08-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112360/#review38953 --- what compilation errors are you getting exactly? is it finding

Re: naming the next major release

2013-08-30 Thread Aaron J. Seigo
On Friday, August 23, 2013 11:50:20 Marco Martin wrote: On Thursday 22 August 2013 23:20:11 Giorgos Tsiapaliokas wrote: KDE, for instance the most references in plasma active are Plasma Active and not KDE Plasma Active, but PA doesn't have any distance from KDE. I believe that projects take

Re: QML/javascript and KNotification

2013-08-30 Thread Marco Martin
On Friday 30 August 2013 19:57:44 Aaron J. Seigo wrote: --localprefix` on installation and then add information as to which notifyrc to use in calls to knotify4 ... but this feels like a maassive hack. i really think this is probably only something that can be properly fixed in

Re: Help to display custom settings dialog in plasma widget (Python)

2013-08-30 Thread Aaron J. Seigo
On Wednesday, August 21, 2013 17:17:18 bug seagull wrote: I am creating a plasma widget that displays certain elements of an rss feed . It requires a string from the user in order to set the widget up. To get this input I made a dialog using qt designer and converted it to python code and

QML/javascript and KNotification

2013-08-30 Thread Anthony Vital
Hello, I'm trying to use KNotification in a QML plasmoid but there doesn't seem to be a good way to do this. Using the notifications dataengine is not satisfying because it won't let me use a .notifyrc file. So for now I use a qdbus command but it's kind of a hack. Moreover, in order to install

Re: My first plasmoid

2013-08-30 Thread Aaron J. Seigo
On Friday, August 23, 2013 23:40:06 Niclas Ekstedt wrote: So what do you guys think. Would this be possible to do? And are there any examples available that would help me along? There is already lionmail that does much of what you’re looking for .. but it needs a developer to apply some love

Re: QML/javascript and KNotification

2013-08-30 Thread Aaron J. Seigo
On Friday, August 30, 2013 20:23:26 Marco Martin wrote: On Friday 30 August 2013 19:57:44 Aaron J. Seigo wrote: --localprefix` on installation and then add information as to which notifyrc to use in calls to knotify4 ... but this feels like a maassive hack. i really think this is

Re: QML/javascript and KNotification

2013-08-30 Thread Aaron J. Seigo
On Friday, August 30, 2013 18:26:08 Anthony Vital wrote: Moreover, in order to install the notifyrc file correctly, I have to install it (+ the plasmoid icon so that it is detected in the notifications config panel) with CMake. I read that installing a plasmoid with CMake is the recommended

Re: QML/javascript and KNotification

2013-08-30 Thread Marco Martin
On Friday 30 August 2013 20:30:25 Aaron J. Seigo wrote: would pretty much be a relaxing of the requirement all possible types of notifications are preregistered/pre-authorized? ... or allow flexibility in where the knotifyrc file for a given notification is located. could even be

Re: Review Request 112375: Correctly determine frame width when called from QtQuickControls

2013-08-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112375/ --- (Updated Aug. 30, 2013, 3:56 p.m.) Review request for Plasma and Hugo

Re: Review Request 112375: Correctly determine frame width when called from QtQuickControls

2013-08-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112375/ --- (Updated Aug. 30, 2013, 3:55 p.m.) Review request for Plasma and Hugo

Re: Review Request 112360: Enable mouse DataEngine on KF5

2013-08-30 Thread Bhushan Shah
On Aug. 30, 2013, 5:17 p.m., Aaron J. Seigo wrote: what compilation errors are you getting exactly? is it finding xfixes on your system? ... because if it does, it will be creating a class () that isn't being built! If I uncomment the if (X11_Xfixes_FOUND) blocks I get this errors.