Re: KDE framework 5 - a humble idea

2013-09-23 Thread Aaron J. Seigo
On Monday, September 23, 2013 14:45:53 Michele Andrea Kipiel wrote: > is there a preferred way to share documents in the mailing list? is an > ubuntu one link an acceptable option? as long as it is available without requiring special software installed or an account, it doesn’t particularly matte

Re: Review Request 112723: add a visible property in the toolBox

2013-09-23 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112723/ --- (Updated Sept. 23, 2013, 3:32 p.m.) Status -- This change has been di

Re: 4.11 is out .. kde-workspace to qt5?

2013-09-23 Thread Sebastian Kügler
On Monday, September 23, 2013 19:58:08 Martin Graesslin wrote: > On Monday 16 September 2013 16:35:58 Sebastian Kügler wrote: > > > * the CMakeLists.txt needs to output a usefully verbose error message > > > when > > > it only finds kdelibs 4.x and not kf5. > > > > > > * we need to test with the la

Re: 4.11 is out .. kde-workspace to qt5?

2013-09-23 Thread Martin Graesslin
On Monday 16 September 2013 16:35:58 Sebastian Kügler wrote: > > * the CMakeLists.txt needs to output a usefully verbose error message when > > it only finds kdelibs 4.x and not kf5. > > > > * we need to test with the latest version of kdesrc-build and make it do > > the right thing by choosing th

Re: 4.11 is out .. kde-workspace to qt5?

2013-09-23 Thread Martin Graesslin
On Monday 23 September 2013 19:58:08 Martin Graesslin wrote: > > > Switch tasks: > > > > > > * merge the frameworks branch into master > > > > Martin volunteered to do this, planned for next Monday. > > blocked by pre-switch task I just tried to merge master into frameworks-scratch but gave up d

Re: Review Request 112888: Roughly port icon applet to plasma2

2013-09-23 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ --- (Updated Sept. 23, 2013, 3:39 p.m.) Review request for Plasma, Marco Marti

Re: Review Request 112888: Roughly port icon applet to plasma2

2013-09-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/#review40584 --- This review has been submitted with commit 86473b939a8a485ab6f

Re: Review Request 112888: Roughly port icon applet to plasma2

2013-09-23 Thread Bhushan Shah
> On Sept. 23, 2013, 3:49 p.m., Sebastian Kügler wrote: > > plasma/generic/applets/icon/package/contents/ui/main.qml, line 86 > > > > > > You can remove / comment the print statements here I think keeping it for n

Re: Review Request 112888: Roughly port icon applet to plasma2

2013-09-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ --- (Updated Sept. 23, 2013, 3:59 p.m.) Status -- This change has been ma

[PMC] Review of major refactoring around All Music mode

2013-09-23 Thread Shantanu Tushar Jha
Hi, * tl;dr * There is new refactored code in fabian-refactoring-shantanu which should be functionally same as master. Please take some time, test it and report if it works fine, or if a major feature is broken. * Long version * Thanks to Fabian, we had started refactoring Plasma Media Center's

Re: Review Request 112888: Roughly port icon applet to plasma2

2013-09-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/#review40580 --- Ship it! Looking good. :) plasma/generic/applets/icon/packag

Re: Review Request 112888: Roughly port icon applet to plasma2

2013-09-23 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ --- (Updated Sept. 23, 2013, 2:56 p.m.) Review request for Plasma, Marco Marti

Re: Review Request 112888: Roughly port icon applet to plasma2

2013-09-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/#review40573 --- plasma/generic/applets/icon/plugin/icon_p.h

Re: Review Request 112888: Roughly port icon applet to plasma2

2013-09-23 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ --- (Updated Sept. 23, 2013, 12:53 p.m.) Review request for Plasma, Marco Mart

Re: KDE framework 5 - a humble idea

2013-09-23 Thread Michele Andrea Kipiel
hello, is there a preferred way to share documents in the mailing list? is an ubuntu one link an acceptable option? Thank you, 2013/9/21 Michele Kipiel > Il giorno sab, 21/09/2013 alle 01.51 +0200, Sebastian Kügler ha scritto: > > Hi Michele, > > > > A few thoughts inline. I've also explained

Re: Review Request 112888: Roughly port icon applet to plasma2

2013-09-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/#review40557 --- plasma/generic/applets/icon/package/contents/ui/main.qml

Re: Review Request 112888: Roughly port icon applet to plasma2

2013-09-23 Thread Sebastian Kügler
> On Sept. 23, 2013, 9:47 a.m., Sebastian Kügler wrote: > > plasma/generic/applets/icon/plugin/icon_p.h, line 31 > > > > > > Why Q_INVOKABLE, and not Q_PROPERTIES here? (For all three accessors). > > That would se

Re: Review Request 112888: Roughly port icon applet to plasma2

2013-09-23 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ --- (Updated Sept. 23, 2013, 12:37 p.m.) Review request for Plasma, Marco Mart

Re: Review Request 112888: Roughly port icon applet to plasma2

2013-09-23 Thread Bhushan Shah
> On Sept. 23, 2013, 9:47 a.m., Sebastian Kügler wrote: > > plasma/generic/applets/icon/plugin/icon_p.h, line 31 > > > > > > Why Q_INVOKABLE, and not Q_PROPERTIES here? (For all three accessors). > > That would se

Re: Review Request 112888: Roughly port icon applet to plasma2

2013-09-23 Thread Sebastian Kügler
> On Sept. 23, 2013, 9:47 a.m., Sebastian Kügler wrote: > > plasma/generic/applets/icon/plugin/icon_p.h, line 31 > > > > > > Why Q_INVOKABLE, and not Q_PROPERTIES here? (For all three accessors). > > That would se

Re: Review Request 112888: Roughly port icon applet to plasma2

2013-09-23 Thread Sebastian Kügler
> On Sept. 23, 2013, 8:30 a.m., Bhushan Shah wrote: > > File Attachment: icons as launcher > > > > > > I am missing glow as of older icons.. how to get it? I think we had custom painting routine for that. This most likely will need to b

Re: Review Request 112888: Roughly port icon applet to plasma2

2013-09-23 Thread Bhushan Shah
> On Sept. 23, 2013, 9:47 a.m., Sebastian Kügler wrote: > > plasma/generic/applets/icon/plugin/icon_p.h, line 31 > > > > > > Why Q_INVOKABLE, and not Q_PROPERTIES here? (For all three accessors). > > That would se

Re: Review Request 112888: Roughly port icon applet to plasma2

2013-09-23 Thread Bhushan Shah
> On Sept. 23, 2013, 9:47 a.m., Sebastian Kügler wrote: > > plasma/generic/applets/icon/plugin/icon_p.cpp, line 76 > > > > > > no new line ?? - Bhushan -

Re: Review Request 112888: Roughly port icon applet to plasma2

2013-09-23 Thread Sebastian Kügler
> On Sept. 23, 2013, 8:28 a.m., Bhushan Shah wrote: > > File Attachment: files > > > > > > Show extension or not? This is a bit of a complicated topic, actually. Quick explanation. Not showing the extension bears some security risk. You

Re: Review Request 112888: Roughly port icon applet to plasma2

2013-09-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/#review40507 --- plasma/generic/applets/icon/package/contents/ui/main.qml

Re: Review Request 112888: Roughly port icon applet to plasma2

2013-09-23 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/#review40500 --- File Attachment: icons as launcher

Re: Review Request 112888: Roughly port icon applet to plasma2

2013-09-23 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/#review40499 --- File Attachment: folders

Re: Review Request 112888: Roughly port icon applet to plasma2

2013-09-23 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/#review40498 --- File Attachment: files

Review Request 112888: Roughly port icon applet to plasma2

2013-09-23 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ --- Review request for Plasma, Marco Martin and Sebastian Kügler. Description