Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Michael Zanetti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113471/#review42503 --- Confirming that this prevents plasma from crashing for me. With

Re: Wrong translation catalog names in kde-workspace/plasma/ master

2013-10-27 Thread Burkhard Lück
Am Sonntag, 27. Oktober 2013, 00:15:26 schrieb David Edmundson: > Both kickoff and analog clock are my fault, thanks for point it out. > Will fix, and the others too. > > To me it would be best if we could mod the Messages.sh to match the > new org.kde.blah names, would that cause translators to r

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Albert Astals Cid
> On Oct. 27, 2013, 11:05 a.m., Christoph Feck wrote: > > Ah, that makes sense, thanks for your investigation! > > > > What could be done to improve it, is to let the timer fire again sometimes > > later, until the item could actually be removed. I am not sure, though, if > > it is needed, in

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Christoph Feck
> On Oct. 27, 2013, 11:05 a.m., Christoph Feck wrote: > > Ah, that makes sense, thanks for your investigation! > > > > What could be done to improve it, is to let the timer fire again sometimes > > later, until the item could actually be removed. I am not sure, though, if > > it is needed, in

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113471/#review42444 --- Ship it! not pretty, but it works. one small code issue below

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Albert Astals Cid
> On Oct. 27, 2013, 11:05 a.m., Christoph Feck wrote: > > Ah, that makes sense, thanks for your investigation! > > > > What could be done to improve it, is to let the timer fire again sometimes > > later, until the item could actually be removed. I am not sure, though, if > > it is needed, in

Re: Review Request 113447: Attempt to unbreak pre-configuring QML applets via desktop scripting, take 2

2013-10-27 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113447/ --- (Updated Oct. 27, 2013, 12:19 p.m.) Review request for kdelibs and Plasma.

Re: Review Request 113447: Attempt to unbreak pre-configuring QML applets via desktop scripting, take 2

2013-10-27 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113447/#review42433 --- Ship it! this is also a pretty bad hack because it will cause

Re: Review Request 113447: Attempt to unbreak pre-configuring QML applets via desktop scripting, take 2

2013-10-27 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113447/ --- (Updated Oct. 27, 2013, 12:19 p.m.) Review request for kdelibs, Plasma, Aa

Re: Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113471/#review42418 --- Ah, that makes sense, thanks for your investigation! What coul

Review Request 113471: Fix crash when removing an item while we are adding one

2013-10-27 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113471/ --- Review request for kde-workspace, Plasma, Àlex Fiestas, and Michael Zanetti.