---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114149/
---
Review request for Plasma.
Repository: plasma-framework
Description
On Nov. 27, 2013, 2:02 p.m., Martin Gräßlin wrote:
src/shell/desktopview.cpp, lines 144-147
http://git.reviewboard.kde.org/r/114149/diff/1/?file=220663#file220663line144
why did you introduce this new slot? It looks to me like you could just
connet to setGeometry directly?
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114152/
---
Review request for Plasma.
Repository: plasma-mediacenter
Description
Plasma applets currently have a property in their metadata.desktop
files X-Plasma-DefaultSize.
Currently this appears to be set by most applets but completely unused
in plasma code except for an autotest.
Given we can determine this from the root item's
implicitWidth/implicitHeight can I remove
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114150/#review44576
---
Ship it!
Ship It!
- David Edmundson
On Nov. 27, 2013,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114152/#review44577
---
Please specify in the description of the patch what it does,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114149/#review44579
---
Ship it!
Tested and confirmed working here.
Once Martin's
On Wednesday, November 27, 2013 15:18:52 David Edmundson wrote:
Plasma applets currently have a property in their metadata.desktop
files X-Plasma-DefaultSize.
Currently this appears to be set by most applets but completely unused
in plasma code except for an autotest.
Given we can
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114152/
---
(Updated Nov. 27, 2013, 3:01 p.m.)
Review request for Plasma.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114150/
---
(Updated Nov. 27, 2013, 3:29 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114150/#review44588
---
This review has been submitted with commit
On Nov. 27, 2013, 3:25 p.m., Sinny Kumari wrote:
Thank you for patch!
Please make changes as Sebastian suggested :)
Other than that, there is one issue with this patch. This patch works fine
in case of All pictures, Flickr and Picasa backend but it maynot work as
expected in case
Thanks, all traces removed now.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Hello!
I think we should add activities button and pager back in panel in
Plasma 2.. I want review on this thing (sebas)..
Here is screen shot of the layout. http://paste.opensuse.org/84348983
However drag and drop to panel from widget explorer is not working; I
have achieved this layout by
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114152/#review44596
---
Ship it!
Ship It!
- Shantanu Tushar
On Nov. 27, 2013, 4:02
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114152/#review44598
---
Ship it!
Looks good to me.
Please push this patch to master
On Wednesday 27 November 2013, David Edmundson wrote:
Plasma applets currently have a property in their metadata.desktop
files X-Plasma-DefaultSize.
Currently this appears to be set by most applets but completely unused
in plasma code except for an autotest.
Given we can determine this
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114152/
---
(Updated Nov. 27, 2013, 5:22 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114152/#review44601
---
This review has been submitted with commit
19 matches
Mail list logo
