Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-13 Thread Shantanu Tushar
On Dec. 13, 2013, 7:53 a.m., Sujith Haridasan wrote: mediaelements/mediawelcome/HomeScreenFooter.qml, line 42 http://git.reviewboard.kde.org/r/114428/diff/2/?file=224654#file224654line42 The PMC time doesn't get synced with desktop time. Can you tune this further to get it

Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints

2013-12-13 Thread Yichao Yu
- Yichao --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114424/#review45626 --- On Dec. 13, 2013, 7:53 a.m., Yichao Yu wrote:

Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints

2013-12-13 Thread Yichao Yu
On Dec. 13, 2013, 2:40 a.m., Martin Gräßlin wrote: This looks like the wrong approach to me. The shadow gets installed by the widget style, but lancelot does not use a normal Qt style, but a Plasma style. Because of that it would need to use the plasma shadow (e.g. panel shadow). The

Re: Review Request 114429: use of time data engine - less code

2013-12-13 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114429/#review45637 --- mediaelements/mediawelcome/CategoriesListDelegate.qml

Re: activities and scripting

2013-12-13 Thread Nowardev-Team
neat. 2013/12/12 Aaron J. Seigo ase...@kde.org: On Monday, December 9, 2013 14:09:40 Nowardev-Team wrote: and when you get the whole desktop filled by the png file you get a wrong resolution in a series of commits today, all the issues noted are resolve in the KDE/4.11 branch of

Re: Review Request 114429: use of time data engine - less code

2013-12-13 Thread Heena Mahour
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114429/ --- (Updated Dec. 13, 2013, 2:11 p.m.) Review request for Plasma, Shantanu

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-13 Thread Heena Mahour
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114428/ --- (Updated Dec. 13, 2013, 2:20 p.m.) Review request for Plasma, Shantanu

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-13 Thread Heena Mahour
On Dec. 13, 2013, 7:53 a.m., Sujith Haridasan wrote: Synced with desktop time now :-) - Heena --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114428/#review45627

Re: Review Request 114429: use of time data engine - less code

2013-12-13 Thread Heena Mahour
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114429/ --- (Updated Dec. 13, 2013, 2:57 p.m.) Review request for Plasma, Shantanu

Re: Review Request 114429: use of time data engine - less code

2013-12-13 Thread Heena Mahour
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114429/ --- (Updated Dec. 13, 2013, 3:01 p.m.) Review request for Plasma, Shantanu

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-13 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114428/#review45662 --- Ship it! Ship It! - Shantanu Tushar On Dec. 13, 2013, 3:05