Re: Solving Bug 311841

2014-02-15 Thread Shantanu Tushar Jha
I think you're looking for this- https://projects.kde.org/projects/kde/kde-workspace/repository/revisions/master/entry/kwin/kcmkwin/kwindecoration/kwindecoration.cpp#L363 Cheers, On Sun, Feb 16, 2014 at 7:54 AM, Avinash Zebisky wrote: > Hi all, > > Am trying to solve this bug[1]. Its fairly si

Solving Bug 311841

2014-02-15 Thread Avinash Zebisky
Hi all, Am trying to solve this bug[1]. Its fairly simple, I only need to add a "Apply" button which will save the changes and make subtle changes in the OK button which will close the KDialog. Then Cancel button which will discard the changes and close the KDialog. (Some background) I have 3yrs

Fwd: Request for review

2014-02-15 Thread Myriam Schweingruber
FYI, I guess the plasma development mailing list is more likely to look at review request for a plasmoid... Regards, Myriam -- Forwarded message -- From: Conny Marco Menebröcker Date: Sat, Feb 15, 2014 at 7:44 PM Subject: Request for review To: kde-de...@kde.org Hello all, I

Re: Review Request 115409: Workaround battery detection at runtime

2014-02-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115409/ --- (Updated Feb. 15, 2014, 10:19 p.m.) Status -- This change has been m

Re: Review Request 115409: Workaround battery detection at runtime

2014-02-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115409/#review49879 --- This review has been submitted with commit edd82448a60c36a66a

Re: Review Request 115409: Workaround battery detection at runtime

2014-02-15 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115409/#review49877 --- Ship it! I've recently debugged a similar issue in Plasma Nex

Review Request 115764: Make playlist model aware of currently playing media

2014-02-15 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115764/ --- Review request for Plasma, Sinny Kumari and Sujith Haridasan. Repository:

Re: Review Request 115409: Workaround battery detection at runtime

2014-02-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115409/ --- (Updated Feb. 15, 2014, 4:58 p.m.) Review request for Plasma, Solid and S

Re: Proposed fix for issue 330115

2014-02-15 Thread Shantanu Tushar Jha
Whats the status on this? If your patch is ready, head over to http://git.reviewboard.kde.org/ and submit a review. On Tue, Feb 4, 2014 at 6:12 PM, sujith h wrote: > > > > On Tue, Feb 4, 2014 at 5:26 PM, R.Harish Navnit wrote: > >> On Mon, Feb 3, 2014 at 11:34 PM, sujith h wrote: >> >>> >>> >>