Review Request 116703: Improve section heading

2014-03-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116703/ --- Review request for kwin, Plasma and Thomas Pfeiffer. Repository: kwin-com

Re: Review Request 116703: Improve section heading

2014-03-11 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116703/#review52618 --- Ship it! Fine from the UI side, I can't say anything about th

Re: Bughunting Season!

2014-03-11 Thread Jos Poortvliet
On Monday 10 March 2014 20:10:48 Sebastian Kügler wrote: > On Monday, March 10, 2014 18:11:28 Thomas Pfeiffer wrote: > > On 09.03.2014 14:13, Luca Beltrame wrote: > > > In data domenica 09 marzo 2014 14:00:25, Sebastian Kügler ha scritto: > > >> We'll also open up for feedback from the community sh

Re: Review Request 116703: Improve section heading

2014-03-11 Thread Christoph Feck
> On March 11, 2014, 8:28 a.m., Thomas Pfeiffer wrote: > > Fine from the UI side, I can't say anything about the code itself It feels a bit odd that the space between the two text lines within each item is larger than the space between two text lines from adjacent items. - Christoph ---

Re: Review Request 116703: Improve section heading

2014-03-11 Thread Martin Gräßlin
> On March 11, 2014, 9:28 a.m., Thomas Pfeiffer wrote: > > Fine from the UI side, I can't say anything about the code itself > > Christoph Feck wrote: > It feels a bit odd that the space between the two text lines within each > item is larger than the space between two text lines from adjac

Shadows on popups before initial rendering

2014-03-11 Thread David Edmundson
There's currently an annoying bug in which when we click on kickoff we see the shadows animate and popup before the contents are ready and it looks awful. I have a branch which fixes this: no_initial_shadows it requires branches in both plasma-framework and kde-workspace. It's a bit hacky, and I'

Re: Review Request 116703: Improve section heading

2014-03-11 Thread Thomas Lübking
> On March 11, 2014, 8:28 a.m., Thomas Pfeiffer wrote: > > Fine from the UI side, I can't say anything about the code itself > > Christoph Feck wrote: > It feels a bit odd that the space between the two text lines within each > item is larger than the space between two text lines from adjac

Re: Bughunting Season!

2014-03-11 Thread Sebastian Kügler
On Tuesday, March 11, 2014 09:41:35 Jos Poortvliet wrote: > On Monday 10 March 2014 20:10:48 Sebastian Kügler wrote: > > On Monday, March 10, 2014 18:11:28 Thomas Pfeiffer wrote: > > > On 09.03.2014 14:13, Luca Beltrame wrote: > > > > > > > > > Great idea! > > > Maybe this would be a good opportun

Re: Shadows on popups before initial rendering

2014-03-11 Thread Marco Martin
On Tuesday 11 March 2014, David Edmundson wrote: > There's currently an annoying bug in which when we click on kickoff we > see the shadows animate and popup before the contents are ready and it > looks awful. > > I have a branch which fixes this: no_initial_shadows > it requires branches in both

Status of splitting the KDE Workspace repository

2014-03-11 Thread Aleix Pol
Dear Plasma, As you might know, I've been looking into figuring out the new architecture of the Plasma software in view of Plasma 2, following the discussions in the last Plasma sprint [1]. So far, I've been looking into both kde-runtime repositories. The biggest problem so far was that somebody w

Re: Shadows on popups before initial rendering

2014-03-11 Thread David Edmundson
well given we don't have wayland next, I opted for RESOLVED D_ED_IS_AWESOME instead. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Shadows on popups before initial rendering

2014-03-11 Thread David Edmundson
*wayland yet. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Status of splitting the KDE Workspace repository

2014-03-11 Thread Marco Martin
On Tuesday 11 March 2014, Aleix Pol wrote: > Dear Plasma, > As you might know, I've been looking into figuring out the new architecture > of the Plasma software in view of Plasma 2, following the discussions in > the last Plasma sprint [1]. cool! only thing... not before the alpha ;) -- Marco Ma

Re: Review Request 116703: Improve section heading

2014-03-11 Thread Martin Gräßlin
> On March 11, 2014, 9:28 a.m., Thomas Pfeiffer wrote: > > Fine from the UI side, I can't say anything about the code itself > > Christoph Feck wrote: > It feels a bit odd that the space between the two text lines within each > item is larger than the space between two text lines from adjac

Re: Shadows on popups before initial rendering

2014-03-11 Thread Marco Martin
On Tuesday 11 March 2014, David Edmundson wrote: > well given we don't have wayland next, I opted for RESOLVED > D_ED_IS_AWESOME instead. the thing iirc is that there is a little perion in which the window does exist already and has the correct geometry, but doesn't have a painted texture yet, t

Re: Review Request 116703: Improve section heading

2014-03-11 Thread Thomas Lübking
> On March 11, 2014, 8:28 a.m., Thomas Pfeiffer wrote: > > Fine from the UI side, I can't say anything about the code itself > > Christoph Feck wrote: > It feels a bit odd that the space between the two text lines within each > item is larger than the space between two text lines from adjac

Re: Shadows on popups before initial rendering

2014-03-11 Thread David Edmundson
I should probably have explained what my patch does in my email. I add an XAtom to Dialog. This Atom is set to true between construction and the first texture being rendered which we can tell from QQuickWindow then it is deleted. Then I patched the slidingPopup effect to look for this atom and su

Re: Review Request 116703: Improve section heading

2014-03-11 Thread Martin Gräßlin
> On March 11, 2014, 9:28 a.m., Thomas Pfeiffer wrote: > > Fine from the UI side, I can't say anything about the code itself > > Christoph Feck wrote: > It feels a bit odd that the space between the two text lines within each > item is larger than the space between two text lines from adjac

Re: Review Request 116703: Improve section heading

2014-03-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116703/#review52635 --- Ship it! Ship It! - David Edmundson On March 11, 2014, 8:0

Re: Review Request 116703: Improve section heading

2014-03-11 Thread Thomas Lübking
> On March 11, 2014, 8:28 a.m., Thomas Pfeiffer wrote: > > Fine from the UI side, I can't say anything about the code itself > > Christoph Feck wrote: > It feels a bit odd that the space between the two text lines within each > item is larger than the space between two text lines from adjac

Re: Re: Shadows on popups before initial rendering

2014-03-11 Thread Martin Gräßlin
On Tuesday 11 March 2014 13:25:00 David Edmundson wrote: > I should probably have explained what my patch does in my email. > > I add an XAtom to Dialog. This Atom is set to true between > construction and the first texture being rendered which we can tell > from QQuickWindow then it is deleted. >

Re: Re: Bughunting Season!

2014-03-11 Thread Martin Gräßlin
On Tuesday 11 March 2014 09:41:35 Jos Poortvliet wrote: > On Monday 10 March 2014 20:10:48 Sebastian Kügler wrote: > > On Monday, March 10, 2014 18:11:28 Thomas Pfeiffer wrote: > > > On 09.03.2014 14:13, Luca Beltrame wrote: > > > > In data domenica 09 marzo 2014 14:00:25, Sebastian Kügler ha scrit

Re: Status of splitting the KDE Workspace repository

2014-03-11 Thread Martin Gräßlin
On Tuesday 11 March 2014 13:09:25 Aleix Pol wrote: > Dear Plasma, > As you might know, I've been looking into figuring out the new architecture > of the Plasma software in view of Plasma 2, following the discussions in > the last Plasma sprint [1]. > > So far, I've been looking into both kde-runti

kglobalaccel fixes

2014-03-11 Thread Sebastian Kügler
A quick heads-up: I'm looking into what's broken in our global shortcuts. Here's a quick run-down of my findings so far: kglobalaccel has some brokenness in it. It used to poke into the privates of KGlobalShortcutInfo in order to create its own object in a cast. This code is disabled right now

Re: Review Request 116703: Improve section heading

2014-03-11 Thread Martin Gräßlin
> On March 11, 2014, 9:28 a.m., Thomas Pfeiffer wrote: > > Fine from the UI side, I can't say anything about the code itself > > Christoph Feck wrote: > It feels a bit odd that the space between the two text lines within each > item is larger than the space between two text lines from adjac

Re: Review Request 116703: Improve section heading

2014-03-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116703/#review52639 --- This review has been submitted with commit 208e514b9e886bec85

Re: Review Request 116703: Improve section heading

2014-03-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116703/ --- (Updated March 11, 2014, 1:03 p.m.) Status -- This change has been m

Re: kglobalaccel fixes

2014-03-11 Thread Martin Gräßlin
On Tuesday 11 March 2014 13:54:56 Sebastian Kügler wrote: > A quick heads-up: I'm looking into what's broken in our global shortcuts. > Here's a quick run-down of my findings so far: > > kglobalaccel has some brokenness in it. It used to poke into the privates of > KGlobalShortcutInfo in order to

Review Request 116712: [kwin] Disconnect lambda connection on destroy of slide effect

2014-03-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116712/ --- Review request for kwin, Plasma and Sebastian Kügler. Repository: kde-wor

Re: Bughunting Season!

2014-03-11 Thread Thomas Pfeiffer
On 11.03.2014 13:37, Martin Gräßlin wrote: On Tuesday 11 March 2014 09:41:35 Jos Poortvliet wrote: On Monday 10 March 2014 20:10:48 Sebastian Kügler wrote: On Monday, March 10, 2014 18:11:28 Thomas Pfeiffer wrote: On 09.03.2014 14:13, Luca Beltrame wrote: In data domenica 09 marzo 2014 14:00:

Re: Bughunting Season!

2014-03-11 Thread Luca Beltrame
In data martedì 11 marzo 2014 14:42:13, Thomas Pfeiffer ha scritto: > Yes, maybe we could try it out in RC and if it works well, have Plasma > be the test pilot from there on. So, should I postpone the forum creation to RC phase, or open it in the alpha anyway? Let me know. -- Luca Beltrame -

Re: Bughunting Season!

2014-03-11 Thread Thomas Pfeiffer
On 11.03.2014 14:49, Luca Beltrame wrote: In data martedì 11 marzo 2014 14:42:13, Thomas Pfeiffer ha scritto: Yes, maybe we could try it out in RC and if it works well, have Plasma be the test pilot from there on. So, should I postpone the forum creation to RC phase, or open it in the alpha a

Re: Bughunting Season!

2014-03-11 Thread Sebastian Kügler
On Tuesday, March 11, 2014 15:00:39 Thomas Pfeiffer wrote: > On 11.03.2014 14:49, Luca Beltrame wrote: > > In data martedì 11 marzo 2014 14:42:13, Thomas Pfeiffer ha scritto: > >> Yes, maybe we could try it out in RC and if it works well, have Plasma > >> be the test pilot from there on. > > > > S

Review Request 116714: Use CMake config file to find dbusmenu-qt5

2014-03-11 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116714/ --- Review request for Plasma. Repository: kde-workspace Description --

Re: Bughunting Season!

2014-03-11 Thread Bhushan Shah
On Tue, Mar 11, 2014 at 7:30 PM, Thomas Pfeiffer wrote: > I think opening a forum for the alpha testers for general coordination and > discussion would be useful anyway, just not for posting bugs/problems at > this stage. For this we have IRC.. :P no seriously IRC works better then forum for this

Re: Bughunting Season!

2014-03-11 Thread Thomas Pfeiffer
On 11.03.2014 15:56, Bhushan Shah wrote: On Tue, Mar 11, 2014 at 7:30 PM, Thomas Pfeiffer wrote: I think opening a forum for the alpha testers for general coordination and discussion would be useful anyway, just not for posting bugs/problems at this stage. For this we have IRC.. :P no serious

Re: Trying out the work-in-progress

2014-03-11 Thread James Cain
Hi Jens! It it worth reporting feedback for using in Plasma Current, or is the only feedback desired to be from using in a Plasma Next environment? I'm forced to use an older computer temporarily, thus could probably only provide thoughts on how the theme looks w/ Qtcurve on Current. Thx. - James

Re: Trying out the work-in-progress

2014-03-11 Thread Jens Reuterberg
I say go for it! (but then I say that to everything :) ) But seriously - yes, you should. It's cool and I think we can all benefit on it. Remember though that it is best to keep the topic to the Plasma Theme and not the Qtcurve one. On Tuesday 11 March 2014 11.10.31 James Cain wrote: > Hi Jens!

Re: Bughunting Season!

2014-03-11 Thread R.Harish Navnit
On Tue, Mar 11, 2014 at 8:37 PM, Thomas Pfeiffer wrote: > > IRC is great for planned discussion meetings or helping one particular > user, but forums have the big advantage that all the outcomes of > discussions are "logged" for everyone to read at any point. This is not the > case for IRC. Develo

Re: Re: Bughunting Season!

2014-03-11 Thread Martin Gräßlin
On Tuesday 11 March 2014 20:26:58 Bhushan Shah wrote: > On Tue, Mar 11, 2014 at 7:30 PM, Thomas Pfeiffer wrote: > > I think opening a forum for the alpha testers for general coordination and > > discussion would be useful anyway, just not for posting bugs/problems at > > this stage. > > For this

Review Request 116722: Allow setTransientParent from an item

2014-03-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116722/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 116722: Allow setTransientParent from an item

2014-03-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116722/#review52650 --- Oddly is exactly the patch that i was trying yesterday ;) one

Re: Review Request 116722: Allow setTransientParent from an item

2014-03-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116722/#review52649 --- Oddly is exactly the patch that i was trying yesterday ;) one

Re: Review Request 116722: Allow setTransientParent from an item

2014-03-11 Thread David Edmundson
> On March 11, 2014, 3:57 p.m., Marco Martin wrote: > > Oddly is exactly the patch that i was trying yesterday ;) > > one thing i found out tough: item->window() of course is not aways there > > (for instance whenthe item is in a Dialog that hasn't been shown yet) > > so in many cases this won't

Re: Review Request 116722: Allow setTransientParent from an item

2014-03-11 Thread Marco Martin
> On March 11, 2014, 3:57 p.m., Marco Martin wrote: > > Oddly is exactly the patch that i was trying yesterday ;) > > one thing i found out tough: item->window() of course is not aways there > > (for instance whenthe item is in a Dialog that hasn't been shown yet) > > so in many cases this won't

Re: Review Request 116722: Allow setTransientParent from an item

2014-03-11 Thread David Edmundson
> On March 11, 2014, 3:57 p.m., Marco Martin wrote: > > Oddly is exactly the patch that i was trying yesterday ;) > > one thing i found out tough: item->window() of course is not aways there > > (for instance whenthe item is in a Dialog that hasn't been shown yet) > > so in many cases this won't

Re: Review Request 116714: Use CMake config file to find dbusmenu-qt5

2014-03-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116714/#review52657 --- Ship it! plasma/generic/dataengines/statusnotifieritem/CMake

Review Request 116731: Bug Fix for Music Stats Labels (Bug 331882)

2014-03-11 Thread Atul Dubey
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116731/ --- Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and

Re: Review Request 116712: [kwin] Disconnect lambda connection on destroy of slide effect

2014-03-11 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116712/#review52665 --- tried passing "this" as context? QMetaObject::Connection QObj

Re: Review Request 116731: Bug Fix for Music Stats Labels (Bug 331882)

2014-03-11 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116731/#review52668 --- Thanks for the patch. However, I am not sure we should have th

Review Request 116736: Bug Fixed - The plasma-media center displays the time in AM between 12 noon and 1pm

2014-03-11 Thread Atul Dubey
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116736/ --- Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and

Re: Review Request 116731: Bug Fix for Music Stats Labels (Bug 331882)

2014-03-11 Thread Atul Dubey
> On March 11, 2014, 5:42 p.m., Shantanu Tushar wrote: > > Thanks for the patch. However, I am not sure we should have these labels > > because of two reasons - > > > > 1. We are already short of real estate on the screen, there is already less > > space left at times to show full names of son

Re: Review Request 116736: Bug Fixed - The plasma-media center displays the time in AM between 12 noon and 1pm

2014-03-11 Thread Ashish Madeti
You should probably revert the lines you changed in MusicStats.qml file, as it may not be related to this particular bug. On Wed, Mar 12, 2014 at 12:44 AM, Atul Dubey wrote: >This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116736/ > Review re

Review Request 116744: Play All Button in Plasma Media Center

2014-03-11 Thread Atul Dubey
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116744/ --- Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and

Re: Review Request 116712: [kwin] Disconnect lambda connection on destroy of slide effect

2014-03-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116712/#review52692 --- Duely noted. Good catch, as well. - Sebastian Kügler On Mar

(GSoC 2014) Plasma Media Center/Integrate with Plasma Next (with additional ideas)

2014-03-11 Thread Алексей Андреев
Hello! My name is Alexey Andreyev, I want to take part at GSoC 2014, if it's not too late. So I want to select a project and write a proporsal and here's my drafts: About me: http://andreyev-kde-notes.blogspot.com/p/about-me.html (in short: first year graduate, very small Qt/QML experience). My pla

Re: Review Request 116736: Bug Fixed - The plasma-media center displays the time in AM between 12 noon and 1pm

2014-03-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116736/#review52694 --- Hey, Thanks for your patch, unfortunately, the changes are wr

Re: Review Request 116712: [kwin] Disconnect lambda connection on destroy of slide effect

2014-03-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116712/ --- (Updated March 12, 2014, 7:43 a.m.) Review request for kwin, Plasma and S