Review Request 117800: Move tests inside libs/mediacenter and make them compile with the library sources instead of linking to libplasmamediacenter

2014-04-27 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117800/ --- Review request for Plasma. Repository: plasma-mediacenter Description

Re: Fwd: KDE Frameworks Release Cycle

2014-04-27 Thread Albert Astals Cid
El Diumenge, 27 d'abril de 2014, a les 15:15:32, David Faure va escriure: FYI. Interesting fact here that original the mail was just sent to k-f-d and k-c-d. I am seeing similar patterns in the plasma land, where they went their own way with the releasing discussion and only sent to this list

Re: Review Request 117800: Move tests inside libs/mediacenter and make them compile with the library sources instead of linking to libplasmamediacenter

2014-04-27 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117800/#review56671 --- libs/mediacenter/CMakeLists.txt

Re: Review Request 117746: Don't make blocking dbus calls from KDED for appmenu.

2014-04-27 Thread Cedric Bellegarde
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117746/#review56673 --- The patch hang when launching kontact: - Kontact freeze -

Review Request 117801: Make PMC MPRIS compatible

2014-04-27 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117801/ --- Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith

Re: Review Request 117801: Make PMC MPRIS compatible

2014-04-27 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117801/ --- (Updated April 27, 2014, 8:03 p.m.) Review request for Plasma, Shantanu

[plasma-framework] /: Install all plasma files in a prefix/share/plasma directory

2014-04-27 Thread Aleix Pol
Git commit e6f1fec0c77ef2bf692fbc382001a9d90971a4d6 by Aleix Pol. Committed on 27/04/2014 at 15:14. Pushed by apol into branch 'master'. Install all plasma files in a prefix/share/plasma directory At the moment, we could say that plasma is co-installable by chance, it's only working because KF5

Re: Review Request 117798: Add a ComboBox to PlasmaComponents

2014-04-27 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117798/#review56683 --- Ship it! cool! I agree about a different file for the style,

Re: Review Request 117798: Add a ComboBox to PlasmaComponents

2014-04-27 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117798/#review56682 --- Ship it! cool! I agree about a different file for the style,

Re: Review Request 117800: Move tests inside libs/mediacenter and make them compile with the library sources instead of linking to libplasmamediacenter

2014-04-27 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117800/ --- (Updated April 27, 2014, 4:08 p.m.) Review request for Plasma. Changes

Re: Review Request 117801: Make PMC MPRIS compatible

2014-04-27 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117801/#review56684 --- libs/mediacenter/CMakeLists.txt

Review Request 117802: Merge ShowDesktop and ShowDashboard plasma addon into one

2014-04-27 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117802/ --- Review request for Plasma, Aleix Pol Gonzalez and Dominik Haumann.

Re: Review Request 117802: Merge ShowDesktop and ShowDashboard plasma applets into one

2014-04-27 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117802/ --- (Updated April 27, 2014, 5:55 p.m.) Review request for Plasma, Aleix Pol

Re: Review Request 117801: Make PMC MPRIS compatible

2014-04-27 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117801/ --- (Updated April 28, 2014, 12:20 a.m.) Review request for Plasma, Shantanu

Re: Review Request 117801: Make PMC MPRIS compatible

2014-04-27 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117801/ --- (Updated April 28, 2014, 12:42 a.m.) Review request for Plasma, Shantanu

Re: Review Request 117802: Merge ShowDesktop and ShowDashboard plasma applets into one

2014-04-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117802/#review56691 --- .gitignore

Re: Review Request 117784: Remove duplicated ConfigLoader

2014-04-27 Thread Martin Klapetek
On April 26, 2014, 3:49 p.m., Marco Martin wrote: did you try a service? here for instance the mpris dataengine doesn't work anymore, i can't send commands like pause/play Speaking with the mpris applet maintainer hat - as it was committed, this^ is not a problem anymore I take? -

Re: Review Request 117784: Remove duplicated ConfigLoader

2014-04-27 Thread Marco Martin
On April 26, 2014, 1:49 p.m., Marco Martin wrote: did you try a service? here for instance the mpris dataengine doesn't work anymore, i can't send commands like pause/play Martin Klapetek wrote: Speaking with the mpris applet maintainer hat - as it was committed, this^ is not a

Review Request 117813: Make the system tray faster

2014-04-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117813/ --- Review request for Plasma. Repository: plasma-workspace Description

Review Request 117814: Make examples optional (default to off)

2014-04-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117814/ --- Review request for Plasma. Repository: plasma-framework Description