Re: RFC - Removing System Bell KCM

2014-05-11 Thread Martin Gräßlin
On Monday 12 May 2014 00:26:10 David Edmundson wrote: > What does it do: > - calls XChangeKeyboardControl to set the length/pitch or the beep on > the internal beep of old PCs. > > Who calls uses this bell: > - the KCM to configure the bell.. and that's it from within KDE > > No one other KDE a

Review Request 118092: Left and right movement in All music

2014-05-11 Thread Sujith Haridasan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118092/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs: 334148

Re: Review Request 118061: Plasma-mobile: Add an initial shell package

2014-05-11 Thread Aleix Pol Gonzalez
> On May 10, 2014, 12:15 a.m., Aleix Pol Gonzalez wrote: > > Wouldn't it be better to let the Desktop settle down a bit before we start > > to fork things out? Actually we should find ways to share code and not > > having to actually fork these, which is really counter-productive. > > Marco Ma

Re: Review Request 118061: Plasma-mobile: Add an initial shell package

2014-05-11 Thread Aleix Pol Gonzalez
> On May 10, 2014, 12:15 a.m., Aleix Pol Gonzalez wrote: > > Wouldn't it be better to let the Desktop settle down a bit before we start > > to fork things out? Actually we should find ways to share code and not > > having to actually fork these, which is really counter-productive. > > Marco Ma

Re: Review Request 118063: New Formats KCM

2014-05-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118063/ --- (Updated May 12, 2014, 2:34 a.m.) Review request for Plasma and John Layt

Re: Review Request 118063: New Formats KCM

2014-05-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118063/ --- (Updated May 12, 2014, 2:18 a.m.) Review request for Plasma and John Layt

Re: Review Request 118063: New Formats KCM

2014-05-11 Thread Sebastian Kügler
> On May 11, 2014, 5:59 p.m., John Layt wrote: > > kcms/formats/formats.desktop, line 19 > > > > > > accessibility? That's the same as for the locale category. I think this category in the .desktop file only mat

Review Request 118089: Fix build: add spaces in string concatenation

2014-05-11 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118089/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 118063: New Formats KCM

2014-05-11 Thread Sebastian Kügler
> On May 9, 2014, 4:43 p.m., David Edmundson wrote: > > kcms/formats/kcmformats.cpp, line 184 > > > > > > I assume you mean kcmshell ? > > If so please file a bug. This is quite critical. Filed https://bugs.

RFC - Removing System Bell KCM

2014-05-11 Thread David Edmundson
What does it do: - calls XChangeKeyboardControl to set the length/pitch or the beep on the internal beep of old PCs. Who calls uses this bell: - the KCM to configure the bell.. and that's it from within KDE No one other KDE app explicitly loads kcmbellrc or calls XBell. So we have a KCM for con

Re: Review Request 118063: New Formats KCM

2014-05-11 Thread John Layt
> On May 10, 2014, 9:52 p.m., Martin Klapetek wrote: > > File Attachment: new Formats KCM in kcmshell5 - formatskcm.png > > > > > > Shouldn't this be "Country" rather than Region? > > John Layt wrote: > I'd stick with Region, the lo

Re: Review Request 118063: New Formats KCM

2014-05-11 Thread John Layt
> On May 10, 2014, 9:52 p.m., Martin Klapetek wrote: > > File Attachment: new Formats KCM in kcmshell5 - formatskcm.png > > > > > > Shouldn't this be "Country" rather than Region? I'd stick with Region, the locale is a combination of co

Re: Review Request 118063: New Formats KCM

2014-05-11 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118063/#review57729 --- Mostly looks good, a few obviously issues, but once it's in I

Re: Review Request 118063: New Formats KCM

2014-05-11 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118063/#review57726 --- kcms/formats/formats.desktop

Re: Just a screenshot of Plasma Next so far

2014-05-11 Thread Hans Chen
On Sat, May 10, 2014 at 9:03 PM, Mark Gaiser wrote: > Would it be possible to make that a bit more subtje? Right now easily > notice the blue border while it serves no real function. Sure, it > tells me that the white rectangle has focus, but that is only valuable > information if you can have mu