Review Request 118342: [klipper] Port to new KAboutData

2014-05-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118342/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Review Request 118341: [klipper] Port from KCmdLineArgs to QCommandLineParser

2014-05-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118341/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 118330: [klipper] Port from KUniqueApplication to QApplication + KDBusService

2014-05-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118330/#review58536 --- This review has been submitted with commit 1332cb33cbbef20cfd

Re: Review Request 118330: [klipper] Port from KUniqueApplication to QApplication + KDBusService

2014-05-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118330/ --- (Updated May 27, 2014, 5:36 a.m.) Status -- This change has been mar

Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

2014-05-26 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/ --- Review request for KDE Frameworks, Plasma and Ivan Čukić. Repository: kac

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread Sebastian Kügler
> On May 26, 2014, 11:34 p.m., Christoph Feck wrote: > > kcms/hardware/display/display.desktop, line 100 > > > > > > & Initially forgot this one. I've fixed it locally already. Won't update the patch here just

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118290/ --- (Updated May 27, 2014, 12:03 a.m.) Review request for Localization and Tr

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118290/#review58531 --- kcms/hardware/display/display.desktop

Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

2014-05-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118337/ --- Review request for Plasma, Hugo Pereira Da Costa and Thomas Pfeiffer. Rep

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread Heiko Tietze
> On May 26, 2014, 10:38 a.m., Christoph Feck wrote: > > kcms/dateandtime/clock.desktop, line 107 > > > > > > Is there a guideline for using the '&' character vs. "and"? I suggest > > to always use the word (whi

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118290/ --- (Updated May 26, 2014, 10:52 p.m.) Review request for Plasma and KDE Usab

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread Sebastian Kügler
> On May 26, 2014, 10:38 a.m., Christoph Feck wrote: > > kcms/formats/formats.desktop, line 27 > > > > > > Missing comma before the "and". No comma there, the and replaces it. > On May 26, 2014, 10:38 a.m., Chr

Re: Plasma Addons

2014-05-26 Thread Luca Beltrame
In data domenica 25 maggio 2014 14:46:46, Sebastian Kügler ha scritto: > - Ask to not report bugs against it I've updated the sticky post in the KDE Community Forums: http://forum.kde.org/viewtopic.php?f=287&t=120430 I've also pointed people from the openSUSE community to this thread. Let me k

Re: Plasma Addons

2014-05-26 Thread Thomas Pfeiffer
On Monday 26 May 2014 11:00:32 Martin Gräßlin wrote: > that was also not my intention. Still we need to rethink how to handle the > addons. We accepted that the addons became a dumping ground for 3rd party > plasmoids which then went into unmaintained state. That is something we need > to address.

Re: Minutes Monday Plasma hangout

2014-05-26 Thread Marco Martin
On Monday 26 May 2014, Sebastian Kügler wrote: > Minutes 26-06-2014 > > Present: Aleix, Antonis, David, Jens, Marco, Martin G., Martin K., > Sebastian > > Aleix: > - Investigated Plasma startup performance: What can we do better? For svgs, There were several problem in different places that caus

Re: Minutes Monday Plasma hangout

2014-05-26 Thread Ivan Čukić
On Monday 26 May 2014 13:05:20 Sebastian Kügler wrote: > Minutes 26-06-2014 > > Present: Aleix, Antonis, David, Jens, Marco, Martin G., Martin K., Sebastian Ivan: - Finishing up the resources model. - Little refactoring - Playing around with favourites and task pinning. It will be uglier than or

Re: Plasma Package -> Application Extension Framework?

2014-05-26 Thread Kevin Krammer
On Monday, 2014-05-26, 10:58:06, Marco Martin wrote: > On Saturday 24 May 2014, Kevin Krammer wrote: > > Since I remembered reading about some form of packaging being developed > > for > > Plasma years ago I went to TechBase and read up a bit on Plasma Package. > > > > What are your opinions on h

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread David Edmundson
> On May 26, 2014, 10:38 a.m., Christoph Feck wrote: > > kcms/colors/colors.desktop, line 106 > > > > > > I am not native english, but I think "Application's Color Scheme" is > > correct. Application's color sc

Re: High DPI issues

2014-05-26 Thread Teo Mrnjavac
On Monday, May 26, 2014 17:06:12 Sebastian Kügler wrote: > On Monday, May 26, 2014 16:55:42 Teo Mrnjavac wrote: > > > Now, the most important difference to the approach I've seen in Qt, is > > > that > > > this is a QML binding in our case instead of a scaling factor which you > > > inject in the r

Re: High DPI issues

2014-05-26 Thread Teo Mrnjavac
On Tuesday, May 20, 2014 15:16:25 Teo Mrnjavac wrote: > On Tuesday, May 20, 2014 14:55:16 David Edmundson wrote: > > On Tue, May 20, 2014 at 2:28 PM, Teo Mrnjavac wrote: > > > Another important issue is that currently the only tested and nicely > > > working values for QT_HIGHDPI_SCALE_FACTOR are

Re: High DPI issues

2014-05-26 Thread Marco Martin
On Monday 26 May 2014, David Edmundson wrote: > > Note that they actually got this wrong: They're not using a binding but > > an invokable, meaning that gridUnit changes aren't propagated > > automatically, but need to be triggered for re-evaluation. This looks > > like an API problem to me, so it

Re: High DPI issues

2014-05-26 Thread David Edmundson
On Mon, May 26, 2014 at 5:06 PM, Sebastian Kügler wrote: > On Monday, May 26, 2014 16:55:42 Teo Mrnjavac wrote: >> > Now, the most important difference to the approach I've seen in Qt, is >> > that >> > this is a QML binding in our case instead of a scaling factor which you >> > inject in the rend

Re: High DPI issues

2014-05-26 Thread Sebastian Kügler
On Monday, May 26, 2014 16:55:42 Teo Mrnjavac wrote: > > Now, the most important difference to the approach I've seen in Qt, is > > that > > this is a QML binding in our case instead of a scaling factor which you > > inject in the rendering engine. This means, we can change those not only > > on >

Re: High DPI issues

2014-05-26 Thread Teo Mrnjavac
On Tuesday, May 20, 2014 15:16:25 Teo Mrnjavac wrote: > On Tuesday, May 20, 2014 14:55:16 David Edmundson wrote: > > On Tue, May 20, 2014 at 2:28 PM, Teo Mrnjavac wrote: > > > Hello, > > > > > > I've had a chat with Morten Johan Sørvig, the person behind the high DPI > > > effort in Qt. What foll

Re: Notification bloat (4.xx)

2014-05-26 Thread Thomas Pfeiffer
On 24.05.2014 02:54, Celeste Lyn Paul wrote: There definitely needs to be better logic when it comes to showing certain types of notifications. One of KDE's strengths is that all notifications are channeled through the same system, and so KDE can control the behavior of all notification interrupt

Re: Review Request 118328: Add the current month name to the calendar component by default

2014-05-26 Thread Martin Klapetek
> On May 26, 2014, 4:43 p.m., Alexander Potashev wrote: > > src/declarativeimports/calendar/qml/MonthView.qml, line 106 > > > > > > Isn't adding of a fixed string (", ") a word puzzle? > > > > > > http:

Re: Review Request 118328: Add the current month name to the calendar component by default

2014-05-26 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118328/#review58488 --- src/declarativeimports/calendar/qml/MonthView.qml

Re: Review Request 118330: [klipper] Port from KUniqueApplication to QApplication + KDBusService

2014-05-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118330/#review58487 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 26, 2014, 1:

Re: Review Request 118330: [klipper] Port from KUniqueApplication to QApplication + KDBusService

2014-05-26 Thread Aleix Pol Gonzalez
> On May 26, 2014, 2:04 p.m., Aleix Pol Gonzalez wrote: > > klipper/main.cpp, line 43 > > > > > > All these ugly calls are not needed if you use > > KAbout::setApplicationData(Klipper::aboutData), provided you po

Re: Review Request 118328: Add the current month name to the calendar component by default

2014-05-26 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118328/ --- (Updated May 26, 2014, 2:25 p.m.) Status -- This change has been mar

Re: Review Request 118328: Add the current month name to the calendar component by default

2014-05-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118328/#review58485 --- This review has been submitted with commit 12811f1fc4b7b3eec6

Re: Review Request 118330: [klipper] Port from KUniqueApplication to QApplication + KDBusService

2014-05-26 Thread Martin Gräßlin
> On May 26, 2014, 4:04 p.m., Aleix Pol Gonzalez wrote: > > klipper/main.cpp, line 43 > > > > > > All these ugly calls are not needed if you use > > KAbout::setApplicationData(Klipper::aboutData), provided you po

Re: Review Request 118330: [klipper] Port from KUniqueApplication to QApplication + KDBusService

2014-05-26 Thread Martin Gräßlin
> On May 26, 2014, 4:04 p.m., Aleix Pol Gonzalez wrote: > > klipper/main.cpp, line 43 > > > > > > All these ugly calls are not needed if you use > > KAbout::setApplicationData(Klipper::aboutData), provided you po

Re: Review Request 118328: Add the current month name to the calendar component by default

2014-05-26 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118328/#review58480 --- Ship it! Ship It! - Sebastian Kügler On May 26, 2014, 12:2

Jenkins build is back to normal : plasma-workspace_master_qt5 #280

2014-05-26 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118330: [klipper] Port from KUniqueApplication to QApplication + KDBusService

2014-05-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118330/#review58479 --- klipper/main.cpp

Re: Review Request 118328: Add the current month name to the calendar component by default

2014-05-26 Thread Martin Klapetek
> On May 26, 2014, 3:51 p.m., Sebastian Kügler wrote: > > For graphical changes, please add screenshots. It just moves the header from the plasmoid to the component, it looks the same but it's now available *in* the component as opposed to the applets using those components. - Martin -

Review Request 118330: [klipper] Port from KUniqueApplication to QApplication + KDBusService

2014-05-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118330/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 118327: [klipper] Use same version number as plasma workspace in general

2014-05-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118327/#review58477 --- This review has been submitted with commit d1f3192f1e254bae58

Re: Review Request 118327: [klipper] Use same version number as plasma workspace in general

2014-05-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118327/ --- (Updated May 26, 2014, 1:55 p.m.) Status -- This change has been mar

Re: Review Request 118326: [klipper] Introduce a config-klipper.h

2014-05-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118326/ --- (Updated May 26, 2014, 1:52 p.m.) Status -- This change has been mar

Re: Review Request 118326: [klipper] Introduce a config-klipper.h

2014-05-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118326/#review58476 --- This review has been submitted with commit c1e4dfb9c248c16245

Re: Review Request 118328: Add the current month name to the calendar component by default

2014-05-26 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118328/#review58475 --- For graphical changes, please add screenshots. - Sebastian Kü

Re: Review Request 118327: [klipper] Use same version number as plasma workspace in general

2014-05-26 Thread Martin Gräßlin
> On May 26, 2014, 2:58 p.m., David Edmundson wrote: > > klipper/CMakeLists.txt, line 1 > > > > > > Noob question. Where is this defined? toplevel CMakeLists.txt > On May 26, 2014, 2:58 p.m., David Edmundson wro

Re: Review Request 118326: [klipper] Introduce a config-klipper.h

2014-05-26 Thread Martin Gräßlin
> On May 26, 2014, 2:55 p.m., David Edmundson wrote: > > klipper/config-klipper.h.cmake, line 1 > > > > > > you shouldn't need the 1 here. > > > > oh really? Good to know, then KWin has always been wrong ;-)

Re: Review Request 118327: [klipper] Use same version number as plasma workspace in general

2014-05-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118327/#review58470 --- Ship it! Confirm you've tested the output please before shipp

Re: Review Request 118326: [klipper] Introduce a config-klipper.h

2014-05-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118326/#review58469 --- Ship it! klipper/config-klipper.h.cmake

Review Request 118328: Add the current month name to the calendar component by default

2014-05-26 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118328/ --- Review request for Plasma. Repository: plasma-framework Description ---

Review Request 118327: [klipper] Use same version number as plasma workspace in general

2014-05-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118327/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Review Request 118326: [klipper] Introduce a config-klipper.h

2014-05-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118326/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 118214: [screenlocker] Pass grace time as command line argument to greeter

2014-05-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118214/ --- (Updated May 26, 2014, 11:47 a.m.) Status -- This change has been ma

Re: Review Request 118214: [screenlocker] Pass grace time as command line argument to greeter

2014-05-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118214/#review58466 --- This review has been submitted with commit 976650914b3e12ebc6

Re: Review Request 118278: [2/2] Make sure we update the calendar on date change

2014-05-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118278/#review58465 --- This review has been submitted with commit a5a2df7ce8e0fe7e8b

Re: Review Request 118278: [2/2] Make sure we update the calendar on date change

2014-05-26 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118278/ --- (Updated May 26, 2014, 11:42 a.m.) Status -- This change has been ma

Re: Review Request 118277: [1/2] Make sure we update the calendar on date change

2014-05-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118277/#review58464 --- This review has been submitted with commit 9f0765b002314055aa

Re: Review Request 118277: [1/2] Make sure we update the calendar on date change

2014-05-26 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118277/ --- (Updated May 26, 2014, 11:40 a.m.) Status -- This change has been ma

Re: Review Request 118258: [klipper] Always show filter widget in klipperpopup

2014-05-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118258/ --- (Updated May 26, 2014, 11:34 a.m.) Status -- This change has been ma

Re: Review Request 118258: [klipper] Always show filter widget in klipperpopup

2014-05-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118258/#review58463 --- This review has been submitted with commit e8657c80b24db03a6b

Re: Review Request 118214: [screenlocker] Pass grace time as command line argument to greeter

2014-05-26 Thread Martin Gräßlin
> On May 26, 2014, 12:38 p.m., David Edmundson wrote: > > ksmserver/screenlocker/ksldapp.cpp, line 348 > > > > > > IMHO --nolock would be clearer than --endlessGrace. > > > > Your choice. I agree, noloc

Re: Oxygen font, underline looks odd

2014-05-26 Thread Mark Gaiser
On Mon, May 26, 2014 at 11:42 AM, David Edmundson wrote: > https://bugs.kde.org/show_bug.cgi?id=332059 > > It's weird. Oxygen hasn't changed, and QStyle doesn't seem to have > changed any relevant part either. Is that this bug i'm seeing? What i see in the attachment there is totally weird underl

Minutes Monday Plasma hangout

2014-05-26 Thread Sebastian Kügler
Minutes 26-06-2014 Present: Aleix, Antonis, David, Jens, Marco, Martin G., Martin K., Sebastian Aleix: - Investigated Plasma startup performance: What can we do better? Antonis: - Plasma Active shell porting: - shellpackage support in urlintercepter David Edmundson: - Merged some SDDM patch

Re: Review Request 118258: [klipper] Always show filter widget in klipperpopup

2014-05-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118258/#review58459 --- Ship it! Ship It! - David Edmundson On May 22, 2014, 1:17

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118290/#review58456 --- kcms/colors/colors.desktop

Re: Review Request 118214: [screenlocker] Pass grace time as command line argument to greeter

2014-05-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118214/#review58194 --- ksmserver/screenlocker/ksldapp.cpp

Re: Review Request 118214: [screenlocker] Pass grace time as command line argument to greeter

2014-05-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118214/#review58457 --- Ship it! Ship It! - David Edmundson On May 20, 2014, 10:12

Re: Oxygen font, underline looks odd

2014-05-26 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=332059 It's weird. Oxygen hasn't changed, and QStyle doesn't seem to have changed any relevant part either. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: Plasma Addons

2014-05-26 Thread Martin Gräßlin
On Monday 26 May 2014 10:49:11 David Edmundson wrote: > On Mon, May 26, 2014 at 4:37 AM, Aleix Pol wrote: > > On Sat, May 24, 2014 at 12:23 AM, David Edmundson > > > > wrote: > >> Hey, > >> > >> we've started to get bug reports on plasma-addons. It appears they're > >> distributed as part of Op

Re: Plasma Package -> Application Extension Framework?

2014-05-26 Thread Marco Martin
On Saturday 24 May 2014, Kevin Krammer wrote: > Hi folks, > > first please apologize if this is already under way or done and I am just > not up to date enough :-) > > Basically I was thinking about application scripting, allowing power users, > sysadmins, etc. to control or extend applications t

Re: Plasma Addons

2014-05-26 Thread Aleix Pol
On Mon, May 26, 2014 at 10:33 AM, Marco Martin wrote: > On Monday 26 May 2014, Aleix Pol wrote: > > > Hi, > > Having a separate bugzilla component is obviously good as well as not > > having them released makes total sense. I would add also that some will > be > > deeply missed like pastebin plas

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118290/ --- (Updated May 26, 2014, 8:49 a.m.) Review request for Plasma and KDE Usabi

Re: Plasma Addons

2014-05-26 Thread David Edmundson
On Mon, May 26, 2014 at 4:37 AM, Aleix Pol wrote: > On Sat, May 24, 2014 at 12:23 AM, David Edmundson > wrote: >> >> Hey, >> >> we've started to get bug reports on plasma-addons. It appears they're >> distributed as part of OpenSuse RPMs. >> >> Can I confirm our position on what we're doing here,

Re: Plasma Addons

2014-05-26 Thread Marco Martin
On Sunday 25 May 2014, Sebastian Kügler wrote: > On Saturday, May 24, 2014 15:13:19 Luca Beltrame wrote: > > In data sabato 24 maggio 2014 14:54:02, Sebastian Kügler ha scritto: > > > +1 on all of the above. kdeplasma-addons is outside of our scope. > > > > Should distros tell reporters not to rep

Re: Plasma Package -> Application Extension Framework?

2014-05-26 Thread David Edmundson
> Are there any Plasma specific dependencies in the current code? Not really. In terms of dependencies, it's pretty much: KArchive KService KI8n (could be dropped) David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/li

Re: Plasma Addons

2014-05-26 Thread Marco Martin
On Monday 26 May 2014, Aleix Pol wrote: > Hi, > Having a separate bugzilla component is obviously good as well as not > having them released makes total sense. I would add also that some will be > deeply missed like pastebin plasmoid or icon tasks but that's just how > things are. Sadly enough, Qu