Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118584/ --- (Updated June 6, 2014, 6:45 a.m.) Review request for Plasma, John Layt an

Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118584/ --- Review request for Plasma, John Layt and Sebastian Kügler. Repository: pl

Review Request 118583: Fix Comic Strip Installation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118583/ --- Review request for Plasma. Bugs: 325028 http://bugs.kde.org/show_bug.

Re: Review Request 118574: Adjust componentchooser for renamed KWin binary

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118574/#review59371 --- Ship it! Ship It! - Martin Gräßlin On June 5, 2014, 9:17 p

Re: Review Request 118548: Port libtaskmanager away from QDesktopWidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118548/#review59370 --- > It fudges window geometry by removing 5 pixels from each sid

Re: Review Request 118573: Some tweaks in the logout screen

> On June 6, 2014, 12:23 a.m., Aleix Pol Gonzalez wrote: > > ksmserver/shutdowndlg.cpp, line 85 > > > > > > I'm unsure what's the issue here. this might break the logout effect - Martin --

Re: Re: Plasma 5 Beta 2 tars

On Thursday 05 June 2014 20:19:55 šumski wrote: > On Thursday 05 of June 2014 16:47:59 Jonathan Riddell wrote: > > Tars are up for Plasma 5 Beta 2, please try them out and let me know > > of problems. I'd especially like to know if translations successfully > > install as I noticed some not doing

Review Request 118581: Consider Super_L and Super_R as modifiers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118581/ --- Review request for KDE Frameworks, Plasma and Vishesh Handa. Bugs: 335316

Re: Review Request 118573: Some tweaks in the logout screen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118573/#review59363 --- ksmserver/shutdowndlg.cpp

Re: Icons status

> Oxygen, that as fallback is the most complete. > Both themes would be installed, and oxygen would still be the fallback when > an icon is not found for the time being +1 for the oxygen + toolbars breeze Cheerio, Ivan KDE, ivan.cukic at kde.org, http://ivan.fomentgroup.org/ gpg key id: 850B6

Re: Icons status

On Thursday 05 June 2014, Andrew Lake wrote: > On Thu, Jun 5, 2014 at 12:22 PM, Marco Martin wrote: > > Hi all, > > Just relying a message from Uri, > > toolbars and folders are almost complete, but all devices and mimetypes > > are still missing, so a little opinion poll is needed. > > > > I thin

Re: Icons status

On Thu, Jun 5, 2014 at 12:22 PM, Marco Martin wrote: > Hi all, > Just relying a message from Uri, > toolbars and folders are almost complete, but all devices and mimetypes are > still missing, so a little opinion poll is needed. > > I think that they should be shipped anyways, but default yes/no ?

Icons status

Hi all, Just relying a message from Uri, toolbars and folders are almost complete, but all devices and mimetypes are still missing, so a little opinion poll is needed. I think that they should be shipped anyways, but default yes/no ? Cheers, Marco Martin _

Review Request 118574: Adjust componentchooser for renamed KWin binary

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118574/ --- Review request for Plasma and Martin Gräßlin. Repository: plasma-desktop

Re: Visual design for logout/login/lockscreen

On Thursday 05 June 2014, David Edmundson wrote: > > > > mutually exclusive buttons on one side looks maybe a bit "heavier" but > > perhaps seems a bit more intuitive. > > That works for me. > I'll update login next week. I did a review request https://git.reviewboard.kde.org/r/118573/ so it ca

Review Request 118573: Some tweaks in the logout screen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118573/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Visual design for logout/login/lockscreen

On Thu, Jun 5, 2014 at 10:30 AM, Marco Martin wrote: > * don't bother wit the background, I think on top of the fullscreen > blur/darken effect is fine (in this case even better than a background that > covers everything) > Yes, I agree, that was the intention in the proposed visual design (and i

Re: Visual design for logout/login/lockscreen

On Thursday 05 June 2014, David Edmundson wrote: > > * I think is just fine using the default theme and swapping textcolors > > and backgroundcolors for the rectangles: to me it looks way better if > > even if is dark, the two buttons still look light/default > > Toolbuttons were the big problem w

Re: Visual design for logout/login/lockscreen

On Thu, Jun 5, 2014 at 8:13 PM, Marco Martin wrote: > On Thursday 05 June 2014, David Edmundson wrote: >> > * I think is just fine using the default theme and swapping textcolors >> > and backgroundcolors for the rectangles: to me it looks way better if >> > even if is dark, the two buttons still

Re: Visual design for logout/login/lockscreen

On Thursday 05 June 2014, Marco Martin wrote: > > I tried it, I think it's fine, I have just few observations/suggestions: > * seems that sometimes the window (main qml view) is not correctly resized. > Oddly tough the test program always resizes/places the window correctly the resize issue seem

Re: Plasma 5 Beta 2 tars

On Thursday 05 of June 2014 16:47:59 Jonathan Riddell wrote: > Tars are up for Plasma 5 Beta 2, please try them out and let me know > of problems. I'd especially like to know if translations successfully > install as I noticed some not doing so last time. Plasma-workspace doesn't build. It is adju

Re: Review Request 118548: Port libtaskmanager away from QDesktopWidget

In data giovedì 05 giugno 2014 00:35:56, Aleix Pol Gonzalez ha scritto: > This patch uses the screen geometry to figure out what's the screen and then > passes around the screen rect so that we can filter out the screens that I have tested it and unfortunately it doesn't really work: now tasks ar

Re: Visual design for logout/login/lockscreen

On Thursday 05 June 2014, David Edmundson wrote: > > * I think is just fine using the default theme and swapping textcolors > > and backgroundcolors for the rectangles: to me it looks way better if > > even if is dark, the two buttons still look light/default > > Toolbuttons were the big problem w

Re: Visual design for logout/login/lockscreen

> * I think is just fine using the default theme and swapping textcolors and > backgroundcolors for the rectangles: to me it looks way better if even if is > dark, the two buttons still look light/default Toolbuttons were the big problem with just hardcoding colours for text and background - if

Re: Visual design for logout/login/lockscreen

On Thursday 05 June 2014, Aleix Pol wrote: > Hi, > I've been trying to sort these out during this week, together with David. > I've pushed a new Lock and Logout implementations following these mockups. > They don't look like that yet but it's quite close and workable. The main > issue > being that

Jenkins build is back to stable : plasma-workspace_master_qt5 #365

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build became unstable: plasma-workspace_master_qt5 #364

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118548: Port libtaskmanager away from QDesktopWidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118548/ --- (Updated June 5, 2014, 5:12 p.m.) Status -- This change has been mar

Re: Review Request 118548: Port libtaskmanager away from QDesktopWidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118548/#review59351 --- This review has been submitted with commit 1f5225d4405df26732

Re: Visual design for logout/login/lockscreen

On Thu, Jun 5, 2014 at 9:47 AM, Aleix Pol wrote: > On Sat, Apr 5, 2014 at 12:32 AM, Andrew Lake wrote: > >> Hello, >> >> After reading Aaron's nearly year old blog entry again this week ( >> http://aseigo.blogspot.de/2013/05/visual-harmony-in-plasma-workspaces-2.html) >> , especially the followi

Re: Visual design for logout/login/lockscreen

On Thursday 05 June 2014, Aleix Pol wrote: > Hi, > I've been trying to sort these out during this week, together with David. > I've pushed a new Lock and Logout implementations following these mockups. > They don't look like that yet but it's quite close and workable. The main > issue > being that

Re: Review Request 118548: Port libtaskmanager away from QDesktopWidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118548/ --- (Updated June 5, 2014, 4:57 p.m.) Review request for Plasma, Martin Gräßl

Re: Review Request 118548: Port libtaskmanager away from QDesktopWidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118548/#review59350 --- Ship it! Looks good. - Eike Hein On June 5, 2014, 12:35 a.

Re: Visual design for logout/login/lockscreen

On Sat, Apr 5, 2014 at 12:32 AM, Andrew Lake wrote: > Hello, > > After reading Aaron's nearly year old blog entry again this week ( > http://aseigo.blogspot.de/2013/05/visual-harmony-in-plasma-workspaces-2.html) > , especially the following quote: > > > ...the log out dialog still has things that

Re: Plasma 5 Beta 2 tars

On June 5, 2014 03:47:59 PM Jonathan Riddell wrote: > Tars are up for Plasma 5 Beta 2, please try them out and let me know > of problems. > > I've renamed baloo and milou to have -kf5 in the tar name as you may > well want the kdelibs4 versions around. Also kfilemetadata as > kfilemetadata5. Rega

Plasma 5 Beta 2 tars

Tars are up for Plasma 5 Beta 2, please try them out and let me know of problems. I'd especially like to know if translations successfully install as I noticed some not doing so last time. Appearing here soon http://download.kde.org/unstable/plasma/4.97.0/src/ Temporarily here in the mean time

Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.

> On June 5, 2014, 8:36 a.m., Thomas Pfeiffer wrote: > > Usability review: > > Since I lack the skills to picture it from the diff: When exactly is the > > notification shown? Is it shown as soon as the media is supposed to be > > played? If so, I think it could be done in a more subtle way: Gr

Re: Review Request 117433: [applets/notifications] Use ::hide() instead of ::close()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117433/ --- (Updated June 5, 2014, 2:25 p.m.) Status -- This change has been dis

Re: Review Request 118557: Port PlasmaFramework to i18nd + Add test checking for i18n use

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118557/#review59317 --- This review has been submitted with commit 73bb587ee95a311741

Re: Review Request 118557: Port PlasmaFramework to i18nd + Add test checking for i18n use

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118557/ --- (Updated June 5, 2014, 11:20 a.m.) Status -- This change has been ma

Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.

> On June 5, 2014, 8:36 a.m., Thomas Pfeiffer wrote: > > Usability review: > > Since I lack the skills to picture it from the diff: When exactly is the > > notification shown? Is it shown as soon as the media is supposed to be > > played? If so, I think it could be done in a more subtle way: Gr

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118526/ --- (Updated June 5, 2014, 10:59 a.m.) Status -- This change has been ma

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118526/#review59313 --- This review has been submitted with commit 90c9c6563dbc7e6ad5

Jenkins build is back to normal : plasma-workspace_master_qt5 #356

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated June 5, 2014, 10:32 a.m.) Review request for kde-workspace and P

Build failed in Jenkins: plasma-workspace_master_qt5 #355

See Changes: [aleixpol] Remove unused headers [aleixpol] Fix Plasma build with Review 117339 [aleixpol] Adapt to changes in KCoreAddons.Formats -- [...truncated 2115 lines...] [ 59%] Buil

Re: Review Request 118558: Fix Plasma build with Review 117339

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118558/ --- (Updated June 5, 2014, 10:24 a.m.) Status -- This change has been ma

Re: Review Request 118558: Fix Plasma build with Review 117339

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118558/#review59305 --- This review has been submitted with commit 45254e4d0aa0af4e9d

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118526/#review59303 --- Ship it! Ship it 2.0 - Marco Martin On June 5, 2014, 10:03

Re: Review Request 118558: Fix Plasma build with Review 117339

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118558/#review59302 --- Ship it! Ship It! - Marco Martin On June 5, 2014, 10:01 a.

Re: Review Request 118557: Port PlasmaFramework to i18nd + Add test checking for i18n use

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118557/#review59301 --- Ship it! Ship It! - Marco Martin On June 5, 2014, 10:12 a.

Review Request 118557: Port PlasmaFramework to i18nd + Add test checking for i18n use

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118557/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118526/ --- (Updated June 5, 2014, 12:03 p.m.) Review request for KDE Frameworks, Pla

Review Request 118558: Fix Plasma build with Review 117339

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118558/ --- Review request for Plasma and Aleix Pol Gonzalez. Repository: plasma-work

Re: Review Request 118482: Adjust ksmserver for renamed KWin binary

> On June 4, 2014, 9:04 a.m., Martin Gräßlin wrote: > > looks good to me. Where is the KCM living where one can select the window > > manager? > > Hrvoje Senjan wrote: > it is in plasma-desktop repo. but i did not want to add a patch for > something that does not build ;-) > 1) uses Q_

Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.

> On June 5, 2014, 8:36 a.m., Thomas Pfeiffer wrote: > > Usability review: > > Since I lack the skills to picture it from the diff: When exactly is the > > notification shown? Is it shown as soon as the media is supposed to be > > played? If so, I think it could be done in a more subtle way: Gr

Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.

On Thu, Jun 5, 2014 at 2:59 PM, Thomas Pfeiffer wrote: >This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118406 > > > Does PMC really have to be restarted to detect that the location is now > accessible? That's not really a nice situation. > Th

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

> On June 4, 2014, 7:30 p.m., Marco Martin wrote: > > what is a valid use case where qml needs to know where the dialog actually > > is?(not hypothetical please) > > doing the animation on the proper direction can be tracked completely > > internally > > > > also, plasmoids should never ever d

Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.

> On June 5, 2014, 8:36 a.m., Thomas Pfeiffer wrote: > > Usability review: > > Since I lack the skills to picture it from the diff: When exactly is the > > notification shown? Is it shown as soon as the media is supposed to be > > played? If so, I think it could be done in a more subtle way: Gr

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

> On June 5, 2014, 8:58 a.m., Chusslove Illich wrote: > > src/kdeclarative/private/rootcontext.cpp, line 48 > > > > > > (And at other places like this.) > > > > If I understand, any of the parameters can

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

> On June 5, 2014, 8:29 a.m., David Edmundson wrote: > > src/kdeclarative/kdeclarative.cpp, line 120 > > > > > > Can we warn if this is already set to something else. > > > > If two QML files try to do i

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

> On June 5, 2014, 8:29 a.m., David Edmundson wrote: > > src/kdeclarative/kdeclarative.cpp, line 120 > > > > > > Can we warn if this is already set to something else. > > > > If two QML files try to do i

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118526/#review59287 --- src/kdeclarative/private/rootcontext.cpp

Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.

> On June 5, 2014, 8:36 a.m., Thomas Pfeiffer wrote: > > Usability review: > > Since I lack the skills to picture it from the diff: When exactly is the > > notification shown? Is it shown as soon as the media is supposed to be > > played? If so, I think it could be done in a more subtle way: Gr

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118526/#review59284 --- Ship it! Great! I'll try to make plasmoids and shells package

Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118406/ --- (Updated June 5, 2014, 8:47 a.m.) Review request for Plasma, Shantanu Tus

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

> On June 5, 2014, 8:29 a.m., David Edmundson wrote: > > +1 from me. > > The i18nd is definitely useful. > > > > The setTranslationDomain isn't ideal, but there's no 100% nice solution to > > it. > > Brainstorming: There is one other possible way we could have i18n automatically select the r

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

> On June 5, 2014, 10:29 a.m., David Edmundson wrote: > > +1 from me. > > The i18nd is definitely useful. > > > > The setTranslationDomain isn't ideal, but there's no 100% nice solution to > > it. > > > > David Edmundson wrote: > Brainstorming: > > There is one other possible way

Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118406/#review59281 --- Usability review: Since I lack the skills to picture it from t

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

> On June 5, 2014, 10:29 a.m., David Edmundson wrote: > > src/kdeclarative/kdeclarative.cpp, line 120 > > > > > > Can we warn if this is already set to something else. > > > > If two QML files try to do

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118526/#review59257 --- +1 from me. The i18nd is definitely useful. The setTranslatio

Re: Review Request 118547: Expose Formats as singleton

> On June 5, 2014, 3:44 a.m., Bhushan Shah wrote: > > src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp, line 40 > > > > > > Err no, this will fail when using formatRelativeDate and > > formatRelativeDateTime go