Review Request 118688: Avoid crash when artist is invalid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118688/ --- Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Harida

Re: Review Request 118657: Use move() while moving items in playlist, instead of dataChanged() signals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118657/ --- (Updated June 12, 2014, 10:42 a.m.) Status -- This change has been m

Re: Review Request 118678: [ki18n] Allow querying for translations of a specific domain

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118678/ --- (Updated June 11, 2014, 11:24 p.m.) Status -- This change has been d

Re: Review Request 118678: [ki18n] Allow querying for translations of a specific domain

> On June 11, 2014, 11:09 p.m., David Edmundson wrote: > > Can I check I'm understanding the objective. > > > > For the language KCM we want to list all possible languages. Potentially > > systemsettings isn't translated so won't be listed. In order to get round > > this we need to pick a ran

Re: Review Request 118678: [ki18n] Allow querying for translations of a specific domain

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118678/#review59840 --- Can I check I'm understanding the objective. For the languag

Review Request 118678: [ki18n] Allow querying for translations of a specific domain

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118678/ --- Review request for Plasma, Chusslove Illich and John Layt. Repository: ki

Re: Plasma 5 Beta 2 tars

On Wednesday 11 of June 2014 17:07:04 Sebastian Kügler wrote: > [CC:ing frameworks-devel, hoping for additional input] > > On Friday, June 06, 2014 23:24:50 šumski wrote: > > On Friday 06 of June 2014 21:32:48 Eric Hameleers wrote: > > > On Fri, 6 Jun 2014, ?umski wrote: > > > > On Thursday 05 of

Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet

> On June 11, 2014, 6:18 p.m., Rex Dieter wrote: > > Tested this out a bit today... and it didn't seem to work all that well. > > Did seem to result in too much whitespace at times, and was fairly easy to > > get plasma into a state where it would endlessly try to resize things to > > fit. H

Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet

> On June 11, 2014, 6:18 p.m., Rex Dieter wrote: > > Tested this out a bit today... and it didn't seem to work all that well. > > Did seem to result in too much whitespace at times, and was fairly easy to > > get plasma into a state where it would endlessly try to resize things to > > fit. H

Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet

> On June 11, 2014, 6:18 p.m., Rex Dieter wrote: > > Tested this out a bit today... and it didn't seem to work all that well. > > Did seem to result in too much whitespace at times, and was fairly easy to > > get plasma into a state where it would endlessly try to resize things to > > fit. H

Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet

> On June 11, 2014, 6:18 p.m., Rex Dieter wrote: > > Tested this out a bit today... and it didn't seem to work all that well. > > Did seem to result in too much whitespace at times, and was fairly easy to > > get plasma into a state where it would endlessly try to resize things to > > fit. H

Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet

> On June 11, 2014, 6:18 p.m., Rex Dieter wrote: > > Tested this out a bit today... and it didn't seem to work all that well. > > Did seem to result in too much whitespace at times, and was fairly easy to > > get plasma into a state where it would endlessly try to resize things to > > fit. H

Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115431/#review59821 --- Tested this out a bit today... and it didn't seem to work all

Re: Moving Parts of Baloo into the Workspace

On Wednesday 11 June 2014 15:43:34 Vishesh Handa wrote: > On Wed, Jun 11, 2014 at 3:30 PM, Aleix Pol wrote: > > Doesn't that tie Baloo usage to exclusively Plasma? If you want it to be a > > framework, won't framework users need to configure the things in the KCM? > > Hmm, you have a point. > >

Re: Review Request 118512: RFC: Rename CMake configuration files to KFileMetaData5*

> On June 11, 2014, 11 a.m., Vishesh Handa wrote: > > How about we change the cmake file to KF5KFileMetaDataConfig.cmake instead? > > This way there will be no conflicts, and it will be consistent with the > > rest of the frameworks as well? > > Aleix Pol Gonzalez wrote: > I agree it's the

Jenkins build is back to stable : plasma-workspace_master_qt5 #398

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118388: rename systemsettings binary to systemsettings5

> On June 11, 2014, 11:17 a.m., Matthew Dawson wrote: > > One other thing that conflicts between the two versions is the > > systemsettings view library. I think just a soname bump is enough to > > handle it. > > Hrvoje Senjan wrote: > see r118387 =) Sorry, never mind. I've just been ch

Re: Review Request 118657: Use move() while moving items in playlist, instead of dataChanged() signals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118657/#review59816 --- Ship it! Ship It! - Shantanu Tushar On June 11, 2014, 5:51

Re: Review Request 118388: rename systemsettings binary to systemsettings5

> On June 11, 2014, 5:17 p.m., Matthew Dawson wrote: > > One other thing that conflicts between the two versions is the > > systemsettings view library. I think just a soname bump is enough to > > handle it. see r118387 =) - Hrvoje -

Re: Review Request 118148: KRunner: Add the concept of disabled categories

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118148/#review59814 --- This review has been submitted with commit 50f7522c5162632a90

Re: Review Request 118148: KRunner: Add the concept of disabled categories

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118148/ --- (Updated June 11, 2014, 4:18 p.m.) Status -- This change has been ma

Re: Review Request 118669: Update DataEngine sources only if they are used

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118669/#review59812 --- This review has been submitted with commit a177696c6cd491a836

Re: Review Request 118669: Update DataEngine sources only if they are used

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118669/ --- (Updated June 11, 2014, 3:17 p.m.) Status -- This change has been ma

Re: Review Request 118388: rename systemsettings binary to systemsettings5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118388/#review59811 --- One other thing that conflicts between the two versions is the

Re: Review Request 118669: Update DataEngine sources only if they are used

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118669/#review59809 --- Ship it! should be fine - Marco Martin On June 11, 2014, 2

Re: Review Request 118388: rename systemsettings binary to systemsettings5

> On June 9, 2014, 1:21 p.m., Eike Hein wrote: > > If you rename the .desktop files, please remember to update the default > > favorites configurations in Kicker (it's in the main.xml of the package) > > and Kickoff (somewhere in C++ model code) since they both reference System > > Settings by

Re: Plasma 5 Beta 2 tars

[CC:ing frameworks-devel, hoping for additional input] On Friday, June 06, 2014 23:24:50 šumski wrote: > On Friday 06 of June 2014 21:32:48 Eric Hameleers wrote: > > On Fri, 6 Jun 2014, ?umski wrote: > > > On Thursday 05 of June 2014 16:47:59 Jonathan Riddell wrote: > > >> Tars are up for Plasma 5

Re: Review Request 118512: RFC: Rename CMake configuration files to KFileMetaData5*

> On June 11, 2014, 7 a.m., Vishesh Handa wrote: > > How about we change the cmake file to KF5KFileMetaDataConfig.cmake instead? > > This way there will be no conflicts, and it will be consistent with the > > rest of the frameworks as well? > > Aleix Pol Gonzalez wrote: > I agree it's the

Review Request 118669: Update DataEngine sources only if they are used

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118669/ --- Review request for Plasma. Repository: plasma-framework Description ---

Review Request 118668: Split the startDate property into today and displayedDate in calendar component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118668/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 118512: RFC: Rename CMake configuration files to KFileMetaData5*

> On June 11, 2014, 1:51 p.m., Aleix Pol Gonzalez wrote: > > Ship It! > > Vishesh Handa wrote: > Uhh. Currently the patch renames it to KFileMetaData5 instead of > KF5::FileMetaData. We want the one with the KF5, not this on. Heh true :$. - Aleix ---

Re: Review Request 118468: Use the spacebar key to play/pause a media from the homescreen.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118468/#review59801 --- This review has been submitted with commit 6b7a1eb31cebef89e4

Re: Review Request 118468: Use the spacebar key to play/pause a media from the homescreen.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118468/ --- (Updated June 11, 2014, 2:27 p.m.) Status -- This change has been ma

Re: Moving Parts of Baloo into the Workspace

On Wednesday, 2014-06-11, 15:43:34, Vishesh Handa wrote: > On Wed, Jun 11, 2014 at 3:30 PM, Aleix Pol wrote: > > Doesn't that tie Baloo usage to exclusively Plasma? If you want it to be a > > framework, won't framework users need to configure the things in the KCM? > > Hmm, you have a point. > >

Jenkins build became unstable: plasma-workspace_master_qt5 #397

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118512: RFC: Rename CMake configuration files to KFileMetaData5*

> On June 11, 2014, 1:51 p.m., Aleix Pol Gonzalez wrote: > > Ship It! Uhh. Currently the patch renames it to KFileMetaData5 instead of KF5::FileMetaData. We want the one with the KF5, not this on. - Vishesh --- This is an automatically

Re: Review Request 118512: RFC: Rename CMake configuration files to KFileMetaData5*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118512/#review59795 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 4, 2014, 6:

Re: Moving Parts of Baloo into the Workspace

On Wed, Jun 11, 2014 at 3:30 PM, Aleix Pol wrote: > > Doesn't that tie Baloo usage to exclusively Plasma? If you want it to be a > framework, won't framework users need to configure the things in the KCM? > > Hmm, you have a point. I was only thinking about it from a non-kde point of view. If you

Re: Moving Parts of Baloo into the Workspace

On Wednesday 11 June 2014, Aleix Pol wrote: > > If anyone has any objections please speak up. I'll do the move on Monday. > > > > -- > > Vishesh Handa > > > > ___ > > Plasma-devel mailing list > > Plasma-devel@kde.org > > https://mail.kde.org/mailman/li

Re: Review Request 118512: RFC: Rename CMake configuration files to KFileMetaData5*

> On June 11, 2014, 11 a.m., Vishesh Handa wrote: > > How about we change the cmake file to KF5KFileMetaDataConfig.cmake instead? > > This way there will be no conflicts, and it will be consistent with the > > rest of the frameworks as well? > > Aleix Pol Gonzalez wrote: > I agree it's the

Re: Review Request 118512: RFC: Rename CMake configuration files to KFileMetaData5*

> On June 11, 2014, 11 a.m., Vishesh Handa wrote: > > How about we change the cmake file to KF5KFileMetaDataConfig.cmake instead? > > This way there will be no conflicts, and it will be consistent with the > > rest of the frameworks as well? > > Aleix Pol Gonzalez wrote: > I agree it's the

Re: Plasma-desktop on non Xorg (X11/Wayland) windowing systems?

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 11.06.2014 12:25, schrieb Marco Martin: > On Wednesday 11 June 2014, Martin Gräßlin wrote: >> Hi all! >> >> The review request [1] raised the question whether it makes sense >> that we have any support for building without X11 support. Right >> n

Re: Re: Moving Parts of Baloo into the Workspace

On Wednesday 11 June 2014 15:30:17 Aleix Pol wrote: > On Wed, Jun 11, 2014 at 3:28 PM, Vishesh Handa wrote: > > Hey guys > > > > As an effort to modularize Baloo and make it more into a framework, I'm > > going to be moving certain parts of it into the workspace. > > > > baloo/src/runner -> plas

Re: Moving Parts of Baloo into the Workspace

On Wed, Jun 11, 2014 at 3:28 PM, Vishesh Handa wrote: > Hey guys > > As an effort to modularize Baloo and make it more into a framework, I'm > going to be moving certain parts of it into the workspace. > > baloo/src/runner -> plasma-workspace/runners > baloo/src/kioslaves -> plasma-workspace/kios

Moving Parts of Baloo into the Workspace

Hey guys As an effort to modularize Baloo and make it more into a framework, I'm going to be moving certain parts of it into the workspace. baloo/src/runner -> plasma-workspace/runners baloo/src/kioslaves -> plasma-workspace/kioslaves baloo/src/file/kcm -> plasma-desktop/kcm This will obviously

Re: Review Request 118512: RFC: Rename CMake configuration files to KFileMetaData5*

> On June 11, 2014, 11 a.m., Vishesh Handa wrote: > > How about we change the cmake file to KF5KFileMetaDataConfig.cmake instead? > > This way there will be no conflicts, and it will be consistent with the > > rest of the frameworks as well? I agree it's the best way, the only problem being th

Review Request 118665: Avoid invalid read in ShadowHelper destructor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118665/ --- Review request for Plasma. Repository: oxygen Description --- Valg

Re: Review Request 118659: Improve finding of all X11 dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118659/ --- (Updated June 11, 2014, 11:06 a.m.) Status -- This change has been m

Re: Review Request 118659: Improve finding of all X11 dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118659/#review59772 --- This review has been submitted with commit 5ea23e38146a8f29f3

Re: Review Request 118512: RFC: Rename CMake configuration files to KFileMetaData5*

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118512/#review59771 --- How about we change the cmake file to KF5KFileMetaDataConfig.c

Re: Plasma-desktop on non Xorg (X11/Wayland) windowing systems?

On Wednesday 11 June 2014, Martin Gräßlin wrote: > Hi all! > > The review request [1] raised the question whether it makes sense that we > have any support for building without X11 support. Right now the build > without X11 is broken, nevertheless there are many checks of the kind > > if(NOT WIN3

Plasma-desktop on non Xorg (X11/Wayland) windowing systems?

Hi all! The review request [1] raised the question whether it makes sense that we have any support for building without X11 support. Right now the build without X11 is broken, nevertheless there are many checks of the kind if(NOT WIN32) or #if defined(Q_OS_UNIX) && !defined(Q_OS_MAC) Also we

Re: Review Request 118659: Improve finding of all X11 dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118659/#review59764 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 11, 2014, 7

Re: Review Request 118661: Only find Qt5::X11Extras if X11 is found

> On June 11, 2014, 11 a.m., David Edmundson wrote: > > If you do this we need checks around building everything that tries to link > > against it otherwise you get mystery compile fails. > > There's 2 applets and 9 KCMs > > Martin Gräßlin wrote: > they should already have these checks othe

Re: Review Request 118661: Only find Qt5::X11Extras if X11 is found

> On June 11, 2014, 9 a.m., David Edmundson wrote: > > If you do this we need checks around building everything that tries to link > > against it otherwise you get mystery compile fails. > > There's 2 applets and 9 KCMs > > Martin Gräßlin wrote: > they should already have these checks other

Re: Review Request 118661: Only find Qt5::X11Extras if X11 is found

> On June 11, 2014, 11 a.m., David Edmundson wrote: > > If you do this we need checks around building everything that tries to link > > against it otherwise you get mystery compile fails. > > There's 2 applets and 9 KCMs they should already have these checks otherwise the check for X11 is kind

Re: Review Request 118661: Only find Qt5::X11Extras if X11 is found

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118661/#review59752 --- If you do this we need checks around building everything that

Review Request 118662: fix plugin install target for phonon platform plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118662/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Review Request 118661: Only find Qt5::X11Extras if X11 is found

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118661/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 118468: Use the spacebar key to play/pause a media from the homescreen.

> On June 2, 2014, 5:05 p.m., Shantanu Tushar wrote: > > Hmm, looks good to me. If this is fine, can this change be committed on my behalf ? Thanks. - R.Harish --- This is an automatically generated e-mail. To reply, visit: https://g

Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.

> On June 5, 2014, 8:36 a.m., Thomas Pfeiffer wrote: > > Usability review: > > Since I lack the skills to picture it from the diff: When exactly is the > > notification shown? Is it shown as soon as the media is supposed to be > > played? If so, I think it could be done in a more subtle way: Gr

Review Request 118659: Improve finding of all X11 dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118659/ --- Review request for Plasma. Repository: plasma-workspace Description ---