Re: Review Request 118865: [startkde from plasma next] create ~/.kde directory if it doesn't exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118865/#review62158 --- That code snippet is from Qt, since it was written before kf5

Re: Review Request 119233: Do not load system load by default, graphs are broken currently

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119233/#review62157 --- I still have no KF5 setup, so I cannot test it myself, but the

Re: Review Request 119220: Figure out why my plasma wasn't notifying the startup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119220/#review62154 --- Ship it! So, it can go in for now, I decided to stop talking

Re: Review Request 119220: Figure out why my plasma wasn't notifying the startup

> On July 11, 2014, 5:42 p.m., Marco Martin wrote: > > hmm, i preferred the previous version :/ Anyways, would be fine for me.. i really need to write an unit test for this darn thing tough - Marco --- This is an automatically generate

Re: Review Request 119220: Figure out why my plasma wasn't notifying the startup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119220/#review62147 --- hmm, i preferred the previous version :/ - Marco Martin On

Re: Review Request 119219: Control volume from HomeScreen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119219/ --- (Updated July 11, 2014, 5:42 p.m.) Status -- This change has been di

Re: Review Request 119220: Figure out why my plasma wasn't notifying the startup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119220/ --- (Updated July 11, 2014, 5:33 p.m.) Review request for Plasma. Changes -

Re: Plasma 5.0.0!

Proving Wulf right, another try at baloo baloo;frameworks;2c4042b3cb98e2e0d68a57164faa81ad805fff38;baloo-5.0.0.tar.xz;92b5de11db66fe6037606ef34687f78ca626afbee1dea27c3ceb842782dc3af8 Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://m

Re: Review Request 119219: Control volume from HomeScreen

> On July 10, 2014, 6:36 p.m., Shantanu Tushar wrote: > > My only problem with this is that its inconsistent with the Up/Down arrow > > key combination that we have in MediaPlayer. Also, you can't make the > > player also use Ctrl+Arrow keys because then a remote control won't work. > > I'd sug

Re: Plasma 5.0.0!

Another try for baloo, I made an empty tar somehow baloo;frameworks;2c4042b3cb98e2e0d68a57164faa81ad805fff38;baloo-5.0.0.tar.xz;1f2f0049e70cc207de581de7ee4b99d86d4ad8417901d558722905cf0b0c9594 http://starsky.19inch.net/~jr/tmp/plasma-5.0.0/baloo-5.0.0.tar.xz Jonathan ___

Re: Review Request 119232: Rewrite the Calendar component grid + small refactor

> On July 11, 2014, 2:48 p.m., Sebastian Kügler wrote: > > It would be easier to review, if you made separate patches for the renaming > > and the actual changes in the code that juggle around the objects. > > Martin Klapetek wrote: > I did the renaming in the middle of this as I got annoye

Re: Review Request 119232: Rewrite the Calendar component grid + small refactor

> On July 11, 2014, 4:48 p.m., Sebastian Kügler wrote: > > It would be easier to review, if you made separate patches for the renaming > > and the actual changes in the code that juggle around the objects. I did the renaming in the middle of this as I got annoyed by the confusing names. To su

Re: Review Request 119232: Rewrite the Calendar component grid + small refactor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119232/#review62142 --- It would be easier to review, if you made separate patches for

Re: Review Request 119232: Rewrite the Calendar component grid + small refactor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119232/#review62141 --- Looks very good to me! +1 I like the double repeater approach

Re: Plasma 5.0.0!

2014-07-11 14:42 GMT+04:00 Jonathan Riddell : > Harald says this is fixed now in releaseme's rewrite branch. Great, thanks to both of you! -- Alexander Potashev ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/pl

Re: Review Request 119232: Rewrite the Calendar component grid + small refactor

> On July 11, 2014, 4:31 p.m., Sebastian Kügler wrote: > > The junctions between the lines are now painted double and appear less > > translucent than before. This is the reason why I used multiple rects in > > the first place. > > Martin Klapetek wrote: > For reference, I'll add before/af

Re: Review Request 119232: Rewrite the Calendar component grid + small refactor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119232/ --- (Updated July 11, 2014, 4:35 p.m.) Review request for Plasma. Repositor

Re: Review Request 119232: Rewrite the Calendar component grid + small refactor

> On July 11, 2014, 4:31 p.m., Sebastian Kügler wrote: > > The junctions between the lines are now painted double and appear less > > translucent than before. This is the reason why I used multiple rects in > > the first place. For reference, I'll add before/after screenshot - Martin -

Re: Review Request 119232: Rewrite the Calendar component grid + small refactor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119232/#review62138 --- The junctions between the lines are now painted double and app

Re: Review Request 119233: Do not load system load by default, graphs are broken currently

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119233/#review62137 --- looks good to me, I am not sure the active tab set is written

Re: Review Request 119233: Do not load system load by default, graphs are broken currently

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119233/ --- (Updated July 11, 2014, 2:08 p.m.) Review request for Plasma, John Tapsel

Review Request 119233: Do not load system load by default, graphs are broken currently

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119233/ --- Review request for Plasma. Repository: ksysguard Description --- D

Re: Review Request 119232: Rewrite the Calendar component grid + small refactor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119232/ --- (Updated July 11, 2014, 4:04 p.m.) Review request for Plasma. Changes -

Re: Review Request 119232: Rewrite the Calendar component grid + small refactor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119232/#review62136 --- Could you attach a screenshot, please? - Sebastian Kügler O

Re: [plasma-devel] Re: Plasma 5.0.0!

On Fri, Jul 11, 2014 at 12:28:24PM +0100, Jonathan Riddell wrote: > On Thu, Jul 10, 2014 at 09:06:21PM +0100, Jonathan Riddell wrote: > > On Thu, Jul 10, 2014 at 08:00:15PM +0100, Jonathan Riddell wrote: > > > On Thu, Jul 10, 2014 at 07:31:52PM +0100, Jonathan Riddell wrote: > > > > On Thu, Jul 10,

Review Request 119232: Rewrite the Calendar component grid + small refactor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119232/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: [plasma-devel] Re: Plasma 5.0.0!

On Fri, Jul 11, 2014 at 12:28:24PM +0100, Jonathan Riddell wrote: > On Thu, Jul 10, 2014 at 09:06:21PM +0100, Jonathan Riddell wrote: > > On Thu, Jul 10, 2014 at 08:00:15PM +0100, Jonathan Riddell wrote: > > > On Thu, Jul 10, 2014 at 07:31:52PM +0100, Jonathan Riddell wrote: > > > > On Thu, Jul 10,

Re: Review Request 119219: Control volume from HomeScreen

> On July 10, 2014, 6:36 p.m., Shantanu Tushar wrote: > > My only problem with this is that its inconsistent with the Up/Down arrow > > key combination that we have in MediaPlayer. Also, you can't make the > > player also use Ctrl+Arrow keys because then a remote control won't work. > > I'd sug

strings are frozen

Please don't change any strings in Plasma/5.0 branches, that'll break translations, any typos need to stay as they are. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.0.0!

On Thu, Jul 10, 2014 at 09:06:21PM +0100, Jonathan Riddell wrote: > On Thu, Jul 10, 2014 at 08:00:15PM +0100, Jonathan Riddell wrote: > > On Thu, Jul 10, 2014 at 07:31:52PM +0100, Jonathan Riddell wrote: > > > On Thu, Jul 10, 2014 at 06:38:42PM +0100, Jonathan Riddell wrote: > > > > Coming shortly

Re: Review Request 119229: Remove wrong changes to ToolboxButton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119229/ --- (Updated July 11, 2014, 11:17 a.m.) Status -- This change has been m

Re: Review Request 119229: Remove wrong changes to ToolboxButton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119229/#review62127 --- Ship it! eh, thinking about it, the actual bug there was that

Re: Review Request 119227: Add FindOpenGLES

> On Juli 11, 2014, 10:19 vorm., Jonathan Riddell wrote: > > Submitted, but it would be great if you'd add this cmake module to > > extra-cmake-modules as currently it's duplicated several times Please see https://git.reviewboard.kde.org/r/119230/ - Heiko ---

Re: Plasma 5.0.0!

Harald says this is fixed now in releaseme's rewrite branch. Jonathan On 10 July 2014 20:25, Alexander Potashev wrote: > 2014-07-10 21:38 GMT+04:00 Jonathan Riddell : > > Coming shortly to depot for packagers or you can grab them from > > http://starsky.19inch.net/~jr/tmp/plasma-5.0.0/ > > i

Review Request 119229: Remove wrong changes to ToolboxButton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119229/ --- Review request for Plasma. Bugs: 336209 https://bugs.kde.org/show_bug

Re: Review Request 119227: Add FindOpenGLES

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119227/#review62124 --- Submitted, but it would be great if you'd add this cmake modul

Re: Review Request 119227: Add FindOpenGLES

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119227/ --- (Updated July 11, 2014, 10:17 a.m.) Status -- This change has been m

Re: 4.x transition blockage - workspace libs

On Fri, Jul 11, 2014 at 11:10 AM, Harald Sitter wrote: > On Thu, Jul 10, 2014 at 5:40 PM, Michael Palimaka > wrote: >> It's probably a bit late now, but we could just rename the offending >> libraries in Plasma 5 (as has already been done with some). > > Since the libs aren't supposed to be used

Re: Review Request 119227: Add FindOpenGLES

> On July 11, 2014, 9:20 a.m., Eike Hein wrote: > > My bad, I didn't realize it was needed. I did actually ask a few people to > > review the CMake code this week, but they must have assumed it was there or > > dodn't realize either. > > > > @Martin: You got to see the OpenGL code yesterday ac

Re: Review Request 119227: Add FindOpenGLES

> On July 11, 2014, 9:20 a.m., Eike Hein wrote: > > My bad, I didn't realize it was needed. I did actually ask a few people to > > review the CMake code this week, but they must have assumed it was there or > > dodn't realize either. > > > > @Martin: You got to see the OpenGL code yesterday ac

Re: Review Request 119227: Add FindOpenGLES

> On Juli 11, 2014, 9:20 vorm., Eike Hein wrote: > > My bad, I didn't realize it was needed. I did actually ask a few people to > > review the CMake code this week, but they must have assumed it was there or > > dodn't realize either. > > > > @Martin: You got to see the OpenGL code yesterday a

Re: Review Request 119227: Add FindOpenGLES

> On July 11, 2014, 9:20 a.m., Eike Hein wrote: > > My bad, I didn't realize it was needed. I did actually ask a few people to > > review the CMake code this week, but they must have assumed it was there or > > dodn't realize either. > > > > @Martin: You got to see the OpenGL code yesterday ac

Re: Review Request 119227: Add FindOpenGLES

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119227/#review62116 --- Ship it! My bad, I didn't realize it was needed. I did actual

Re: [kde-packager] Re: Plasma 5.0.0!

This morning's update for https://bugs.kde.org/show_bug.cgi?id=337336 "libmm-qt compilation fails with MM 1.2" 19e0247f7c4068e986450f365c3b6c5caefb00e203c9e69fbfb3d5fb94b858f2 libmm-qt-5.0.91.tar.xz now on http://starsky.19inch.net/~jr/tmp/plasma-5.0.0/ baloo update expected shortly.. Jonatha

Re: 4.x transition blockage - workspace libs

On Thu, Jul 10, 2014 at 5:40 PM, Michael Palimaka wrote: > On 07/10/2014 12:32 AM, Harald Sitter wrote: >> Ahoy everyone, >> >> I recently got into a discussion about the 5.0 workspace transition >> and how this can be kept from having impact on 4.x applications in any >> form. Having looked into

Re: Review Request 119227: Add FindOpenGLES

> On Juli 11, 2014, 8:48 vorm., Martin Gräßlin wrote: > > is it needed at all? I'm surprised that something in plasma-desktop would > > use OpenGL at all, might be just a copy-paste error. At least the cmake code claims folderplugin gets linked with OpenGLES (if it is found). The commit which

Re: Review Request 119227: Add FindOpenGLES

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119227/#review62114 --- is it needed at all? I'm surprised that something in plasma-de

Re: Review Request 119220: Figure out why my plasma wasn't notifying the startup

> On July 10, 2014, 8:10 p.m., Marco Martin wrote: > > src/plasma/private/applet_p.cpp, line 316 > > > > > > when the code hits this path, uiready gets anyways set to true in line > > 333 > > > > now, t

Review Request 119227: Add FindOpenGLES

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119227/ --- Review request for Plasma. Repository: plasma-desktop Description -