Jenkins build is back to normal : plasma-desktop_master_qt5 #519

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119618: add theme selection for screen lockers

> On Aug. 5, 2014, 3:35 p.m., David Edmundson wrote: > > ksmserver/screenlocker/kcm/package/contents/ui/main.qml, line 128 > > > > > > what's this for? I assume you're working round something. > > > > (a

Re: Review Request 119604: Fix build of KDELibs4Support, qMessageFormatString

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119604/ --- (Updated Aug. 5, 2014, 10:37 p.m.) Status -- This change has been ma

Stable branch for kf5 based projects created

It lives at branches/stable/l10n-kf5/ in SVN At the moment it only holds Plasma/5.0 translations that is the only project with a stable relase in the planning. Plasma people please make sure you get the translations from there when making a release and that you give some warning before the r

branches/plasma/5.0

SVN commit 1395994 by aacid: Stable 5.0 branch for plasma-workspace-wallpapers It was not created back when the branching of git repos was done CCMAIL: plasma-devel@kde.org A plasma-workspace-wallpapers (directory) ___ Plasma-devel ma

Re: Review Request 119618: add theme selection for screen lockers

> On Aug. 5, 2014, 3:35 p.m., David Edmundson wrote: > > ksmserver/screenlocker/kcm/package/contents/ui/main.qml, line 128 > > > > > > what's this for? I assume you're working round something. > > > > (a

Re: Review Request 119604: Fix build of KDELibs4Support, qMessageFormatString

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119604/#review63880 --- Ship it! Ship It! - Kevin Funk On Aug. 4, 2014, 5:21 p.m.,

Re: Review Request 119603: Use Qt API for figuring out the dialog screen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119603/ --- (Updated Aug. 5, 2014, 5:49 p.m.) Status -- This change has been mar

Re: Review Request 119617: Plasma Mobile: Introduce org.kde.plasma.baloodatamodel

> On Aug. 5, 2014, 2:17 p.m., Vishesh Handa wrote: > > I think the Baloo repo might a better place for code. It's not really > > Plasma specific. > > Marco Martin wrote: > import org.kde.baloo in the baloo repo with this class and eventually > others? > would you do it just as an impor

Re: Review Request 119617: Plasma Mobile: Introduce org.kde.plasma.baloodatamodel

> On Aug. 5, 2014, 12:29 p.m., Marco Martin wrote: > > components/baloodatamodel/baloodatamodel.cpp, line 116 > > > > > > maybe this should be done in a thread? > > Vishesh Handa wrote: > I named the method

Re: Review Request 119617: Plasma Mobile: Introduce org.kde.plasma.baloodatamodel

> On Aug. 5, 2014, 2:17 p.m., Vishesh Handa wrote: > > I think the Baloo repo might a better place for code. It's not really > > Plasma specific. > > Marco Martin wrote: > import org.kde.baloo in the baloo repo with this class and eventually > others? > would you do it just as an impor

Re: Review Request 119618: add theme selection for screen lockers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119618/ --- (Updated Aug. 5, 2014, 4:14 p.m.) Review request for Plasma. Repository

Re: Review Request 119618: add theme selection for screen lockers

> On Aug. 5, 2014, 3:35 p.m., David Edmundson wrote: > > ksmserver/screenlocker/kcm/package/contents/ui/main.qml, line 128 > > > > > > what's this for? I assume you're working round something. > > > > (a

Re: Review Request 119603: Use Qt API for figuring out the dialog screen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119603/#review63873 --- Ship it! Been running it all day, including some monitor hotp

Re: Review Request 119618: add theme selection for screen lockers

> On Aug. 5, 2014, 3:35 p.m., David Edmundson wrote: > > ksmserver/screenlocker/kcm/lockermodel.cpp, line 1 > > > > > > http://qt-project.org/doc/qt-5/qstandarditemmodel.html#setItemRoleNames > > Marco Martin wrot

Re: Review Request 119618: add theme selection for screen lockers

> On Aug. 5, 2014, 3:35 p.m., David Edmundson wrote: > > File Attachment: locker.png - locker.png > > > > > > Do we want a frame round this? > > > > A title of "Lock screen style" might be useful? around the whole view? maybe

Re: Review Request 119618: add theme selection for screen lockers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119618/#review63866 --- File Attachment: locker.png - locker.png

Re: Review Request 119617: Plasma Mobile: Introduce org.kde.plasma.baloodatamodel

> On Aug. 5, 2014, 12:29 p.m., Marco Martin wrote: > > components/baloodatamodel/baloodatamodel.cpp, line 116 > > > > > > maybe this should be done in a thread? > > Vishesh Handa wrote: > I named the method

Review Request 119618: add theme selection for screen lockers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119618/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 119617: Plasma Mobile: Introduce org.kde.plasma.baloodatamodel

> On Aug. 5, 2014, 2:17 p.m., Vishesh Handa wrote: > > I think the Baloo repo might a better place for code. It's not really > > Plasma specific. import org.kde.baloo in the baloo repo with this class and eventually others? would you do it just as an import or accessible also in a c++ library?

Build failed in Jenkins: plasma-desktop_master_qt5 #518

See Changes: [notmart] support runners config dialog [notmart] build the categories map only once [notmart] remove some old stuff ported from KPluginLoader [notmart] some ui fixes [notmart] use icon sizes from groups [notmart]

Re: Review Request 119602: support config dialog with current krunner config dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119602/ --- (Updated Aug. 5, 2014, 2:41 p.m.) Status -- This change has been mar

Re: Review Request 119617: Plasma Mobile: Introduce org.kde.plasma.baloodatamodel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119617/#review63861 --- I think the Baloo repo might a better place for code. It's not

Re: Review Request 119602: support config dialog with current krunner config dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119602/#review63860 --- Ship it! - Vishesh Handa On Aug. 5, 2014, 10:50 a.m., Marco

Re: Review Request 119617: Plasma Mobile: Introduce org.kde.plasma.baloodatamodel

> On Aug. 5, 2014, 12:29 p.m., Marco Martin wrote: > > two things: > > * perhaps the query should still be executed in a thread > > * maybe the syntax from qml would be nicer if the query is in a sub object > > to have something like: > > > > BalooModel { > > query { > > type: "File

Re: Review Request 119617: Plasma Mobile: Introduce org.kde.plasma.baloodatamodel

> On Aug. 5, 2014, 12:29 p.m., Marco Martin wrote: > > components/baloodatamodel/baloodatamodel.cpp, line 116 > > > > > > maybe this should be done in a thread? I named the method exec so that it was clear it mi

Re: Review Request 119617: Plasma Mobile: Introduce org.kde.plasma.baloodatamodel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119617/#review63848 --- two things: * perhaps the query should still be executed in a

Review Request 119617: Plasma Mobile: Introduce org.kde.plasma.baloodatamodel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119617/ --- Review request for Plasma. Repository: plasma-mobile Description --

Re: kdeplasma-addons

I Absolutely agree with those categories. Should we can add some more columns on the board so we can split them there? > > * those that are kinda useful, a bit silly, not required, that would be > conditioned to someone adopting(calculator, bubblemon, fifteenpuzzle...) I think this is the tricky

Re: Review Request 119602: support config dialog with current krunner config dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119602/ --- (Updated Aug. 5, 2014, 10:50 a.m.) Review request for Plasma. Repositor

Re: Review Request 119602: support config dialog with current krunner config dialog

> On Aug. 5, 2014, 9:44 a.m., Vishesh Handa wrote: > > kcms/runners/kcm.cpp, line 88 > > > > > > The manager does not seem to be deleted. Is this correct? added a parent, it should live for the kcm lifetime but h

Re: kdeplasma-addons

On Tuesday 05 August 2014, David Edmundson wrote: > I've imported all the plasmoids runners and dataengines that were in > kdeplasma-addons into a Kanban board here: > https://todo.kde.org/?controller=board&action=show&project_id=11 > applets are yellow, dataengines are red, runners are green than

kdeplasma-addons

I've imported all the plasmoids runners and dataengines that were in kdeplasma-addons into a Kanban board here: https://todo.kde.org/?controller=board&action=show&project_id=11 applets are yellow, dataengines are red, runners are green I think it's a good opportunity to maybe bring some new people

Re: Review Request 119602: support config dialog with current krunner config dialog

> On Aug. 5, 2014, 9:44 a.m., Vishesh Handa wrote: > > kcms/runners/kcm.cpp, line 60 > > > > > > I'm fairly certain this is going to look bad on my hidpi screen. > > > > KIconLoader::SizeMedium is hardcod

Re: Review Request 119602: support config dialog with current krunner config dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119602/#review63839 --- kcms/runners/kcm.cpp

Re: Review Request 119602: support config dialog with current krunner config dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119602/ --- (Updated Aug. 5, 2014, 9:24 a.m.) Review request for Plasma. Repository