Re: Minimum translation percentage for Plasma 5 release

2014-08-12 Thread Franklin Weng
2014-08-12 18:05 GMT+08:00 Albert Astals Cid : > > > Well, maybe not to drop it in certain range like 65%, but to warn the > > coordinator when under 70%. And when the translation rate is under 70% > for > > three consecutive versions (even in 69%) it can be dropped. > > The thing is, if we do th

Re: Review Request 119748: Properly align KickoffButtons to center

2014-08-12 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119748/ --- (Updated Aug. 13, 2014, 2:37 a.m.) Review request for Plasma. Repositor

Re: Review Request 119748: Properly align KickoffButtons to center

2014-08-12 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119748/ --- (Updated Aug. 13, 2014, 2:35 a.m.) Review request for Plasma. Changes -

Re: Review Request 119748: Properly align KickoffButtons to center

2014-08-12 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119748/ --- (Updated Aug. 13, 2014, 2:01 a.m.) Review request for Plasma. Changes -

Review Request 119748: Properly align KickoffButtons to center when in vertical mode

2014-08-12 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119748/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Minimum translation percentage for Plasma 5 releases (second take)

2014-08-12 Thread Luigi Toscano
Albert Astals Cid ha scritto: > After talking to a few people here in Randa about this issue, I come with an > updated suggestion. > > * We ship all translations that are over a very low limit (say 5%) > * When selecting a language in the language KCM that has less than > $PERCENTAGE we show a

Minimum translation percentage for Plasma 5 releases (second take)

2014-08-12 Thread Albert Astals Cid
After talking to a few people here in Randa about this issue, I come with an updated suggestion. * We ship all translations that are over a very low limit (say 5%) * When selecting a language in the language KCM that has less than $PERCENTAGE we show a dialog saying something like "Yo man, we

Re: Review Request 119745: Hide member documentation for classes in imports

2014-08-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119745/ --- (Updated Aug. 12, 2014, 9:15 p.m.) Status -- This change has been ma

Re: Review Request 119653: batterymonitor: Make BatteryIcon animation run only while the BatteryIcon is visible.

2014-08-12 Thread Nikita Skovoroda
> On Авг. 7, 2014, 8:15 п.п., Kai Uwe Broulik wrote: > > Thanks for taking care of this! > > Kai Uwe Broulik wrote: > Since this is a simple bugfix, please commit to the Plasma/5.0 branch > once 5.0.1 is released. Thanks! > > Bugfixes like these usually go into the stable branch an

Re: Review Request 119745: Hide member documentation for classes in imports

2014-08-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119745/#review64405 --- Ship it! Ship It! - Aleix Pol Gonzalez On Aug. 12, 2014, 8

Re: Review Request 119745: Hide member documentation for classes in imports

2014-08-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119745/#review64404 --- Ship it! Ship It! - Marco Martin On Aug. 12, 2014, 8:12 p.

Review Request 119745: Hide member documentation for classes in imports

2014-08-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119745/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 119739: Don't hardcode applet configuration sidebar size

2014-08-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119739/#review64396 --- Ship it! Ship It! - David Edmundson On Aug. 12, 2014, 6:32

Re: [kde-packager] Re: Plasma 5.0.1 tars

2014-08-12 Thread Jonathan Riddell
Plasma 5.0.1 is out, remember to update the wiki page if you're making packages https://community.kde.org/Plasma/Packages http://kde.org/announcements/plasma-5.0.1.php Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/ma

Re: Plasma 5.0.1 tars

2014-08-12 Thread Jonathan Riddell
On Mon, Aug 11, 2014 at 10:39:58PM +0400, Alexey Shvetsov wrote: > hi! > > Plasma 5.x depends on bluedevil. May be its good to have bluedevil > snapshot for plasma? Where does it depend on bluedevil? Jonathan ___ Plasma-devel mailing list Plasma-devel

Review Request 119739: Don't hardcode applet configuration sidebar size

2014-08-12 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119739/ --- Review request for Plasma. Repository: plasma-desktop Description -

Review Request 119738: Port Fuzzy Clock to Plasma 5

2014-08-12 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119738/ --- Review request for Plasma. Repository: kdeplasma-addons Description ---

Re: Minutes Monday Plasma Hangout

2014-08-12 Thread Marco Martin
On Monday 11 August 2014, Marco Martin wrote: > On Monday 11 August 2014, Sebastian Kügler wrote: > > - Working on Look&Feel KCM > > One thing I would like to hear opinions about on this is: > the look and feel kcm depends from 2 things inside 2 repositories: > * the lookandfeelaccess class inside

Re: OSD above fullscreen windows

2014-08-12 Thread Aleix Pol
On Tue, Aug 12, 2014 at 3:58 PM, Marco Martin wrote: > On Tuesday 12 August 2014, Aleix Pol wrote: > > > Looking at my TVs, it always shows the "OSD" when volume changes, that > > > would > > > be something I'd also expect a media center to do. > > > > Maybe we want different OSD when fullscreen.

Re: OSD above fullscreen windows

2014-08-12 Thread Marco Martin
On Tuesday 12 August 2014, Aleix Pol wrote: > > Looking at my TVs, it always shows the "OSD" when volume changes, that > > would > > be something I'd also expect a media center to do. > > Maybe we want different OSD when fullscreen. I've never seen a TV with the > volume information on the center.

Re: OSD above fullscreen windows

2014-08-12 Thread Sebastian Kügler
On Tuesday, August 12, 2014 15:38:33 Aleix Pol wrote: > On Tue, Aug 12, 2014 at 2:37 PM, Sebastian Kügler wrote: > > On Tuesday, August 12, 2014 11:11:08 Marco Martin wrote: > > On Tuesday 12 August 2014, Vishesh Handa wrote: > > > With Volume, I can maybe understand that you don't want to show i

Re: Review Request 119720: Streamline device notifier

2014-08-12 Thread Sebastian Kügler
> On Aug. 12, 2014, 12:29 p.m., Sebastian Kügler wrote: > > The name, especially the German translation could be improved IMO. That > > would also be in line with other changes (example "Network Management" > > became "Networks"). I'd suggest "Removable Devices" instead of "Device > > Notifier

Re: OSD above fullscreen windows

2014-08-12 Thread Aleix Pol
On Tue, Aug 12, 2014 at 2:37 PM, Sebastian Kügler wrote: > On Tuesday, August 12, 2014 11:11:08 Marco Martin wrote: > > On Tuesday 12 August 2014, Vishesh Handa wrote: > > > > > > With Volume, I can maybe understand that you don't want to show it on > top > > > and the relevant application should

Re: Review Request 119720: Streamline device notifier

2014-08-12 Thread Kai Uwe Broulik
> On Aug. 12, 2014, 12:29 nachm., Sebastian Kügler wrote: > > The name, especially the German translation could be improved IMO. That > > would also be in line with other changes (example "Network Management" > > became "Networks"). I'd suggest "Removable Devices" instead of "Device > > Notifi

Re: Review Request 119720: Streamline device notifier

2014-08-12 Thread Kai Uwe Broulik
> On Aug. 12, 2014, 12:29 nachm., Sebastian Kügler wrote: > > The name, especially the German translation could be improved IMO. That > > would also be in line with other changes (example "Network Management" > > became "Networks"). I'd suggest "Removable Devices" instead of "Device > > Notifi

Re: Review Request 110216: Rename Screen Locker screensaver KCM to Lock Screen

2014-08-12 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110216/#review64377 --- It's fixed in Plasma 5, anyway. - Sebastian Kügler On Aug.

Re: Use of KDirWatch

2014-08-12 Thread Sebastian Kügler
On Tuesday, August 12, 2014 00:10:59 Aleix Pol wrote: > Should we maybe agree that KDirWatch::self() is harmful in the context of > plasma? It's not more harmful than anywhere else, IMO. We should keep an eye out for it in review requests, though. The shared KDirWatch can be useful, and we shoul

Re: Review Request 119720: Streamline device notifier

2014-08-12 Thread Martin Klapetek
> On Aug. 12, 2014, 2:29 p.m., Sebastian Kügler wrote: > > The name, especially the German translation could be improved IMO. That > > would also be in line with other changes (example "Network Management" > > became "Networks"). I'd suggest "Removable Devices" instead of "Device > > Notifier"

Re: OSD above fullscreen windows

2014-08-12 Thread Sebastian Kügler
On Tuesday, August 12, 2014 11:11:08 Marco Martin wrote: > On Tuesday 12 August 2014, Vishesh Handa wrote: > > > > With Volume, I can maybe understand that you don't want to show it on top > > and the relevant application should be showing it. Maybe. With the others, > > they definitely should be.

Testing in Review Requests, was Re: Review Request 119719: Streamline notifications plasmoid

2014-08-12 Thread Sebastian Kügler
On Monday, August 11, 2014 18:19:25 Kai Uwe Broulik wrote: > Testing > > Yup. A general remark: Can we all be a bit more detailed in this section. It's pretty useful to note what has been tested exactly. Perceptions on what is good testing vary wildly, and to me, reading a "yes, I did it" is al

Re: Review Request 119720: Streamline device notifier

2014-08-12 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119720/#review64373 --- The name, especially the German translation could be improved

Re: Review Request 119733: nicer cmake output

2014-08-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119733/#review64371 --- hmm, no stable release currently but then checks for a stable

Re: Review Request 112208: KMix qml applet

2014-08-12 Thread Martin Klapetek
> On Aug. 12, 2014, 1:19 p.m., Christian Esken wrote: > > For me it looks fine, with some questions: > > 1) Is this completely decoupled from KMix? I do not see a "open mixer" to > > open the main application. > > 2) Is it supposed to be integrated in KMix > > 3) In general, the question is how

Review Request 119733: nicer cmake output

2014-08-12 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119733/ --- Review request for Plasma and Martin Gräßlin. Repository: plasma-workspac

Re: Review Request 112208: KMix qml applet

2014-08-12 Thread Christian Esken
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/#review64369 --- For me it looks fine, with some questions: 1) Is this complete

Re: OSD above fullscreen windows

2014-08-12 Thread Martin Klapetek
On Tue, Aug 12, 2014 at 11:11 AM, Marco Martin wrote: > On Tuesday 12 August 2014, Vishesh Handa wrote: > > > > With Volume, I can maybe understand that you don't want to show it on top > > and the relevant application should be showing it. Maybe. With the > others, > > they definitely should be.

Re: Minimum translation percentage for Plasma 5 release

2014-08-12 Thread Aleix Pol
On Tue, Aug 12, 2014 at 2:43 AM, Franklin Weng wrote: > > > > 2014-08-12 2:37 GMT+08:00 Albert Astals Cid : > > Hi, in the 4.x world we have something called "Essential Packages" for >> translations that is basically a set of minimum percentage of some files >> that >> you need to get if you want

Re: Minimum translation percentage for Plasma 5 release

2014-08-12 Thread Albert Astals Cid
El Dimarts, 12 d'agost de 2014, a les 10:30:51, Vincenzo Reale va escriure: > In data martedì 12 agosto 2014 10:17:59, Martin Schlander ha scritto: > > Mandag den 11. august 2014 20:37:28 skrev Albert Astals Cid: > > > So I am leaning towards "no minimum", but I certainly welcome all > > > comments

Re: Minimum translation percentage for Plasma 5 release

2014-08-12 Thread Albert Astals Cid
El Dimarts, 12 d'agost de 2014, a les 08:43:14, Franklin Weng va escriure: > 2014-08-12 2:37 GMT+08:00 Albert Astals Cid : > > Hi, in the 4.x world we have something called "Essential Packages" for > > translations that is basically a set of minimum percentage of some files > > that > > you need to

Re: Minimum translation percentage for Plasma 5 release

2014-08-12 Thread Albert Astals Cid
El Dimarts, 12 d'agost de 2014, a les 11:39:49, Pino Toscano va escriure: > Hi, > > On Tuesday 12 August 2014 11:56:40 Māris Nartišs wrote: > > Keep in mind the motivating factor. I joined KDE, QGIS and GRASS GIS > > translation efforts because the shipped translations were incomplete, > > imperfe

Re: Minimum translation percentage for Plasma 5 release

2014-08-12 Thread Albert Astals Cid
El Dimarts, 12 d'agost de 2014, a les 11:56:40, Māris Nartišs va escriure: > Hello Vincenzo, > I read Martin's reply as "it would not hurt to have partial translation". > > Keep in mind the motivating factor. I joined KDE, QGIS and GRASS GIS > translation efforts because the shipped translations w

Re: Review Request 119669: Fix broken creation of kstartupconfigfiles

2014-08-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119669/ --- (Updated Aug. 12, 2014, 9:42 a.m.) Status -- This change has been ma

Re: OSD above fullscreen windows

2014-08-12 Thread Marco Martin
On Tuesday 12 August 2014, Vishesh Handa wrote: > > With Volume, I can maybe understand that you don't want to show it on top > and the relevant application should be showing it. Maybe. With the others, > they definitely should be. > on use cases like a media center, i would see more being alway

Re: Re: Re: OSD above fullscreen windows

2014-08-12 Thread Vishesh Handa
On Mon, Aug 11, 2014 at 1:01 PM, Martin Gräßlin wrote: > eheh - then let's change the notifications to use window type notification > as > a first step. That's what it got introduced for. > > Whether OSD should be above active fullscreen windows or not is nothing I > want > us developers to decid

Re: Plasma 5.0.1 tars

2014-08-12 Thread Alexey Shvetsov
hi! Plasma 5.x depends on bluedevil. May be its good to have bluedevil snapshot for plasma? Jonathan Riddell писал 11-08-2014 19:58: Another update for baloo to add missing translations baloo;Plasma/5.0;4716974883972bed034ce9437489878248eff58d;baloo-5.0.1.tar.xz;9488a948b20b50bf46cba432912b