Re: Review Request 119866: Thumbnails in Klipper

> On Aug. 21, 2014, 5:39 a.m., Martin Gräßlin wrote: > > applets/clipboard/contents/ui/ClipboardItemDelegate.qml, line 62 > > > > > > what happens if you copy a normal http:// url? Is it still shown? > > Sebastia

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

> On June 16, 2014, 6:57 a.m., Martin Gräßlin wrote: > > looks good to me, +1. Please add Hugo Pereira Da Costa to the Review > > Request, though. > > > > The review request made me wonder whether we still need to find XLib in > > Oxygen, though. The parts shown only use XCB, so maybe we could

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118763/ --- (Updated Aug. 22, 2014, 3:31 p.m.) Status -- This change has been ma

Re: Review Request 119866: Thumbnails in Klipper

> On Aug. 22, 2014, 2:49 p.m., Martin Gräßlin wrote: > > klipper/clipboardjob.cpp, lines 150-155 > > > > > > why are you getting a fixed-size icon pixmap? Wouldn't it be better to > > pass the QIcon along, so th

Re: Review Request 119860: hints to disable background in dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119860/ --- (Updated Aug. 22, 2014, 2:58 p.m.) Status -- This change has been ma

Re: Review Request 119860: hints to disable background in dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119860/#review65063 --- Ship it! Ship It! - David Edmundson On Aug. 21, 2014, 1:55

Re: Review Request 119866: Thumbnails in Klipper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119866/#review65061 --- klipper/clipboardjob.h

Re: Review Request 119902: Port calculator to GridLayout and use row/colSpan

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119902/ --- (Updated Aug. 22, 2014, 2:37 p.m.) Status -- This change has been ma

Re: Review Request 119902: Port calculator to GridLayout and use row/colSpan

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119902/#review65060 --- Ship it! Ship It! - Bhushan Shah On Aug. 22, 2014, 7:54 p.

Re: Review Request 119866: Thumbnails in Klipper

> On Aug. 22, 2014, 1:55 p.m., David Edmundson wrote: > > applets/clipboard/contents/ui/ClipboardItemDelegate.qml, line 62 > > > > > > Why not just use the enum values? I've just checked, the HistoryItemType enum

Re: Review Request 119866: Thumbnails in Klipper

> On Aug. 22, 2014, 4:16 p.m., Martin Gräßlin wrote: > > there is one thing which still strikes me as odd or where another > > screenshot is needed: will the thumbnails always be on top? If yes isn't > > that destroying the aspect of the top item being the one which is currently > > in the cli

Re: Review Request 119866: Thumbnails in Klipper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119866/ --- (Updated Aug. 22, 2014, 2:33 p.m.) Review request for Plasma. Changes -

Review Request 119902: Port calculator to GridLayout and use row/colSpan

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119902/ --- Review request for Plasma and Bhushan Shah. Repository: kdeplasma-addons

Re: Review Request 119866: Thumbnails in Klipper

> On Aug. 22, 2014, 2:16 p.m., Martin Gräßlin wrote: > > there is one thing which still strikes me as odd or where another > > screenshot is needed: will the thumbnails always be on top? If yes isn't > > that destroying the aspect of the top item being the one which is currently > > in the cli

Re: Review Request 119866: Thumbnails in Klipper

> On Aug. 22, 2014, 1:55 p.m., David Edmundson wrote: > > applets/clipboard/contents/ui/ClipboardItemDelegate.qml, line 73 > > > > > > This item only contains one sub-item which fills the parent. > > > >

Re: Review Request 119866: Thumbnails in Klipper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119866/#review65056 --- there is one thing which still strikes me as odd or where anot

Re: Review Request 119866: Thumbnails in Klipper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119866/ --- (Updated Aug. 22, 2014, 2:08 p.m.) Review request for Plasma. Changes -

Re: Review Request 119866: Thumbnails in Klipper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119866/ --- (Updated Aug. 22, 2014, 2:01 p.m.) Review request for Plasma. Changes -

Re: Review Request 119866: Thumbnails in Klipper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119866/#review65050 --- QML part looks good to me. Minor nitpicks. applets/clipboard

Re: Review Request 119866: Thumbnails in Klipper

> On Aug. 20, 2014, 6:38 nachm., Kai Uwe Broulik wrote: > > File Attachment: Klipper with thumbnails - klipper-thumbnails.png > > > > > > A tooltip might be useful, there's not much room for the filename. > > Sebastian Kügler wrote: >

Re: Review Request 119866: Thumbnails in Klipper

> On Aug. 21, 2014, 7:39 a.m., Martin Gräßlin wrote: > > applets/clipboard/contents/ui/ClipboardItemDelegate.qml, line 62 > > > > > > what happens if you copy a normal http:// url? Is it still shown? > > Sebastia

Re: Review Request 119866: Thumbnails in Klipper

> On Aug. 20, 2014, 6:38 p.m., Kai Uwe Broulik wrote: > > File Attachment: Klipper with thumbnails - klipper-thumbnails.png > > > > > > A tooltip might be useful, there's not much room for the filename. I thought about this as well, but

Jenkins build is back to normal : plasma-desktop_master_qt5 #580

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119866: Thumbnails in Klipper

> On Aug. 21, 2014, 5:39 a.m., Martin Gräßlin wrote: > > applets/clipboard/contents/ui/ClipboardItemDelegate.qml, line 62 > > > > > > what happens if you copy a normal http:// url? Is it still shown? No, we're sh

Build failed in Jenkins: plasma-desktop_master_qt5 #579

See Changes: [notmart] sync changes i lnfaccess -- [...truncated 3676 lines...] : In member function ‘

Re: Review Request 112208: KMix qml applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/ --- (Updated Aug. 22, 2014, 8:26 a.m.) Review request for Plasma, Aaron J. Se