Re: Review Request 119927: Port systemloadviewer plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119927/#review65173 --- File Attachment: Screenshot - 2014-08-24-212539_505x860_scrot

Review Request 119928: bump required KF5 version to 5.2.0

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119928/ --- Review request for Plasma and Jonathan Riddell. Repository: plasma-deskto

Re: Review Request 119928: bump required KF5 version to 5.2.0

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119928/#review65174 --- Ship it! Ship It! - Jonathan Riddell On Aug. 25, 2014, 8:1

Re: Review Request 119928: bump required KF5 version to 5.2.0

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119928/ --- (Updated Aug. 25, 2014, 8:57 a.m.) Status -- This change has been di

Re: Review Request 119928: bump required KF5 version to 5.2.0

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119928/ --- (Updated Aug. 25, 2014, 8:59 a.m.) Review request for Plasma and Jonathan

Re: Review Request 119866: Thumbnails in Klipper

> On Aug. 21, 2014, 5:39 a.m., Martin Gräßlin wrote: > > applets/clipboard/contents/ui/ClipboardItemDelegate.qml, line 62 > > > > > > what happens if you copy a normal http:// url? Is it still shown? > > Sebastia

Re: Review Request 119822: QScreen backend for libkscreen

> On Aug. 18, 2014, 11:55 a.m., Àlex Fiestas wrote: > > Besides the nitpits, here is a concern I have. > > > > KScreen is a library that should be used only by components of the shell > > (kwin, plasma, kscreen), the idea is to have a library that manipulates > > lowlevel stuff directly so we

Re: Review Request 119866: Thumbnails in Klipper

> On Aug. 21, 2014, 5:39 a.m., Martin Gräßlin wrote: > > applets/clipboard/contents/ui/ClipboardItemDelegate.qml, line 62 > > > > > > what happens if you copy a normal http:// url? Is it still shown? > > Sebastia

Re: Review Request 119866: Thumbnails in Klipper

> On Aug. 21, 2014, 5:39 a.m., Martin Gräßlin wrote: > > applets/clipboard/contents/ui/ClipboardItemDelegate.qml, line 62 > > > > > > what happens if you copy a normal http:// url? Is it still shown? > > Sebastia

Re: Review Request 119866: Thumbnails in Klipper

> On Aug. 21, 2014, 5:39 a.m., Martin Gräßlin wrote: > > applets/clipboard/contents/ui/ClipboardItemDelegate.qml, line 62 > > > > > > what happens if you copy a normal http:// url? Is it still shown? > > Sebastia

Minutes Monday Plasma Hangout

Minutes Plasma Hangout, 25-8-2014 Present: Antonis, Marco, Martin G., Jonathan, Vishsesh, Kai Uwe, Sebas For updates on TODO/status, see also Kanban board at: https://todo.kde.org/?controller=board&action=show&project_id=13 Antonis: - Worked on Baloo timeline model, - will continue post-exams (

Re: Review Request 119866: Thumbnails in Klipper

> On Aug. 21, 2014, 7:39 a.m., Martin Gräßlin wrote: > > applets/clipboard/contents/ui/ClipboardItemDelegate.qml, line 62 > > > > > > what happens if you copy a normal http:// url? Is it still shown? > > Sebastia

Re: Minutes Monday Plasma Hangout

On Monday 25 August 2014 14:22:20 Sebastian Kügler wrote: > Minutes Plasma Hangout, 25-8-2014 > > Present: Antonis, Marco, Martin G., Jonathan, Vishsesh, Kai Uwe, Sebas > > For updates on TODO/status, see also Kanban board at: > https://todo.kde.org/?controller=board&action=show&project_id=13 In

Re: Review Request 119885: Use CMAKE_INSTALL_FULL_BINDIR in plasma.desktop

> On Aug. 25, 2014, 1:24 a.m., Aleix Pol Gonzalez wrote: > > plasma.desktop.cmake, line 5 > > > > > > The TryExec is wrong now? :P Oooops, fixed now. Thanks! - Dan -

Re: Review Request 119866: Thumbnails in Klipper

> On Aug. 21, 2014, 5:39 a.m., Martin Gräßlin wrote: > > applets/clipboard/contents/ui/ClipboardItemDelegate.qml, line 62 > > > > > > what happens if you copy a normal http:// url? Is it still shown? > > Sebastia

Review Request 119929: Cleaning up plasma-shell, episode 1

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119929/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Minutes Monday Plasma Hangout

On Mon, Aug 25, 2014 at 2:22 PM, Sebastian Kügler wrote: > Minutes Plasma Hangout, 25-8-2014 > > Present: Antonis, Marco, Martin G., Jonathan, Vishsesh, Kai Uwe, Sebas > > For updates on TODO/status, see also Kanban board at: > https://todo.kde.org/?controller=board&action=show&project_id=13 > >

Re: Review Request 119929: Cleaning up plasma-shell, episode 1

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119929/#review65204 --- Ship it! Inviala! - Marco Martin On Ago. 25, 2014, 1:24 p.

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 25, 2014, 3:39 p.m.) Review request for Plasma. Changes -

Re: Review Request 119794: Add button to change keyboard layout in the lockscreen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119794/ --- (Updated Aug. 25, 2014, 3:43 p.m.) Review request for Plasma. Repositor

Re: Minutes Monday Plasma Hangout

On Monday, August 25, 2014 15:26:32 Aleix Pol wrote: > What does outside of plasma mean? It's in plasma-framework right? Outside of Plasma-the-workspace-as-we-ship, not outside of plasma-framework. Basically, Maui using plasma-framework. -- sebas http://www.kde.org | http://vizZzion.org | GPG K

Re: Review Request 119929: Cleaning up plasma-shell, episode 1

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119929/#review65205 --- shell/shellcorona.cpp

Re: Review Request 119929: Cleaning up plasma-shell, episode 1

> On Aug. 25, 2014, 1:51 p.m., Kai Uwe Broulik wrote: > > Can we maybe run a script or something after this review? It's already hard enough to decode the patch... - Aleix --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review65208 --- lookandfeel/contents/lockscreen/LockScreen.qml

Re: Review Request 119929: Cleaning up plasma-shell, episode 1

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119929/#review65210 --- Ship it! I looked through it, it made sense to me. Thanks fo

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review65213 --- Ship it! Nice lookandfeel/contents/lockscreen/LockScreen.qm

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 25, 2014, 2:11 p.m.) Review request for Plasma and Andrew L

Re: Review Request 119929: Cleaning up plasma-shell, episode 1

> On Ago. 25, 2014, 1:51 p.m., Kai Uwe Broulik wrote: > > > > Aleix Pol Gonzalez wrote: > Can we maybe run a script or something after this review? It's already > hard enough to decode the patch... maybe after this is merged could be tried to run astyle from https://techbase.kde.org/Polici

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

> On Aug. 25, 2014, 2:04 p.m., Kai Uwe Broulik wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 178 > > > > > > Does that work? Shouldn't it be dataChanged() ? both work, this calls the slot, your

Re: Review Request 119721: Don't explicitly set a height on button in notification delegate.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119721/ --- (Updated Aug. 25, 2014, 2:37 p.m.) Status -- This change has been ma

Re: Review Request 119927: Port systemloadviewer plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119927/#review65217 --- applets/systemloadviewer/package/contents/ui/SystemLoadViewer

Re: Review Request 119929: Cleaning up plasma-shell, episode 1

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119929/ --- (Updated Aug. 25, 2014, 2:50 p.m.) Review request for Plasma. Changes -

Re: Review Request 119929: Cleaning up plasma-shell, episode 1

> On Aug. 25, 2014, 1:51 p.m., Kai Uwe Broulik wrote: > > > > Aleix Pol Gonzalez wrote: > Can we maybe run a script or something after this review? It's already > hard enough to decode the patch... > > Marco Martin wrote: > maybe after this is merged could be tried to run astyle from >

Re: Review Request 119929: Cleaning up plasma-shell, episode 1

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119929/ --- (Updated Aug. 25, 2014, 2:53 p.m.) Status -- This change has been ma

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

> On Aug. 25, 2014, 4:11 p.m., David Edmundson wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 167 > > > > > > does it not work to do > > visible: keystateSource.data["Caps Lock"]["Locked"] >

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 25, 2014, 3:10 p.m.) Status -- This change has been ma

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review65237 --- lookandfeel/contents/lockscreen/LockScreen.qml

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

> On Aug. 25, 2014, 5:25 p.m., David Edmundson wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 119 > > > > > > What was the point of this layout, there's only one item in it? nevermind, I got con

Review Request 119934: Make "nothing interesting going on" labels in applets consistent

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119934/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 119934: Make "nothing interesting going on" labels in applets consistent

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119934/#review65244 --- While watching the video i noticed that the text has a weird s

Re: Review Request 119934: Make "nothing interesting going on" labels in applets consistent

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119934/#review65245 --- Ship it! Inviala! - Marco Martin On Ago. 25, 2014, 6:40 p.

Re: Review Request 119934: Make "nothing interesting going on" labels in applets consistent

> On Ago. 25, 2014, 6:47 p.m., Mark Gaiser wrote: > > While watching the video i noticed that the text has a weird slide in. It > > seems to be visible right from the begginning of the animation. That gives > > a bit of a weird look since the text "overlaps" for a fraction of a second > > with

Re: Review Request 119934: Make "nothing interesting going on" labels in applets consistent

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119934/ --- (Updated Aug. 25, 2014, 7:09 p.m.) Status -- This change has been ma

Re: Review Request 119866: Thumbnails in Klipper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119866/ --- (Updated Aug. 25, 2014, 10:04 p.m.) Review request for Plasma. Changes

Re: Review Request 119866: Thumbnails in Klipper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119866/ --- (Updated Aug. 25, 2014, 11:20 p.m.) Review request for Plasma. Changes

Re: Review Request 119866: Thumbnails in Klipper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119866/#review65260 --- C++ side looks good to me. QtQuick side has at least some comm