[KDE Bugtracking System] REMINDER: current Plasma regressions

2014-09-02 Thread bugzilla_noreply
Please find below a list of the current regressions reported for Plasma. This is a weekly reminder. This search was scheduled by myr...@kde.org. Plasma regressions (1 bugs) -- Bug 301424: https://bugs.kde.org/show_bug.cgi?id=301424 Severity: normal Priority: NOR

Re: Plasma Plugin Loading

2014-09-02 Thread Marco Martin
On Tuesday 02 September 2014, Sebastian Kügler wrote: That means we can use a mechanism similar to the Qt one to query plugins and then load them, KService would be out of the picture, so would ksycoca be -- we can use the query language parser without KService.

Re: Review Request 120003: Allow changing month with mouse wheel

2014-09-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120003/#review65686 --- Ship it! Ship It! - Martin Klapetek On Aug. 30, 2014,

Review Request 120036: Note loading in Notes Plasmoid

2014-09-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120036/ --- Review request for Plasma. Repository: kdeplasma-addons Description

Re: Review Request 120036: Note loading in Notes Plasmoid

2014-09-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120036/#review65703 --- applets/notes/plugin/notemanager.cpp

Re: Review Request 120036: Note loading in Notes Plasmoid

2014-09-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120036/#review65704 --- I don't fully understand how the write to a different

Re: Review Request 120036: Note loading in Notes Plasmoid

2014-09-02 Thread David Edmundson
On Sept. 2, 2014, 11:20 a.m., Sebastian Kügler wrote: I don't fully understand how the write to a different property mechanism works. Could you expand on that? The code overall looks quite good already, but without understanding the above, I don't dare giving it a shipit. I just

Re: Plasma Plugin Loading

2014-09-02 Thread Sebastian Kügler
On Tuesday, September 02, 2014 10:22:07 Marco Martin wrote: On Tuesday 02 September 2014, Sebastian Kügler wrote: That means we can use a mechanism similar to the Qt one to query plugins and then load them, KService would be out of the picture, so would ksycoca be -- we can use the query

Re: Review Request 120036: Note loading in Notes Plasmoid

2014-09-02 Thread Sebastian Kügler
On Sept. 2, 2014, 11:20 a.m., Sebastian Kügler wrote: I don't fully understand how the write to a different property mechanism works. Could you expand on that? The code overall looks quite good already, but without understanding the above, I don't dare giving it a shipit. David

Re: Review Request 120036: Note loading in Notes Plasmoid

2014-09-02 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120036/#review65709 --- Looking good :) applets/notes/package/contents/ui/main.qml

Re: Plasma Plugin Loading

2014-09-02 Thread Aaron J. Seigo
On Tuesday, September 2, 2014 03.14:44 Sebastian Kügler wrote: per plugin queried, disk caches alleviate cases where the same plugins are read multiple times. Ultimately, the idea is to create a cache, but not ksycoca -- ask dfaure. Last time I spoke with David about this the plan was to do

Re: Review Request 120036: Note loading in Notes Plasmoid

2014-09-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120036/#review65706 --- First of all, I'm fine with this approach if this gets

Re: Plasma Plugin Loading

2014-09-02 Thread Sebastian Kügler
On Tuesday, September 02, 2014 12:45:37 Aaron J. Seigo wrote: Whatever path is taken, Plasma::PluginLoader is currently internally inconsistent. Picking a path and then making all plugins load via the same pattern would be fantastic for 3rd party developers wanting to work with the system.

Re: Plasma Plugin Loading

2014-09-02 Thread Sebastian Kügler
On Tuesday, September 02, 2014 12:45:37 Aaron J. Seigo wrote: The change for plugins is that at build-time, we're now converting the .desktop file to json, and bake that information into the plugin through Note that this is currently very limited: no i18n, very limited set of keys

Re: Plasma Plugin Loading

2014-09-02 Thread Marco Martin
On Tuesday 02 September 2014, Sebastian Kügler wrote: I think this actually is reasonably fast for our current usecases, we're only hitting the disk once on startup, the rest is hot from the caches and in those cases, my measurements didn't show a big difference compared to ksycoca. That

Re: Review Request 120036: Note loading in Notes Plasmoid

2014-09-02 Thread David Edmundson
On Sept. 2, 2014, 11:59 a.m., Marco Martin wrote: First of all, I'm fine with this approach if this gets chosen, all matters is that end up working reliably and depends from the exact use case. That said, what did strike to me, is that the problem that seems to be solved seems to

Re: Review Request 120036: Note loading in Notes Plasmoid

2014-09-02 Thread David Edmundson
On Sept. 2, 2014, 11:59 a.m., Marco Martin wrote: applets/notes/plugin/filesystemnoteloader.cpp, line 39 https://git.reviewboard.kde.org/r/120036/diff/1/?file=309277#file309277line39 I wonder if wasn't prettier/more efficient if Note and NoteManager instances were actually shared

Re: Plasma Plugin Loading

2014-09-02 Thread Aaron J. Seigo
On Tuesday, September 2, 2014 14.00:58 Sebastian Kügler wrote: On Tuesday, September 02, 2014 12:45:37 Aaron J. Seigo wrote: Whatever path is taken, Plasma::PluginLoader is currently internally inconsistent. Picking a path and then making all plugins load via the same pattern would be

Re: Review Request 119232: Rewrite the Calendar component grid + small refactor

2014-09-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119232/ --- (Updated Sept. 2, 2014, 4:11 p.m.) Status -- This change has been

Re: Plasma Plugin Loading

2014-09-02 Thread Sebastian Kügler
On Tuesday, September 02, 2014 15:58:04 Aaron J. Seigo wrote: Note that these tasks are not currently on my TODO stack. If someone else wants to work on it, that's totally cool, it's not a priority for me in this cycle. I'm sorry to hear that. Leaving that sort of work half-done is

Re: Re: Plasma Plugin Loading

2014-09-02 Thread Martin Gräßlin
On Tuesday 02 September 2014 15:58:04 Aaron J. Seigo wrote: Note that these tasks are not currently on my TODO stack. If someone else wants to work on it, that's totally cool, it's not a priority for me in this cycle. I'm sorry to hear that. Leaving that sort of work half-done is

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-09-02 Thread Martin Klapetek
On Aug. 24, 2014, 11:55 a.m., Kai Uwe Broulik wrote: applets/notifications/package/contents/ui/NotificationPopup.qml, line 60 https://git.reviewboard.kde.org/r/119916/diff/1/?file=307345#file307345line60 Why not make it take into account the button actual size? Such as Math.max(5

Re: Plasma Plugin Loading

2014-09-02 Thread David Edmundson
I think we're all a bit uncertain because there's uncertainty lower in the stack. JSON + cache is the best of both worlds, but given we don't have the cache.. it's a mixed bag. Akademy is next week, it's been added as part of our BOF agenda, and we'll bump it to be the top priority topic and

Re: Plasma Plugin Loading

2014-09-02 Thread Marco Martin
On Tuesday 02 September 2014, Martin Gräßlin wrote: On Tuesday 02 September 2014 15:58:04 Aaron J. Seigo wrote: Note that these tasks are not currently on my TODO stack. If someone else wants to work on it, that's totally cool, it's not a priority for me in this cycle. I'm sorry to

Re: Plasma Plugin Loading

2014-09-02 Thread Marco Martin
On Tuesday 02 September 2014, David Edmundson wrote: I think we're all a bit uncertain because there's uncertainty lower in the stack. JSON + cache is the best of both worlds, but given we don't have the cache.. it's a mixed bag. Akademy is next week, it's been added as part of our BOF

Re: Plasma Plugin Loading

2014-09-02 Thread Marco Martin
On Tuesday 02 September 2014, Marco Martin wrote: Lets wait till then before anyone continues this thread any further. Not sure if is more useful to make it during the plasma bof, or during one of frameworks.. probably both, we'll need anyways have David participate in that sorry, i forgot

Re: Review Request 119411: Plasmate-Kdev: Port plasmate to KDevPlatform's shell part 1

2014-09-02 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119411/ --- (Updated Sept. 2, 2014, 4:52 p.m.) Status -- This change has been

Review Request 120037: Implement scientific notation for the calculator

2014-09-02 Thread Martin Yrjölä
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120037/ --- Review request for Plasma and David Edmundson. Repository:

Re: Review Request 120037: Implement scientific notation for the calculator

2014-09-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120037/#review65726 --- Ship it! The while loop is a bit bodgy, but I can't find

Review Request 120038: Plasmate-Kdev: Port plasmate to KDevPlatform's shell part 2

2014-09-02 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120038/ --- Review request for Plasma. Repository: plasmate Description ---

Re: Review Request 120003: Allow changing month with mouse wheel

2014-09-02 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120003/ --- (Updated Sept. 2, 2014, 6:14 p.m.) Status -- This change has been

Review Request 120040: Install kdesu under bin

2014-09-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- Review request for KDE Frameworks and Plasma. Repository: kde-cli-tools

Re: Review Request 120040: Install kdesu under bin

2014-09-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- (Updated Sept. 2, 2014, 6:26 p.m.) Review request for KDE Frameworks and

Re: Review Request 120040: Install kdesu under bin

2014-09-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- (Updated Sept. 2, 2014, 6:27 p.m.) Review request for KDE Frameworks and

Re: Review Request 120040: Install kdesu under bin

2014-09-02 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/#review65732 --- doesn't actually affect the second bug, if one were to write

Re: Review Request 120040: Install kdesu under bin

2014-09-02 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/#review65734 --- kdesu/CMakeLists.txt

Re: Review Request 117499: Fix showing the user switchting dialog a second time in the screen locker

2014-09-02 Thread Felix Geyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117499/ --- (Updated Sept. 2, 2014, 6:49 p.m.) Status -- This change has been

Re: Review Request 120037: Implement scientific notation for the calculator

2014-09-02 Thread Martin Yrjölä
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120037/ --- (Updated Sept. 2, 2014, 6:51 p.m.) Status -- This change has been

Re: Review Request 120040: Install kdesu under bin

2014-09-02 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/#review65738 --- in kde4 kdesu was installed under bin it was actually also

Re: Review Request 120040: Install kdesu under bin

2014-09-02 Thread Marco Martin
On Sept. 2, 2014, 6:37 p.m., Marco Martin wrote: I'm a bit worried by the multitude of user and distro specific scripts that rely on kdesu being present :/ to me either way it gets fixed i'm ok. the other option is to keep it called kdesu, so it wouldn't be coinstallable so distributions

Jenkins build became unstable: plasma-workspace_master_qt5 #816

2014-09-02 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/816/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel