Re: System tray icon sizes

2014-09-15 Thread Marco Martin
On Friday 12 September 2014, Kai Uwe Broulik wrote: Hi, One of the problems is that most of the tray icons use a Plasma IconItem which follows the icon sizes (16, 22, 32, 48, ...) whereas a custom item does not. This is also the reason why battery and network usually appear in a

Re: Review Request 120170: Use base color for applet configuration sidebar to match widget apps

2014-09-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120170/#review66516 --- looks good. but how does it look on Oxygen? (rounded borders

Re: High DPI support - Akademy Notes

2014-09-15 Thread Marco Martin
On Sunday 14 September 2014, David Edmundson wrote: Qt's API does this on a per-screen basis. Qt's XCB backend is global reading from an environment variable. QT_DEVICE_PIXEL_RATIO=2. Qt does not take guess it from the monitor size because monitor EDID can't be trusted. we should perhaps

Re: Review Request 120170: Use base color for applet configuration sidebar to match widget apps

2014-09-15 Thread Kai Uwe Broulik
On Sept. 15, 2014, 7:58 vorm., Marco Martin wrote: looks good. but how does it look on Oxygen? (rounded borders of its frames may give a problem here) I tried it on oxygen and looked fine. I didn't see it bleeding outside. But I will check again. - Kai Uwe

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-09-15 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119916/ --- (Updated Sept. 15, 2014, 9:24 a.m.) Status -- This change has been

Re: Review Request 120151: Cleanups in Host::categories (applets/systemtray)

2014-09-15 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120151/ --- (Updated Sept. 15, 2014, 11:42 a.m.) Status -- This change has been

Re: Review Request 120205: Forward-port GTK related krdb fixes

2014-09-15 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120205/ --- (Updated Sept. 15, 2014, 9:53 a.m.) Status -- This change has been

Minutes Monday Plasma Hangout

2014-09-15 Thread Sebastian Kügler
Minutes Plasma Hangout, 15-9-2014 Present: Alex, David, Marco, Martin K., Martin G., Vishesh, Pierluigi, Kai Uwe, Sebas Announcement: Freeze coming up: https://techbase.kde.org/Schedules/Plasma_5 For updates on TODO/status, see also Kanban board at:

trying test-driven bugfixes in plasma-framework

2014-09-15 Thread Marco Martin
Hi all, Since we are trying gerrit, let's try to push it even further: Right now, we are freezed, so that means in plasma-framework, plasma-workspace et al will happen only bugfixes for a month or so. Having Gerrit on plasma-framework, I hope that makes easier for me keeping track of changes

Re: trying test-driven bugfixes in plasma-framework

2014-09-15 Thread Marco Martin
On Monday 15 September 2014, Marco Martin wrote: It's a good moment now, since being mostly bugfixes, it should be mostly atomic commits without big changes (I still have to decide if the Dialog refactor can fully be considered bugfix or if is better to wait next frameworks release, usual

Re: trying test-driven bugfixes in plasma-framework

2014-09-15 Thread David Edmundson
​Right now, we are freezed, so that means in plasma-framework, plasma-workspace et al will happen only bugfixes for a month or so. Only frameworks is frozen. For workspace, desktop etc. we have till Thursday for feature freeze. https://techbase.kde.org/Schedules/Plasma_5 as it's released a week

Re: Review Request 120179: return correct screen() even when we are still starting up

2014-09-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120179/ --- (Updated Sept. 15, 2014, 12:31 p.m.) Status -- This change has been

Re: Review Request 120179: return correct screen() even when we are still starting up

2014-09-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120179/#review66550 --- shell/shellcorona.cpp

Re: Review Request 120036: Note loading in Notes Plasmoid

2014-09-15 Thread David Edmundson
On Sept. 11, 2014, 1:17 p.m., Kai Uwe Broulik wrote: applets/notes/package/contents/ui/main.qml, line 88 https://git.reviewboard.kde.org/r/120036/diff/2/?file=310274#file310274line88 I still think you should use NativeRendering aha, it's Text.NativeRendering. On Sept. 11, 2014,

Re: Review Request 120036: Note loading in Notes Plasmoid

2014-09-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120036/ --- (Updated Sept. 15, 2014, 2:56 p.m.) Status -- This change has been

Jenkins build is back to normal : plasma-workspace_master_qt5 #859

2014-09-15 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/859/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120222: When the button is being pressed draw background like it has focus

2014-09-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120222/ --- (Updated Sept. 15, 2014, 6:29 p.m.) Review request for Plasma and Hugo

Re: 5.0.2 candidate tars

2014-09-15 Thread Jonathan Riddell
On Sun, Sep 14, 2014 at 05:02:29PM +0200, Albert Astals Cid wrote: El Diumenge, 14 de setembre de 2014, a les 15:59:17, Heiko Becker va escriure: Hi, On 12.09.2014 15:29, Jonathan Riddell wrote: Candidate tars for 5.0.2 are up at http://starsky.19inch.net/~jr/tmp/plasma-5.0.2/ and

Re: 5.0.2 candidate tars

2014-09-15 Thread Albert Astals Cid
El Diumenge, 14 de setembre de 2014, a les 17:02:29, Albert Astals Cid va escriure: El Diumenge, 14 de setembre de 2014, a les 15:59:17, Heiko Becker va escriure: Hi, On 12.09.2014 15:29, Jonathan Riddell wrote: Candidate tars for 5.0.2 are up at

Re: Review Request 120225: Draw lineedit frames as long as there is just enough space

2014-09-15 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120225/#review66615 --- Ship it! Ship It! - Hugo Pereira Da Costa On Sept. 15,

Re: Review Request 120225: Draw lineedit frames as long as there is just enough space

2014-09-15 Thread Hugo Pereira Da Costa
On Sept. 15, 2014, 9:51 p.m., Hugo Pereira Da Costa wrote: Ship It! Side note: there might be a similar issue for editable comboboxes. Can double check if you don't find time to. - Hugo --- This is an automatically generated

Re: Review Request 120225: Draw lineedit frames as long as there is just enough space

2014-09-15 Thread David Edmundson
On Sept. 15, 2014, 9:51 p.m., Hugo Pereira Da Costa wrote: Ship It! Hugo Pereira Da Costa wrote: Side note: there might be a similar issue for editable comboboxes. Can double check if you don't find time to. Looks fine. middle left http://imgur.com/l5VkjpX - David