Re: Review Request 120279: Port to KWayland client library

2014-09-21 Thread Martin Gräßlin
> On Sept. 20, 2014, 11:27 p.m., Pier Luigi Fiorini wrote: > > Modules/base/info_wayland.cpp, line 210 > > > > > > Why we need a new connection? > > QPA already has one. there is no QPA in this case. It's fo

Re: Re: Announcing KWayland library

2014-09-21 Thread Martin Gräßlin
On Saturday 20 September 2014 23:08:43 šumski wrote: > On Friday 19 of September 2014 11:06:56 Martin Gräßlin wrote: > > Hi plasma-devs, > > > > as discussed on Monday's hangout I split out KWin's Wayland handling code > > into a dedicated repository and library: > > > > git clone kde:kwayland >

Re: Review Request 120306: Exclude X11 when building for Wayland

2014-09-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120306/#review67169 --- I do not understand why this should be mutual exclusive. One o

Re: System tray icon sizes

2014-09-21 Thread Andrew Lake
On Sun, Sep 21, 2014 at 5:39 PM, David Edmundson wrote: > >> ​Padding inside the SVG? > > >Yes > > I don't think this is the right long-term approach. We end up with > problems like in the original post where it's difficult to make another > item line up with an icon. > > IMHO padding should be ap

Re: System tray icon sizes

2014-09-21 Thread David Edmundson
>> ​Padding inside the SVG? >Yes I don't think this is the right long-term approach. We end up with problems like in the original post where it's difficult to make another item line up with an icon. IMHO padding should be applied at a QML level, not inside the component. It makes the behaviour a

Re: System tray icon sizes

2014-09-21 Thread Andrew Lake
On Sep 21, 2014 3:47 PM, "David Edmundson" wrote: > > ​Padding inside the SVG? Yes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: System tray icon sizes

2014-09-21 Thread David Edmundson
​Padding inside the SVG? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120306: Exclude X11 when building for Wayland

2014-09-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120306/#review67165 --- Why are we exclusive at compile time? - David Edmundson On

Re: startkde script has some qt4 relics

2014-09-21 Thread David Edmundson
> > > 1. qdbus is a relic of qt4 > > No it isn't. qdbus exists in qt5 too. > In my case qt4 and qt5 are in different prefixes. I suggest either set the qt paths in /etc/profile.d or in .pam_environment. (see man pam_env) ___ Plasma-devel mailing list

startkde script has some qt4 relics

2014-09-21 Thread Treeve Jelbert
startkde has the following code: # in case we have been started with full pathname spec without being in PATH bindir=`echo "$0" | sed -n 's,^\(/.*\)/[^/][^/]*$,\1,p'` if [ -n "$bindir" ]; then qbindir=`qtpaths --binaries-dir` qdbus=$qbindir/qdbus case $PATH in $bindir|$bindir:*|*:$bindir

[Breeze] [Bug 158379] Draw focus rect in Kate Part instead of Widget Style (Oxygen)

2014-09-21 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=158379 Hugo Pereira Da Costa changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED

Review Request 120306: Exclude X11 when building for Wayland

2014-09-21 Thread Pier Luigi Fiorini
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120306/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: System tray icon sizes

2014-09-21 Thread Andrew Lake
On Sun, Sep 21, 2014 at 2:06 AM, Marco Martin wrote: > Btw, since we are refining systray icons, do they work also on a size of > 22x22(if not I'll fix the code)? I would love to get rid of the old hack of > 24x24, that is just a remnant of the xembed legacy icons > > I changed the padding rect o

Re: Review Request 120298: Enable lastfmimagefetchertest again,

2014-09-21 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120298/ --- (Updated Sept. 21, 2014, 2:06 p.m.) Status -- This change has been m

Re: Review Request 119218: Add option to toggle between PerspectiveCrop/Fit while viewing images

2014-09-21 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119218/ --- (Updated Sept. 21, 2014, 1:59 p.m.) Status -- This change has been m

Re: System tray icon sizes

2014-09-21 Thread Kai Uwe Broulik
> Btw, since we are refining systray icons, do they work also on a size of > 22x22(if not I'll fix the code)? I would love to get rid of the old hack of > 24x24, that is just a remnant of the xembed legacy icons Is that the reason why even if I use units.roundToIconSize on the batterymonitor t

Re: System tray icon sizes

2014-09-21 Thread Eike Hein
Tangentially related: The icons aren't horizontally centered in a vertical panel. Cheers, Eike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119218: Add option to toggle between PerspectiveCrop/Fit while viewing images

2014-09-21 Thread R.Harish Navnit
> On Sept. 21, 2014, 12:24 p.m., Shantanu Tushar wrote: > > Ship It! Worth reminding that I lack commit acccess :) - R.Harish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119218/#revi

Re: KPackage framework in playground

2014-09-21 Thread Albert Astals Cid
El Divendres, 19 de setembre de 2014, a les 13:43:47, Marco Martin va escriure: > Hi all, > After the discussions done at akademy and here about a standalone framework > for Package, due to the potential interest by other applications in order to > ship their own scripts/extensions/themes/graphics

Re: System tray icon sizes

2014-09-21 Thread Marco Martin
On Sep 21, 2014 10:39 AM, "Andrew Lake" wrote: > > Correction: it's a 30x30 padding rect that gets the icon sizes the same, not a 32x32 padding rect. > The battery (and possibly metworkmanager) were known for being a bit too big. I have now added api to make it possible to compute the correct size

Jenkins build is back to stable : plasma-workspace_master_qt5 #880

2014-09-21 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: System tray icon sizes

2014-09-21 Thread Andrew Lake
Correction: it's a 30x30 padding rect that gets the icon sizes the same, not a 32x32 padding rect. Hope this helps, Andrew On Sun, Sep 21, 2014 at 1:17 AM, Andrew Lake wrote: > I'm running into a little bit of the inconsistency in systray icon sizes > as we're working to try to improve the systr

Re: System tray icon sizes

2014-09-21 Thread Andrew Lake
I'm running into a little bit of the inconsistency in systray icon sizes as we're working to try to improve the systray icons. http://wstaw.org/m/2014/09/21/5.1_systray_scaling_bug.png The icons are still a WIP so please ignore that for the moment. All the icons are 16x16 sitting on a padding rec