Re: Fwd: Plasma Framework problems

2014-10-12 Thread David Edmundson
I'll report back when I've confirmed this and then we can work out how we proceed. Reverting a3932843386a29faa3c62bf2934a173a3781d56c does indeed make everything work. Assuming we don't have a time machine our options are: - revert this commit and release plasma-framework 5.3.1 really

Review Request 120563: Add support for installing .comic packages again to plasmapkg2.

2014-10-12 Thread Andrei Amuraritei
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120563/ --- Review request for Plasma, Bhushan Shah, David Edmundson, Marco Martin,

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-10-12 Thread Andrei Amuraritei
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Oct. 12, 2014, 7:06 p.m.) Review request for Plasma, David

Re: Review Request 120526: Strip PowerDevilCore, PowerDevilUI and PowerDevil's kded from kdelibs4support

2014-10-12 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120526/ --- (Updated Oct. 12, 2014, 7:23 p.m.) Review request for Plasma, Solid,

Review Request 120564: Write default file manager into mimeapps.list in XDG_CONFIG_HOME

2014-10-12 Thread Luc Menut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120564/ --- Review request for Plasma and David Faure. Repository: plasma-desktop

Re: Should favourites be shared between launchers, and launcher instances?

2014-10-12 Thread Ivan Čukić
i was thinking about an api for the scripting interface to do the defaults.. if preferred:// is used it would be less needed, but could still be useful. Is there a particular need for it to be scripted instead of being in a global config file? I'd say that reading a config file is a bit

Re: Fwd: Plasma Framework problems

2014-10-12 Thread David Edmundson
On 12 Oct 2014 18:04, šumski hrvoje.sen...@gmail.com wrote: On Sunday 12 of October 2014 11:58:44 David Edmundson wrote: I'll report back when I've confirmed this and then we can work out how we proceed. Reverting a3932843386a29faa3c62bf2934a173a3781d56c does indeed make

Review Request 120568: Save the default browser into the group [Default Applications]

2014-10-12 Thread Luc Menut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120568/ --- Review request for Plasma and David Faure. Repository: plasma-desktop

Review Request 120569: Save the default email client into the group [Default Applications]

2014-10-12 Thread Luc Menut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120569/ --- Review request for Plasma and David Faure. Repository: plasma-desktop

Re: Review Request 120568: Save the default browser into the group [Default Applications]

2014-10-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120568/#review68292 --- kcms/componentchooser/componentchooserbrowser.cpp

Re: Review Request 120568: Save the default browser into the group [Default Applications]

2014-10-12 Thread Luc Menut
On oct. 12, 2014, 8:51 après-midi, David Faure wrote: kcms/componentchooser/componentchooserbrowser.cpp, line 102 https://git.reviewboard.kde.org/r/120568/diff/1/?file=318115#file318115line102 No, I am very much against this. The whole point of use the right KDE app is

Re: Review Request 120568: Save the default browser into the group [Default Applications]

2014-10-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120568/#review68295 --- Wouldn't it make sense to have this within KToolInvocation?

Re: Moving SVGTextureNode to KDeclarative

2014-10-12 Thread Martin Gräßlin
On Friday 10 October 2014 17:58:04 Aleix Pol wrote: Hi, I'm looking into using QQuickItem to properly perform the QIconItem drawing, instead of QPainterItem. To do so, I thought it could be useful to use the SVGTextureNode for the ref-counting. It's quite a simple class, but it is quite

Re: Re: Fwd: Plasma Framework problems

2014-10-12 Thread Martin Gräßlin
On Sunday 12 October 2014 20:48:36 David Edmundson wrote: On 12 Oct 2014 18:04, šumski hrvoje.sen...@gmail.com wrote: On Sunday 12 of October 2014 11:58:44 David Edmundson wrote: I'll report back when I've confirmed this and then we can work out how we proceed. Reverting