Re: Review Request 120566: Remove CMake cruft.

> On Oct. 12, 2014, 11:37 p.m., Aleix Pol Gonzalez wrote: > > What do you mean by "toggle find_package"? -DCMAKE_DISABLE_FIND_PACKAGE_Phonon4Qt5. This is consistent approach with other optional dependencies. - Michael --- This is an au

Re: Re: Fwd: Plasma Framework problems

On Sunday 12 October 2014 20:48:36 David Edmundson wrote: > On 12 Oct 2014 18:04, "šumski" wrote: > > On Sunday 12 of October 2014 11:58:44 David Edmundson wrote: > > > > I'll report back when I've confirmed this and then we can work out > > how we > > > > > proceed. > > > > > > > > Reverting a

Re: Moving SVGTextureNode to KDeclarative

On Friday 10 October 2014 17:58:04 Aleix Pol wrote: > Hi, > I'm looking into using QQuickItem to properly perform the QIconItem > drawing, instead of QPainterItem. To do so, I thought it could be useful to > use the SVGTextureNode for the ref-counting. > > It's quite a simple class, but it is quit

Re: Review Request 120568: Save the default browser into the group [Default Applications]

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120568/#review68295 --- Wouldn't it make sense to have this within KToolInvocation? It

Re: Review Request 120566: Remove CMake cruft.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120566/#review68294 --- What do you mean by "toggle find_package"? - Aleix Pol Gonzal

Re: Review Request 120568: Save the default browser into the group [Default Applications]

> On oct. 12, 2014, 8:51 après-midi, David Faure wrote: > > kcms/componentchooser/componentchooserbrowser.cpp, line 102 > > > > > > No, I am very much against this. > > > > The whole point of "use the ri

Re: Review Request 120568: Save the default browser into the group [Default Applications]

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120568/#review68292 --- kcms/componentchooser/componentchooserbrowser.cpp

Review Request 120569: Save the default email client into the group [Default Applications]

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120569/ --- Review request for Plasma and David Faure. Repository: plasma-desktop D

Review Request 120568: Save the default browser into the group [Default Applications]

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120568/ --- Review request for Plasma and David Faure. Repository: plasma-desktop D

Re: Fwd: Plasma Framework problems

On 12 Oct 2014 18:04, "šumski" wrote: > > On Sunday 12 of October 2014 11:58:44 David Edmundson wrote: > > > I'll report back when I've confirmed this and then we can work out how we > > > proceed. > > > > > > Reverting a3932843386a29faa3c62bf2934a173a3781d56c does indeed make > > > > everything w

Review Request 120566: Remove CMake cruft.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120566/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Should favourites be shared between launchers, and launcher instances?

> i was thinking about an api for the scripting interface to do the defaults.. > if preferred:// is used it would be less needed, but could still be useful. Is there a particular need for it to be scripted instead of being in a global config file? I'd say that reading a config file is a bit fa

Review Request 120565: Save the default file manager into the group [Default Applications]

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120565/ --- Review request for Plasma and David Faure. Repository: plasma-desktop D

Review Request 120564: Write default file manager into mimeapps.list in XDG_CONFIG_HOME

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120564/ --- Review request for Plasma and David Faure. Repository: plasma-desktop D

Re: Review Request 120526: Strip PowerDevilCore, PowerDevilUI and PowerDevil's kded from kdelibs4support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120526/ --- (Updated Oct. 12, 2014, 7:23 p.m.) Review request for Plasma, Solid, Àlex

Re: Fwd: Plasma Framework problems

On Sunday 12 of October 2014 11:58:44 David Edmundson wrote: > > I'll report back when I've confirmed this and then we can work out how we > > proceed. > > > > Reverting a3932843386a29faa3c62bf2934a173a3781d56c does indeed make > > everything work. > > Assuming we don't have a time machine our o

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Oct. 12, 2014, 7:06 p.m.) Review request for Plasma, David Edmun

Review Request 120563: Add support for installing .comic packages again to plasmapkg2.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120563/ --- Review request for Plasma, Bhushan Shah, David Edmundson, Marco Martin, and

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Oct. 12, 2014, 6:53 p.m.) Review request for Plasma, David Edmun

Re: Review Request 120526: Strip PowerDevilCore, PowerDevilUI and PowerDevil's kded from kdelibs4support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120526/ --- (Updated Oct. 12, 2014, 4:05 p.m.) Review request for Plasma, Solid, Àlex

Re: Fwd: Plasma Framework problems

> > > I'll report back when I've confirmed this and then we can work out how we > proceed. > > Reverting a3932843386a29faa3c62bf2934a173a3781d56c does indeed make everything work. Assuming we don't have a time machine our options are: - revert this commit and release plasma-framework 5.3.1 really